Re: [PATCH v2] gpio: vortex: add new GPIO device driver

[Marcos Del Sol Vives <marcos@orca.pet>]

El 11/07/2025 a las 16:53, Andy Shevchenko escribió:
> Can you share (via some sharing resource) the following (as root user!):
> 1) `dmesg` to the boot to shell when kernel command line has 'ignore_loglevel'
> 2) `lspci -nk -vv`
> 3) `acpidump -o vortex-dx3.dat` (the *.dat file)
> 4) `grep -H 15 /sys/bus/acpi/devices/*/status`
> 5) `cat /proc/interrupts`
> 6) `cat /proc/iomem`
> 7) `cat /proc/ioport`

I have uploaded all the files to https://orca.pet/vortex/gpio-patch-files.tar.xz.
I have also added the configuration file I used for the kernel, as well as
the cmdline.

The machine is currently running Linux on commit
d006330be3f782ff3fb7c3ed51e617e01f29a465 with this patch and another that
builds upon it for poweroff applied.

The cmdline has pci=nomsi due to a hardware issue acknowledged by DM&P
(https://2018.compactpc.com.tw/2014%20DMP%20Webiste/Linux%20Support%20List/debian_9.4_installation_guide.pdf)
for which I have already submited another patch to the PCI mailing list to
disable it automatically
(https://lore.kernel.org/all/20250705233209.721507-1-marcos@orca.pet/).

If you need any other files please let me know :)

> Is that the only datasheet you have?

Yes. I guess I could ask DM&P or ICOP for another under NDA but as of today
I do not have access to anything else.

El 11/07/2025 a las 17:01, Andy Shevchenko escribió:
>> Again I want to point out I am not an expert by any means. This is my first
>> kernel driver and I am writting it as a hobbyst, not as a company employee.
> 
> Oh, I see. Sorry that I'm asking too much (do I?) Unfortunately the review
> might be not well appreciated process by the author, but we are all for
> having the better solutions. That's the part of learning and R&D process.

Not at all, you're not asking for too much at all! I understand you don't
want to merge a half baked driver in the kernel.

I was just mentioning that to clarify that if the driver looks sloppy at
the moment is not because of a lack of care, it's rather because of a lack
of experience - I am not familiar with neither the Linux driver model nor
the technologies that are deprecated and should be avoided.

Also and to clarify that, as I said above, I do not have access to the
documentation an employee would have about the SoC's inner workings.

>> The company is seemingly launching next year also a Vortex86EX3 with proper
>> i686 and SSE2 support, I guess because Intel's patents have finally expired.
>>
>> So I do not think removing i486 support is gonna be an issue except for
>> very ancient processors that the company is not making anymore anyway.
> 
> Thanks for clarifications here!
> 
> And thank you for your efforts, I would like to help as much as I can.
> Again, sorry, if my first messages looked a bit rejecting. I do not mean
> that, it's just a professional deformation due to tons of reviews I have
> done in the past.
> 

No problem, sir! :)