From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3501DC4CEC5 for ; Fri, 13 Sep 2019 13:11:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 05B2A214AE for ; Fri, 13 Sep 2019 13:11:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388420AbfIMNLf (ORCPT ); Fri, 13 Sep 2019 09:11:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:57230 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388968AbfIMNLa (ORCPT ); Fri, 13 Sep 2019 09:11:30 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5B61AAF77; Fri, 13 Sep 2019 13:11:28 +0000 (UTC) Subject: Re: [PATCH 7/8] drm/vram: drop verify_access To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , open list References: <20190913122908.784-1-kraxel@redhat.com> <20190913122908.784-8-kraxel@redhat.com> From: Thomas Zimmermann Openpgp: preference=signencrypt Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNKFRob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmNvbT7CwJQEEwEIAD4W IQRyF/usjOnPY0ShaOVoDcEdUwt6IwUCWznTtgIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgID AQIeAQIXgAAKCRBoDcEdUwt6I7D7CACBK42XW+7mCiK8ioXMEy1NzGbXC51RzGea8N83oEJS 1KVUtQxrkDxgrW/WLSl/TfqHFsJpdEFOv1XubWbleun3uKPy0e5vZCd5UjZPkeNjnqfCYTDy hVVsdOuFbtWDppJyJrThLqr9AgSFmoCNNUt1SVpYEEOLNE6C32BhlnSq21VLC+YXTgO/ZHTa YXkq54hHj63jwrcjkBSCkXLh37kHeqnl++GHpN+3R+o3w2OpwHAlvVjdKPT27v1tVkiydsFG 65Vd0n3m/ft+IOrGgxQM1C20uqKvsZGB4r3OGR50ekAybO7sjEJJ1Obl4ge/6RRqcvKz4LMb tGs85D6tPIeFzsBNBFs50uABCADGJj+DP1fk+UWOWrf4O61HTbC4Vr9QD2K4fUUHnzg2B6zU R1BPXqLGG0+lzK8kfYU/F5RjmEcClsIkAaFkg4kzKP14tvY1J5+AV3yNqcdg018HNtiyrSwI E0Yz/qm1Ot2NMZ0DdvVBg22IMsiudQ1tx9CH9mtyTbIXgACvl3PW2o9CxiHPE/bohFhwZwh/ kXYYAE51lhinQ3oFEeQZA3w4OTvxSEspiQR8dg8qJJb+YOAc5IKk6sJmmM7JfFMWSr22satM 23oQ3WvJb4RV6HTRTAIEyyZS7g2DhiytgMG60t0qdABG5KXSQW+OKlZRpuWwKWaLh3if/p/u 69dvpanbABEBAAHCwHwEGAEIACYWIQRyF/usjOnPY0ShaOVoDcEdUwt6IwUCWznS4AIbDAUJ A8JnAAAKCRBoDcEdUwt6I6X3CACJ8D+TpXBCqJE5xwog08+Dp8uBpx0T9n1wE0GQisZruACW NofYn8PTX9k4wmegDLwt7YQDdKxQ4+eTfZeLNQqWg6OCftH5Kx7sjWnJ09tOgniVdROzWJ7c VJ/i0okazncsJ+nq48UYvRGE1Swh3A4QRIyphWX4OADOBmTFl9ZYNPnh23eaC9WrNvFr7yP7 iGjMlfEW8l6Lda//EC5VpXVNza0xeae0zFNst2R9pn+bLkihwDLWxOIyifGRxTqNxoS4I1aw VhxPSVztPMSpIA/sOr/N/p6JrBLn+gui2K6mP7bGb8hF+szfArYqz3T1rv1VzUWAJf5Wre5U iNx9uqqx Message-ID: <03fc182c-c9fd-d43f-66ac-7e0e3c3d34c5@suse.de> Date: Fri, 13 Sep 2019 15:11:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190913122908.784-8-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="B4ubPbblfygnnrPXdd669gDn5RYdmiFuB" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --B4ubPbblfygnnrPXdd669gDn5RYdmiFuB Content-Type: multipart/mixed; boundary="TAKKNywCAPAMOgux3zEvO2oPBgSoQ11vE"; protected-headers="v1" From: Thomas Zimmermann To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , open list Message-ID: <03fc182c-c9fd-d43f-66ac-7e0e3c3d34c5@suse.de> Subject: Re: [PATCH 7/8] drm/vram: drop verify_access References: <20190913122908.784-1-kraxel@redhat.com> <20190913122908.784-8-kraxel@redhat.com> In-Reply-To: <20190913122908.784-8-kraxel@redhat.com> --TAKKNywCAPAMOgux3zEvO2oPBgSoQ11vE Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 13.09.19 um 14:29 schrieb Gerd Hoffmann: > Not needed any more. >=20 > Signed-off-by: Gerd Hoffmann Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_gem_vram_helper.c | 22 ---------------------- > 1 file changed, 22 deletions(-) >=20 > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/dr= m_gem_vram_helper.c > index e100b97ea6e3..42ee80414273 100644 > --- a/drivers/gpu/drm/drm_gem_vram_helper.c > +++ b/drivers/gpu/drm/drm_gem_vram_helper.c > @@ -469,13 +469,6 @@ static void drm_gem_vram_bo_driver_evict_flags(str= uct drm_gem_vram_object *gbo, > *pl =3D gbo->placement; > } > =20 > -static int drm_gem_vram_bo_driver_verify_access(struct drm_gem_vram_ob= ject *gbo, > - struct file *filp) > -{ > - return drm_vma_node_verify_access(&gbo->bo.base.vma_node, > - filp->private_data); > -} > - > static void drm_gem_vram_bo_driver_move_notify(struct drm_gem_vram_obj= ect *gbo, > bool evict, > struct ttm_mem_reg *new_mem) > @@ -767,20 +760,6 @@ static void bo_driver_evict_flags(struct ttm_buffe= r_object *bo, > drm_gem_vram_bo_driver_evict_flags(gbo, placement); > } > =20 > -static int bo_driver_verify_access(struct ttm_buffer_object *bo, > - struct file *filp) > -{ > - struct drm_gem_vram_object *gbo; > - > - /* TTM may pass BOs that are not GEM VRAM BOs. */ > - if (!drm_is_gem_vram(bo)) > - return -EINVAL; > - > - gbo =3D drm_gem_vram_of_bo(bo); > - > - return drm_gem_vram_bo_driver_verify_access(gbo, filp); > -} > - > static void bo_driver_move_notify(struct ttm_buffer_object *bo, > bool evict, > struct ttm_mem_reg *new_mem) > @@ -837,7 +816,6 @@ static struct ttm_bo_driver bo_driver =3D { > .init_mem_type =3D bo_driver_init_mem_type, > .eviction_valuable =3D ttm_bo_eviction_valuable, > .evict_flags =3D bo_driver_evict_flags, > - .verify_access =3D bo_driver_verify_access, > .move_notify =3D bo_driver_move_notify, > .io_mem_reserve =3D bo_driver_io_mem_reserve, > .io_mem_free =3D bo_driver_io_mem_free, >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 21284 (AG N=C3=BCrnberg) --TAKKNywCAPAMOgux3zEvO2oPBgSoQ11vE-- --B4ubPbblfygnnrPXdd669gDn5RYdmiFuB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl17lX8ACgkQaA3BHVML eiMhmQf/aQRBU6TX24aYux0DF9HFWQPuS0iR0IGsNMyTwRDU74bgaxO8ioZgpItR saRSvuXmIHT7iQxONAvEvFOj8ja1U2TkabxLb91YoYnz0TGMQ2j2qE7CufVSs0O+ bFmtaQL21LUFo/rTNNzpwlsqkkEPK4Uu8XaVT07PE20FzPWgCRJ7zm0hCXlg02ww RIoCb02cUURq8t/41qICQ/O1orm1WPsKeOn2KIcZ8IW6wIlSGnd3E3utkqodWLtz ZMKfoZ5zgsljXS4CbnmZZPhP6mbuLGZHE9OGwrJZRpTyLg1UBrh2hSROXxaLiC5e N6YwncTh9AmhUpuQS2v5CPpqYxbGMQ== =YT4g -----END PGP SIGNATURE----- --B4ubPbblfygnnrPXdd669gDn5RYdmiFuB--