From: Shuah Khan <shuah@kernel.org>
To: Dominik Brodowski <linux@dominikbrodowski.net>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Shuah Khan <shuah@kernel.org>,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] selftest/vDSO: fix O=
Date: Tue, 13 Feb 2018 14:30:14 -0700 [thread overview]
Message-ID: <03fc8983-8ed2-0a49-4268-6dd1f79d22fa@kernel.org> (raw)
In-Reply-To: <20180211105950.14720-1-linux@dominikbrodowski.net>
On 02/11/2018 03:59 AM, Dominik Brodowski wrote:
> The vDSO selftests ignored the O= or KBUILD_OUTPUT= parameters. Fix it.
>
> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
> ---
> tools/testing/selftests/vDSO/Makefile | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tools/testing/selftests/vDSO/Makefile b/tools/testing/selftests/vDSO/Makefile
> index 3d5a62ff7d31..f5d7a7851e21 100644
> --- a/tools/testing/selftests/vDSO/Makefile
> +++ b/tools/testing/selftests/vDSO/Makefile
> @@ -1,4 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0
> +include ../lib.mk
> +
> ifndef CROSS_COMPILE
> CFLAGS := -std=gnu99
> CFLAGS_vdso_standalone_test_x86 := -nostdlib -fno-asynchronous-unwind-tables -fno-stack-protector
> @@ -6,16 +8,14 @@ ifeq ($(CONFIG_X86_32),y)
> LDLIBS += -lgcc_s
> endif
>
> -TEST_PROGS := vdso_test vdso_standalone_test_x86
> +TEST_PROGS := $(OUTPUT)/vdso_test $(OUTPUT)/vdso_standalone_test_x86
>
> all: $(TEST_PROGS)
> -vdso_test: parse_vdso.c vdso_test.c
> -vdso_standalone_test_x86: vdso_standalone_test_x86.c parse_vdso.c
> +$(OUTPUT)/vdso_test: parse_vdso.c vdso_test.c
> +$(OUTPUT)/vdso_standalone_test_x86: vdso_standalone_test_x86.c parse_vdso.c
> $(CC) $(CFLAGS) $(CFLAGS_vdso_standalone_test_x86) \
> vdso_standalone_test_x86.c parse_vdso.c \
> - -o vdso_standalone_test_x86
> + -o $@
>
> -include ../lib.mk
> -clean:
> - rm -fr $(TEST_PROGS)
> +EXTRA_CLEAN := $(TEST_PROGS)
> endif
>
Thanks for the patch. Applied to linux-kselftest fixes for 4.16-rc3
thanks,
-- Shuah
prev parent reply other threads:[~2018-02-13 21:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-11 10:59 Dominik Brodowski
2018-02-13 21:30 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03fc8983-8ed2-0a49-4268-6dd1f79d22fa@kernel.org \
--to=shuah@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®