From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751374AbdAOPYV (ORCPT ); Sun, 15 Jan 2017 10:24:21 -0500 Received: from mout.web.de ([212.227.15.4]:56234 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751111AbdAOPYT (ORCPT ); Sun, 15 Jan 2017 10:24:19 -0500 Subject: [PATCH 24/46] selinux: Return directly after a failed kzalloc() in cat_read() To: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Eric Paris , James Morris , Paul Moore , "Serge E. Hallyn" , Stephen Smalley , William Roberts References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <04142c87-5826-4796-c461-ec3e80f14928@users.sourceforge.net> Date: Sun, 15 Jan 2017 16:24:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:f8tM57CyLIPvz9mk2gokgFcnTp/IMDZ0mwJMtYywmtlXkqKRg72 CM0Izr+ryEBRu/57KS0ZpN90OY3SClHzDmQG+PstWoWBUV/wTOYkCjJbS5fI8TbXEvj0TvH W48QecBYqrhl4Wm2SQujoYRl2hsALfYIcCYyNgSbtlcoB5rlUaVMuhYMPR8Uo8raXp9XmGr 6g1EgT87oLxSDYRqHEv9g== X-UI-Out-Filterresults: notjunk:1;V01:K0:D/chuB3ZCCo=:zqh41RA5urFzND1Kj9OHAj 84C7MWgrb5OcnMs+JYA4rbG7RzjewLf4FrxJ6oMukNxetV6RdB98UJnIdawcTUmIdsLIVRL/z sCYOjA2IqVx5tghdVjU/+4xOB/dfXd6WSVy0XKsUPk5pkZ8Zu4kRLSuNam2/w2p/N+VUNy05m vPH0Pt2aewyxnl3oD/uFiDZyO81eZfHNOOOkQxRpM/eek3JmYSCH2OfxL70JGFF8CkvOzlvGJ oo7bD2Jz1/Bx+C4xb3CFPqiISdBcnAH5ggTUkgV52LkjXrA/sdk9o8C0fgWpD7eHouzVolrRo 6qNw1OsTAWgtNEtoNSe1K2/W7DybLAyDWgvUy2OQewAo+JL8r3QUmKmMF8k6E0EPTXqqInxdg InGAdwY72boPTI+IcalRAyTZVksg0bZfUjlL4RXh+2Xqav0gBvWTSEwniIaQXFcvGfUfJwPaa poX/Jsmq3HKPeKWhXHTidwUeLqU9uo2mWw7smgvGD8JC5reBQQCkGLmHIpf/F3t7O66zkPRZl c9taJC4Ds7ra+KMRY6dAKEqPw8lz1qT2C+P8AbiK6AwuK+xx4XGn9L7udRYRv75MmO7IrRM37 6/9ySZ7k4TQkvV+i9RPAUadVd8qOAaOVn/Fz7Ht/Ac3VKeatZe+GeGPUzLolsFZsXY4cbVKyH OxA3g4ZntqERUA9PeENhXEgnccCLW4ddemzS1okzGz8Z5ce+lFlorBnV9a6uEYHjYrc1q6AWD DYkytVb2j7lNkmQfnhLEBos1Vth380D542KYJOFjJVeOhLPqCyi923HSQmpvTWkALNpzaF2tT oFhKA+V Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 14 Jan 2017 21:20:43 +0100 Return directly after a call of the function "kzalloc" failed at the beginning. Signed-off-by: Markus Elfring --- security/selinux/ss/policydb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c index 5101592ae172..eb898dcbe502 100644 --- a/security/selinux/ss/policydb.c +++ b/security/selinux/ss/policydb.c @@ -1635,10 +1635,9 @@ static int cat_read(struct policydb *p, struct hashtab *h, void *fp) __le32 buf[3]; u32 len; - rc = -ENOMEM; catdatum = kzalloc(sizeof(*catdatum), GFP_ATOMIC); if (!catdatum) - goto bad; + return -ENOMEM; rc = next_entry(buf, fp, sizeof buf); if (rc) -- 2.11.0