From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F26CC433F5 for ; Thu, 24 Mar 2022 13:49:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350576AbiCXNul (ORCPT ); Thu, 24 Mar 2022 09:50:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345620AbiCXNuh (ORCPT ); Thu, 24 Mar 2022 09:50:37 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B550CE17; Thu, 24 Mar 2022 06:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1648129744; x=1679665744; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=ISZkT7ez62uWWDwYq2cHf4s9T2fz9Gv58AVd0CvmmJA=; b=OeVpqSta5zIxuud0mxBoyein1eOvDvt1laKF7gY1b/gKR6x2sXo+LZHO yQknolA54jAu80kx5PZoiImNlx0kcMxVVbIYh1Xm0juh+vECjZNIpZolJ hjyaR2SU74Ui0PuJ8T2mBHJM6ko8Q1Wa8H3CAD4WXhng7FIUKouTiUQmg Q=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-02.qualcomm.com with ESMTP; 24 Mar 2022 06:49:04 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2022 06:49:03 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 24 Mar 2022 06:49:03 -0700 Received: from [10.110.37.17] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 24 Mar 2022 06:49:02 -0700 Message-ID: <0419edf0-89ba-7db8-7f8f-7682d2af3e7c@quicinc.com> Date: Thu, 24 Mar 2022 06:48:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v1 1/3] ARM: dts: aspeed: Add video engine Content-Language: en-US To: Howard Chiu , "robh+dt@kernel.org" , Joel Stanley , "andrew@aj.id.au" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" References: From: Jae Hyun Yoo In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Howard, On 3/24/2022 12:27 AM, Howard Chiu wrote: > The ast2600 SoC has an embedded video engine > > Signed-off-by: Howard Chiu > --- > arch/arm/boot/dts/aspeed-g6.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi > index c32e87fad4dc..41d5087f7d92 100644 > --- a/arch/arm/boot/dts/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi > @@ -389,6 +389,17 @@ sbc: secure-boot-controller@1e6f2000 { > reg = <0x1e6f2000 0x1000>; > }; > > + video: video@1e700000 { > + compatible = "aspeed,ast2600-video-engine"; > + reg = <0x1e700000 0x1000>; > + clocks = <&syscon ASPEED_CLK_GATE_VCLK>, > + <&syscon ASPEED_CLK_GATE_ECLK>; > + clock-names = "vclk", "eclk"; > + interrupts = ; > + resets = <&syscon ASPEED_RESET_VIDEO>; Video engine reset is handled by clk-ast2600.c so you don't need to add 'resets'. > + status = "disabled"; > + }; > + This node was already added back by this change. https://lore.kernel.org/all/CACPK8XfPPLoS=mhwbAHY4EfVad=1_dnhB+gaHBjPj1wWbWE4gg@mail.gmail.com/ Cheers, -Jae > gpio0: gpio@1e780000 { > #gpio-cells = <2>; > gpio-controller;