From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2849C433E2 for ; Mon, 14 Sep 2020 08:21:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B494214F1 for ; Mon, 14 Sep 2020 08:21:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726227AbgINIV6 (ORCPT ); Mon, 14 Sep 2020 04:21:58 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:54421 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726180AbgINIV5 (ORCPT ); Mon, 14 Sep 2020 04:21:57 -0400 Received: from [125.35.49.90] (helo=[10.0.0.22]) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kHjkG-0004vh-Kg; Mon, 14 Sep 2020 08:21:53 +0000 Subject: Re: [PATCH] ALSA: hda/realtek: Enable front panel headset LED on Lenovo ThinkStation P520 To: Kai-Heng Feng Cc: "moderated list:SOUND" , Kailang Yang , tiwai@suse.com, open list , Thomas Hebb , Jian-Hong Pan , Huacai Chen , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= References: <20200914070231.13192-1-kai.heng.feng@canonical.com> <07CC762F-BA94-43C0-A8C8-5B3C43291F3E@canonical.com> From: Hui Wang Message-ID: <041af07f-6168-19ed-dddd-1fd30a75b020@canonical.com> Date: Mon, 14 Sep 2020 16:21:44 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <07CC762F-BA94-43C0-A8C8-5B3C43291F3E@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/9/14 下午4:07, Kai-Heng Feng wrote: > Hi Hui, > >> On Sep 14, 2020, at 16:04, Hui Wang wrote: >> >> Thanks Kaiheng, and we just had one P520 in the Beijing office and I also worked on this issue happenly. Does the led change according to jack plugging in or plugging out with your patch? > No, the LED won't reflect the jack plugging status. > > The LED is always on under Windows, so we are doing the same here. Weird, the bug's title is "The backlight for a headset connector didn't light up after connecting a headset" and the QA in Beijing office also requires the led could change according to plugging or no plugging. > > Kai-Heng > >> I also prepared a patchset but my patchset has more code than yours, please take a look. :-) >> >> Thanks. >> >> Hui. >> >> On 2020/9/14 下午3:02, Kai-Heng Feng wrote: >>> On Lenovo P520, the front panel headset LED isn't lit up right now. >>> >>> Realtek states that the LED needs to be enabled by ALC233's GPIO2, so >>> let's do it accordingly to light the LED up. >>> >>> Signed-off-by: Kai-Heng Feng >>> --- >>> sound/pci/hda/patch_realtek.c | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c >>> index c521a1f17096..ba941bd0b792 100644 >>> --- a/sound/pci/hda/patch_realtek.c >>> +++ b/sound/pci/hda/patch_realtek.c >>> @@ -6017,6 +6017,7 @@ static void alc_fixup_thinkpad_acpi(struct hda_codec *codec, >>> #include "hp_x360_helper.c" >>> enum { >>> + ALC269_FIXUP_GPIO2, >>> ALC269_FIXUP_SONY_VAIO, >>> ALC275_FIXUP_SONY_VAIO_GPIO2, >>> ALC269_FIXUP_DELL_M101Z, >>> @@ -6194,6 +6195,10 @@ enum { >>> }; >>> static const struct hda_fixup alc269_fixups[] = { >>> + [ALC269_FIXUP_GPIO2] = { >>> + .type = HDA_FIXUP_FUNC, >>> + .v.func = alc_fixup_gpio2, >>> + }, >>> [ALC269_FIXUP_SONY_VAIO] = { >>> .type = HDA_FIXUP_PINCTLS, >>> .v.pins = (const struct hda_pintbl[]) { >>> @@ -7013,6 +7018,8 @@ static const struct hda_fixup alc269_fixups[] = { >>> [ALC233_FIXUP_LENOVO_MULTI_CODECS] = { >>> .type = HDA_FIXUP_FUNC, >>> .v.func = alc233_alc662_fixup_lenovo_dual_codecs, >>> + .chained = true, >>> + .chain_id = ALC269_FIXUP_GPIO2 >>> }, >>> [ALC233_FIXUP_ACER_HEADSET_MIC] = { >>> .type = HDA_FIXUP_VERBS,