From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F82B3750BC for ; Fri, 31 Jul 2026 21:40:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785534043; cv=none; b=g3xy3gYZYkB6n+Xuja2TKjVPT2vGkIalHAWSQ1RkW3al1+ZTP+fopS6yxBZpepZ+ObhCAQJhBmNjsrWPkWSFB2qgUR4XPk8xpH0M+3jV+nLTnskSIYO0la1iJwwJzmUrOp4cSZiMGZo1dJJ1/K9IalgUwm6qHlwdA7VJrmPLWcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785534043; c=relaxed/simple; bh=5AnADSN3lppxGtS870PlE0Wne3G+gQ1QIaz+dLYLPkg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JiK+alXSf+EWa9AqDHneiI+gzUboqLFGo/yNPlJvKqpF0FKLSiT0lGED7TvspK/nnBhD+CT0DKv99Big0AYX2boY3Q64CHbffiTvZj9E7ZOGmXh+5GIrEayvJ0qMF+E2nwCh7POvCEGLeOFiBKGWUHoSSi4biqQJJX1BAaf6vCY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=O2Hgka2/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SjYDUTuz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="O2Hgka2/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SjYDUTuz" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66VKMGqV696022 for ; Fri, 31 Jul 2026 21:40:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TfF+pTYN4bzorxHULetkdmAKLRCNK78Wfl5RM7zPhDE=; b=O2Hgka2/DcvXYP0n TSi7DyP8IpzrQUFXfM19bqtEuhyZml6nY85pJ962DyOL3SfwFSouVR1bNjxgq4dX FNi6K+hbjcN8mauUKjJxA+EImpnLYFKuQNQH4WYkc+GQK1vcGH7Pa2gHFxAy3dWK QIkv565zqAwxxJ4MAxsgwcrnsgg88I0s/1tymdDvKNseir/0kkPW7DmMXIIoeakn jrs/lf+26Nz2ng8gxk7o91enaEqBI46I9pajN52FgbxqN08wzQ3jmFskrzKFxObQ 1VPBUuEQxVytg7jQOauCpy7e6qUBRf1IH9FnnW+nq0OScd6iTUO2if25umoz4ijC zSDyeA== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4frugh2e45-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 21:40:40 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cbb467e56aaso1676112a12.1 for ; Fri, 31 Jul 2026 14:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785534040; x=1786138840; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TfF+pTYN4bzorxHULetkdmAKLRCNK78Wfl5RM7zPhDE=; b=SjYDUTuzUqJsb4B2+fsyfJvDgY4K8wjNp2qgKyPXOJXAxfOuRsdqqovse2AMkC+Lg9 51a+0/+TGSVmKD/Hpj+yAM/4G/RnZ9ZOBRnc+J81OOmUv/2ZmGJ+VE39dns42FTjEjOk x3FOaJ7QknNig3PZFE8HrbzOb9EqGu9O/zygKgjhvaCRUpGDMlnDLxCcK3l8x5/CdSLf Za5fpCd+kg4Xq77rH2a66mHjrIVFrGYA2mg4ZaymvJ09bhsc73cihWOFcQNKrfcvHgF+ wan4pCgvh4DxCuVp2hRwJ2ZGYIorQMzqiPMhhYCzzNzRjuCap5r0vZebxrA/7ftl+1Ga IQdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785534040; x=1786138840; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TfF+pTYN4bzorxHULetkdmAKLRCNK78Wfl5RM7zPhDE=; b=Z9ImP3AV0jJ1HDAHCajT4QYOO4WK6i/1uRJbS4YzYJ5k18b2R26EIDgDmU2ggZIwOZ 2SdgGC74PooIigU0/ezZz+VhoQqi/i4j0ShhtqgFNF+OWMopR4p7wg69C8TXySTE2tA7 zZuevu7qPltB2TNkOjsZdN95+ECBZYc78cqm5mrEZZRfmwQ/rPDFQyLqmPbYDHnFsXTN QsFpud3VwOcHlVtoEiWzK+8ihjr5OKrBrz7Rbrhc0S/TCOX21TH8rTJwmygXTL0e8thA jYJOsv7Xmc5q6tRrtDDa1Nvu7D1rBGDJVxkpkwiaRUf1FCxECxqqUC0vlT6IeWv5TFwg O9LA== X-Forwarded-Encrypted: i=1; AHgh+Rrc1DCAI/NU7+R8plu/hoiPMeyOgQtYK2L8J91QcMtQNtrU91ItLuU+OEYUXMadUVVT7dT3vfor0x0E8IY=@vger.kernel.org X-Gm-Message-State: AOJu0YwpwMOeGjeMtPhSmnUfmiV0v6Ygpr7o0BSnYKsqgRYsTQPd8CRm S4EqxktPtdyoFvstyZZIVI2YK2mPRm2S0JtZVTKkoKy2FU1r2dK8FPkO43pUSKWakHOlnvuE0g7 rKIrjmkHC0GJrVgMzJqcbno4WTqqSa88tFtnC4rrXwvEtwusIlZqdMngZFVgQy3F9hYw= X-Gm-Gg: AR+sD133qNSFAKRT1VMcveSpswgK01feCiFW9a5RJm+Xbg/LW/XNHAzRC2I9Or2ns7B dFLRU+DJMKRN3XZROayK8c1zAdXWoM+2LgLhmGlWrUXosj22Wls1wk2CerVjt7Sb3SC/kTL76P3 BFknOgEzfbpPjnXcF5yX9/AHW6zP+OlUQa5utgeR+SM71UbK9L7m1eypHd+oMeK2PpxU4RhwO+e dCUy3+dXl+Jf3ZShtXkccDbUiNjSnT3lz3PZAdE/kL6ZmcLjWi3P2svit6N8itWTmpnSxV0OXqr 93dcVqBwOZ7INiufmxG42aRdMIfXx7dPZ7Ar0Be62X3lLUiJdBjfjVQbfqzk66ba9+kTTwyLciC W45elL4rrTv0H7YM5X8GgtJMmyEHAD1w2BEAtowKQf4mqwrurih6PC012xpc= X-Received: by 2002:a05:6a21:7489:b0:3c3:7019:64ad with SMTP id adf61e73a8af0-3c92a8be664mr1143644637.66.1785534039851; Fri, 31 Jul 2026 14:40:39 -0700 (PDT) X-Received: by 2002:a05:6a21:7489:b0:3c3:7019:64ad with SMTP id adf61e73a8af0-3c92a8be664mr1143630637.66.1785534039429; Fri, 31 Jul 2026 14:40:39 -0700 (PDT) Received: from [192.168.1.9] (103.sub-97-215-187.myvzw.com. [97.215.187.103]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd4e47dsm13643035eec.3.2026.07.31.14.40.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 14:40:38 -0700 (PDT) Message-ID: <041f72ea-7dfc-4d50-ac0d-e0556f037a27@oss.qualcomm.com> Date: Fri, 31 Jul 2026 14:40:37 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath11k: Fix possible memory leak in ath11k_dp_srng_setup() To: Abdun Nihaal , jjohnson@kernel.org Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260727105532.118164-1-nihaal@cse.iitm.ac.in> Content-Language: en-US From: Jeff Johnson In-Reply-To: <20260727105532.118164-1-nihaal@cse.iitm.ac.in> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDE2NCBTYWx0ZWRfX0TtT+/WU/2hN zoEEL9L9xdyH9b88yopv1k3MmIT2aZFPu/kOOP0UypbBpQJ+Zaw27uNZdqpMcoXI/pADEntHgm0 FacsGuJ/6V2qF7l/zWRZ7/Zs+k/nA58UI9BOhxqUsYzTCCQRFxD2LJWWyrtnZ//vnRKLCVhcR1H 6raqOFUZPasrX4BrJ6N0hM/ufxScMpl26Jz/pmUWNvbHCtcOC9yeARrm6waX6ocyPOPUWFDBE9l +oiS4ocKZLPPD2TdT+uTcR25uvibfStcm2A1RV5pvti+6P5xC8r1Z7LojbyZu1HjkiCTcZRfSX+ zMcaDXZGBhCC3+n/puOPyeYI73bAA9L6/PMf0v/UsAMlhYtgtCDYoius5Q3nMP5XEQvTfKd1AZX qzYRD4/eap3qHYW2KtlvtxORarvlNTob1uq8mQ4ArhAMz0dR0NGxnY3vy0LkcfjRuBcf9b8DvOI ZGGcvS+IZz6weBAP40Q== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDE2NCBTYWx0ZWRfXzoQyzKA2d2cn gcNSl98ZixIY/2nb0+QWIiRoChxibwiXYWFvXV90ClGMU0rjp01l28tLi7kBfilG54rZYQQwTbw SlPccfdOB7abMI/NzCE5ddDVgQ35hzc= X-Authority-Analysis: v=2.4 cv=U+iiy+ru c=1 sm=1 tr=0 ts=6a6d1658 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=UaEkX0D7FlC0tWE/LoNF7Q==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=FZ0-UiQHMHqYDEnaofEA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-ORIG-GUID: AMkD8uNURXVluN00_SxDPpnT-iTuHget X-Proofpoint-GUID: AMkD8uNURXVluN00_SxDPpnT-iTuHget X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_06,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 suspectscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310164 On 7/27/2026 3:55 AM, Abdun Nihaal wrote: > In ath11k_dp_srng_setup(), the memory allocated for > ring->vaddr_unaligned is not freed when ath11k_hal_srng_setup() fails. > Fix that by calling ath11k_dp_srng_cleanup() in that error path. Did you find this on your own? Just want to make sure you are aware of: https://docs.kernel.org/process/coding-assistants.html FWIW my coding agent says this patch is correct but incomplete. There is a 2nd leak, at the switch (type) default: case which returns -EINVAL without cleanup. Care to incorporate a fix for that in a v2? For that part you can add Assisted-by: Claude:claude-sonnet-4-6 /jeff > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Cc: stable@vger.kernel.org > Signed-off-by: Abdun Nihaal > --- > Compile tested only. Issue found using static analysis. > > drivers/net/wireless/ath/ath11k/dp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/ath/ath11k/dp.c b/drivers/net/wireless/ath/ath11k/dp.c > index f389b97acbdd..c3a16da1cba7 100644 > --- a/drivers/net/wireless/ath/ath11k/dp.c > +++ b/drivers/net/wireless/ath/ath11k/dp.c > @@ -324,6 +324,7 @@ int ath11k_dp_srng_setup(struct ath11k_base *ab, struct dp_srng *ring, > > ret = ath11k_hal_srng_setup(ab, type, ring_num, mac_id, ¶ms); > if (ret < 0) { > + ath11k_dp_srng_cleanup(ab, ring); > ath11k_warn(ab, "failed to setup srng: %d ring_id %d\n", > ret, ring_num); > return ret;