From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DA7B1EF09B for ; Mon, 6 Apr 2026 21:14:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775510052; cv=none; b=GzDRNEq4M/M827X5P6wTSwGtM4+xjyF3VieU+djlTGN45CUnPIFK86ScXCB/fR75dBSXEUYJTpatcXcYB5ywt5vgFIJ7jAZ2pVCFc0hPbTsPoVhwM39uGqf3jAWw/embFO5DAUP5cdUEBLhcWM1wjes6vx6UUkwms1jBo1HdeXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775510052; c=relaxed/simple; bh=TJWAiyLjINtrwAQV18kL9fzsN6tGI2KUXAVbKurrjB4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lGB2TVix49qWg2WSjPk1pqS2m4/g3r+hhdnfYXNJFO9RiWI4lXY15ILp26ifJY7FRD8yAbL1IHMhYUCY0rE/6i5A95WcCV/SIUItUCPGscpAz7vtwat4zMF0nTdnQZ9D5xMcwckqIn8E1u3hp2HDDro/XcmwWi3GtpGMunQCvWo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZNDKnYgD; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=niD+Doqc; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZNDKnYgD"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="niD+Doqc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775510050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u6eiLy0THPzh19v4xRPOdwo1i97CoxO5wof7uqqfnf4=; b=ZNDKnYgDs2e5yEH197Ag6agsTZQUbubRIBVQjxnk7aNALXsac9+8hlDGIEAmHmfIiz3onB QpJ5MShIVmzXcVOj2ihAfArhv02CEurKHEzsM9Wkv6nvb5wRp31/+YB9G+7VjCMr2Emnee zcGAefXuRMvd2sjYFy4H86taW451qoU= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-300-5QE5maG7PEq0MTT5KSKfHA-1; Mon, 06 Apr 2026 17:14:09 -0400 X-MC-Unique: 5QE5maG7PEq0MTT5KSKfHA-1 X-Mimecast-MFC-AGG-ID: 5QE5maG7PEq0MTT5KSKfHA_1775510049 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-89cc1d6dbe4so203186036d6.3 for ; Mon, 06 Apr 2026 14:14:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775510049; x=1776114849; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=u6eiLy0THPzh19v4xRPOdwo1i97CoxO5wof7uqqfnf4=; b=niD+DoqcqIW0HCHQ8Bwkc3JYf2Cd2qdgDnKSw2+5qKUOXX6niwHnTCzosU3VMKHhda DzVqNmUApQFA8ceQRUi312sIqWYqR9SSSM9sTIhU4iuOPvsMQmyDSkuk2hWyQYeXjeLt aDXp6mjKBPcLAKf6OLpZIwGZUurTe5GUTMJFh4yI08M0TmpqACEavRVLYyyfJR0O8s2D bo3nFdkSnIyYs+gg4OPrP2rJ7J8ljONKcdfYYNiYr5ZYiIUSfmbA3hmAz6x1vRFsgYu4 JbrnSCAtvYz6eaKnK6jg2Jfj/1itD2j761hsGxTWh+82jwlrYGOYVs39jeJrudQlHRFK FeKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775510049; x=1776114849; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u6eiLy0THPzh19v4xRPOdwo1i97CoxO5wof7uqqfnf4=; b=QaX1ser0zh9B4fAhMchYTWD2C5ji7053+Cy08zgrLhgf3hParEB2qRmF2vjP6Pnzgm DLzfjuWDIQSkrnewnSgd+JJ+o4ofvzbuQQmFcIFINOsWX5GWWse5NOpHGIkgz/EpoXoN QopxqWQCXFRKFWPYdh7EPsjQ5frk9l2vqEK48P3Eib8yeYj7RKsilfpk5MbpP5IU+XsW pbM5iT8otdKpiGdy4gqRzq+xRI+xOctivOavg9iQUuMIOm5UoNH4bhUJlQ0HraqymxrM nxIBvUUeVVHcZXRwLqGYUQcf8nXyb4HgYs/Lz+xERoxu5fBYpfP/535/45HaDK7tOFig MyNA== X-Forwarded-Encrypted: i=1; AJvYcCVT/W2u8Ogxvm2eIFckh7EVb/WIrd1BklgxWzle0wKO0cqIOkWJ+fKX2vhN+Ui9JsEGTF4tgbCwLSrhTC4=@vger.kernel.org X-Gm-Message-State: AOJu0YzU3y6aqnFed4/6pAos9xcrG6iN/EN5TtoKF4VEnDheS/ob7Nme 4fXSWzIc/Ce2JrvZFG+A6VGWDksnmleIj4VQWSApkIdWe3wDKRm0RlzWi86kF3PFFj0I+wCNwXq +RwZ/xNkIX38cXI65qKj45BieH/aFsxh9HoFvCXaWY6XJZQsqTKJ8gTzUPBCnpLUBzw== X-Gm-Gg: AeBDiesrDMLKkQU7dpTYeBwRoY4u1Ihma9smdzjtbgzO15ZlLnOztapnhSHAYVKTse8 XQX5uRWsQFkz9VOzHeZWCxSfFkyXdOUTqvX4I1Lb+1Xqhzc7wbxCvj2m7gLnYQdbdzy+6rZNRCv pzpi5EqN1dbyAhGSqKEU9UcvSCg5lLjQs7mhYd/txOOfh7HzyX7Za3bw6YNA+UGPd54kyVUDOM2 Ees/+Y15DdmkuYzo7rGE8BSQPhZ62jjMVo2LZzUhRwmXFkMqp+Sp37k4m/pmvIt76wKmgtsX6Cv mmYnwQuKNNRfrqIaL3Y7RcmaAb2u8KHJJlY2ZCEl5Tki7YF+ae49rg7zHUlt9zrrknVY1LytWsC gZu8nzduLL6MJ9D/EnEV7QVNoZVd1zqLN7qq1i38a/OyiXggPffxXTcV69JgSjFtAHZkj5w== X-Received: by 2002:ad4:5dcf:0:b0:89c:6b92:1c1a with SMTP id 6a1803df08f44-8a705687d2bmr239681546d6.51.1775510048739; Mon, 06 Apr 2026 14:14:08 -0700 (PDT) X-Received: by 2002:ad4:5dcf:0:b0:89c:6b92:1c1a with SMTP id 6a1803df08f44-8a705687d2bmr239680936d6.51.1775510048210; Mon, 06 Apr 2026 14:14:08 -0700 (PDT) Received: from ?IPV6:2600:4040:530f:2500:540d:8da2:f197:6711? ([2600:4040:530f:2500:540d:8da2:f197:6711]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8a596e03dc6sm152715996d6.34.2026.04.06.14.14.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Apr 2026 14:14:07 -0700 (PDT) Message-ID: <0420fb5b-67ff-4322-a121-d0444b0aedd0@redhat.com> Date: Mon, 6 Apr 2026 17:14:06 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] dm vdo: use get_random_u32() where appropriate Content-Language: en-US To: David Carlier Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260405154713.4660-1-devnexen@gmail.com> From: Matthew Sakai In-Reply-To: <20260405154713.4660-1-devnexen@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/5/26 11:47 AM, David Carlier wrote: > Use the typed random integer helpers instead of > get_random_bytes() when filling a single integer variable. > The helpers return the value directly, require no pointer > or size argument, and better express intent. > > Signed-off-by: David Carlier Reviewed-by: Matthew Sakai > --- > drivers/md/dm-vdo/indexer/index-layout.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/dm-vdo/indexer/index-layout.c b/drivers/md/dm-vdo/indexer/index-layout.c > index 61edf2b72427..8707930c9910 100644 > --- a/drivers/md/dm-vdo/indexer/index-layout.c > +++ b/drivers/md/dm-vdo/indexer/index-layout.c > @@ -256,7 +256,7 @@ static void create_unique_nonce_data(u8 *buffer) > u32 rand; > size_t offset = 0; > > - get_random_bytes(&rand, sizeof(u32)); > + rand = get_random_u32(); > memcpy(buffer + offset, &now, sizeof(now)); > offset += sizeof(now); > memcpy(buffer + offset, &rand, sizeof(rand));