From: Tadeusz Struk <tadeusz.struk@linaro.org>
To: Christoph Hellwig <hch@infradead.org>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: general protection fault in del_gendisk
Date: Mon, 8 Nov 2021 11:19:35 -0800 [thread overview]
Message-ID: <0423c908-00c9-e22b-38cc-bae899f18834@linaro.org> (raw)
In-Reply-To: <YYDehlqjWUKizzmB@infradead.org>
On 11/1/21 23:45, Christoph Hellwig wrote:
>> People will take a look at it, but you sent it out on a Saturday right
>> before a merge window, doing a 'ping' kind of followup on a Monday is
>> way too soon.
> Please retests on 5.16-rc1 once it is out. Sorting out add_disk error
> handling is one of the big changes in this merge window. And no, it is
> not easily backportable.
I have ran this on the latest mainline. I can confirm that the errors are
nicely handled there. It triggers a warning and panics in device_add_disk()
because of:
return WARN_ON_ONCE(ret); /* keep until all callers handle errors */
and
Kernel panic - not syncing: panic_on_warn set ...
I will close the issue.
--
Thanks,
Tadeusz
next prev parent reply other threads:[~2021-11-08 19:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7468db5d-55b4-07c9-628a-9a60419d9121@linaro.org>
2021-11-01 20:01 ` Tadeusz Struk
2021-11-01 20:03 ` Jens Axboe
2021-11-02 6:45 ` Christoph Hellwig
2021-11-08 19:19 ` Tadeusz Struk [this message]
2021-11-12 6:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0423c908-00c9-e22b-38cc-bae899f18834@linaro.org \
--to=tadeusz.struk@linaro.org \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®