From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3D00C4332F for ; Wed, 9 Mar 2022 06:32:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230072AbiCIGc7 (ORCPT ); Wed, 9 Mar 2022 01:32:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229542AbiCIGc4 (ORCPT ); Wed, 9 Mar 2022 01:32:56 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FF551617DB; Tue, 8 Mar 2022 22:31:58 -0800 (PST) Received: from kwepemi100020.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4KD2P539QGzBrhQ; Wed, 9 Mar 2022 14:30:01 +0800 (CST) Received: from kwepemm600017.china.huawei.com (7.193.23.234) by kwepemi100020.china.huawei.com (7.221.188.48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Wed, 9 Mar 2022 14:31:56 +0800 Received: from [10.174.179.19] (10.174.179.19) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 9 Mar 2022 14:31:55 +0800 Message-ID: <0423ef8e-bfd0-3a4b-78a5-17dc621660d2@huawei.com> Date: Wed, 9 Mar 2022 14:31:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH 2/3] kunit: make kunit_test_timeout compatible with comment Content-Language: en-US To: Marco Elver CC: , , , , , , , , , References: <20220309014705.1265861-1-liupeng256@huawei.com> <20220309014705.1265861-3-liupeng256@huawei.com> From: "liupeng (DM)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.19] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600017.china.huawei.com (7.193.23.234) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thank you for your advice. On 2022/3/9 14:03, Marco Elver wrote: > On Wed, 9 Mar 2022 at 02:29, 'Peng Liu' via kasan-dev > wrote: >> In function kunit_test_timeout, it is declared "300 * MSEC_PER_SEC" >> represent 5min. However, it is wrong when dealing with arm64 whose >> default HZ = 250, or some other situations. Use msecs_to_jiffies to >> fix this, and kunit_test_timeout will work as desired. >> >> Signed-off-by: Peng Liu > Does this need a: > > Fixes: 5f3e06208920 ("kunit: test: add support for test abort") > > ? Yes, I will add this description. >> --- >> lib/kunit/try-catch.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/kunit/try-catch.c b/lib/kunit/try-catch.c >> index 6b3d4db94077..f7825991d576 100644 >> --- a/lib/kunit/try-catch.c >> +++ b/lib/kunit/try-catch.c >> @@ -52,7 +52,7 @@ static unsigned long kunit_test_timeout(void) >> * If tests timeout due to exceeding sysctl_hung_task_timeout_secs, >> * the task will be killed and an oops generated. >> */ >> - return 300 * MSEC_PER_SEC; /* 5 min */ >> + return 300 * msecs_to_jiffies(MSEC_PER_SEC); /* 5 min */ > Why not just "300 * HZ" ? Because I have seen patch df3c30f6e904 ("staging: lustre: replace direct HZ access with kernel APIs"). Here, both "msecs_to_jiffies(MSEC_PER_SEC)" and "300 * HZ" is ok for me. >> } >> >> void kunit_try_catch_run(struct kunit_try_catch *try_catch, void *context) >> -- >> 2.18.0.huawei.25 >> >> -- >> You received this message because you are subscribed to the Google Groups "kasan-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. >> To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20220309014705.1265861-3-liupeng256%40huawei.com. > .