From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751756AbbCYE1e (ORCPT ); Wed, 25 Mar 2015 00:27:34 -0400 Received: from mail113-250.mail.alibaba.com ([205.204.113.250]:39003 "EHLO us-alimail-mta1.hst.scl.en.alidc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750698AbbCYE1c (ORCPT ); Wed, 25 Mar 2015 00:27:32 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R801e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=r46d02011;MF=hillf.zj@alibaba-inc.com;PH=DS;RN=5;RT=5;SR=0; Reply-To: "Hillf Danton" From: "Hillf Danton" To: "'Laura Abbott'" Cc: "'Russell King'" , "linux-kernel" , , "Hillf Danton" Subject: [patch] ARM: fix module-bound check in setting page attributes Date: Wed, 25 Mar 2015 12:20:33 +0800 Message-ID: <042801d066b3$0ca78a30$25f69e90$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AdBmsoRYXxqSlb6iSKGOWco+Ql/mZA== Content-Language: zh-cn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It was introduced in commit f2ca09f381a59 (ARM: 8311/1: Don't use is_module_addr in setting page attributes) We have no need to check start twice, but see if end is also in range. Signed-off-by: Hillf Danton --- --- a/arch/arm/mm/pageattr.c Wed Mar 25 11:55:13 2015 +++ b/arch/arm/mm/pageattr.c Wed Mar 25 11:57:31 2015 @@ -52,7 +52,7 @@ static int change_memory_common(unsigned if (start < MODULES_VADDR || start >= MODULES_END) return -EINVAL; - if (end < MODULES_VADDR || start >= MODULES_END) + if (end < MODULES_VADDR || end >= MODULES_END) return -EINVAL; data.set_mask = set_mask; --