From: Tvrtko Ursulin <tursulin@ursulin.net>
To: "Philipp Stanner" <phasta@kernel.org>,
"Matthew Brost" <matthew.brost@intel.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Christian König" <ckoenig.leichtzumerken@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/sched: Fix outdated sched_job docu
Date: Wed, 12 Nov 2025 09:26:42 +0000 [thread overview]
Message-ID: <04291a87-24c9-433b-9bb6-7e70ea19459f@ursulin.net> (raw)
In-Reply-To: <20251111161502.86180-2-phasta@kernel.org>
On 11/11/2025 16:15, Philipp Stanner wrote:
> There is no such thing as a "done_list" anymore. Remove mention of it.
>
> Signed-off-by: Philipp Stanner <phasta@kernel.org>
> ---
> include/drm/gpu_scheduler.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
> index fb88301b3c45..18d6210ce2d0 100644
> --- a/include/drm/gpu_scheduler.h
> +++ b/include/drm/gpu_scheduler.h
> @@ -320,7 +320,7 @@ struct drm_sched_fence *to_drm_sched_fence(struct dma_fence *f);
> * struct drm_sched_job - A job to be run by an entity.
> *
> * @queue_node: used to append this struct to the queue of jobs in an entity.
> - * @list: a job participates in a "pending" and "done" lists.
> + * @list: for enqueueing the job into the list of pending jobs.
> * @sched: the scheduler instance on which this job is scheduled.
> * @s_fence: contains the fences for the scheduling of job.
> * @finish_cb: the callback for the finished fence.
Interesting that I cannot see there was a done list at the time when
that comment was added. Anyway, I did not dig much further back since
for the current state the correction is obviously correct.
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Regards,
Tvrtko
prev parent reply other threads:[~2025-11-12 9:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 16:15 Philipp Stanner
2025-11-12 9:26 ` Tvrtko Ursulin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04291a87-24c9-433b-9bb6-7e70ea19459f@ursulin.net \
--to=tursulin@ursulin.net \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.brost@intel.com \
--cc=phasta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®