From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1949C433E0 for ; Tue, 2 Feb 2021 01:33:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8052E64EC6 for ; Tue, 2 Feb 2021 01:33:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230368AbhBBBdM (ORCPT ); Mon, 1 Feb 2021 20:33:12 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:12377 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbhBBBdK (ORCPT ); Mon, 1 Feb 2021 20:33:10 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4DV6hq2rTPz7dxr; Tue, 2 Feb 2021 09:31:07 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by smtp.huawei.com (10.3.19.205) with Microsoft SMTP Server (TLS) id 14.3.498.0; Tue, 2 Feb 2021 09:32:23 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: fix checkpoint mount option wrong combination To: Daeho Jeong , Jaegeuk Kim CC: , Daeho Jeong , , References: <20210201000606.2206740-1-daeho43@gmail.com> <7e2f440e-6500-04c8-1115-880754a18efa@kernel.org> From: Chao Yu Message-ID: <042aae34-7e52-bdcc-1154-4ea1ecace39b@huawei.com> Date: Tue, 2 Feb 2021 09:32:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.136.110.154] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/2/2 8:41, Daeho Jeong wrote: > For less confusion, I am going to separate the "merge" option from Agreed. > "checkpoint=". > I am adding another "ckpt_merge" option. :) Not sure, maybe "checkpoint_merge" will be better? "ckpt_merge" looks more like a term only developer knew. Thanks, > > 2021년 2월 2일 (화) 오전 8:33, Daeho Jeong 님이 작성: >> >> The rightmost one is the final option. And checkpoint=merge means >> checkpoint is enabled with a checkpoint thread. >> >> mount checkpoint=disable,checkpoint=merge => checkpoint=merge >> remount checkpoint=enable,checkpoint=merge => checkpoint=merge >> remount checkpoint=merge,checkpoint=disable => checkpoint=disable >> remount checkpoint=merge,checkpoint=enable => checkpoint=enable >> >> Like >> >> mount fsync_mode=posix, fsync_mode=strict, fsync_mode=nobarrier => >> fsync_mode=nobarrier >> >> 2021년 2월 2일 (화) 오전 5:11, Jaegeuk Kim 님이 작성: >>> >>> On 02/01, Daeho Jeong wrote: >>>> Actually, I think we need to select one among them, disable, enable >>>> and merge. I realized my previous understanding about that was wrong. >>>> In that case of "checkpoint=merge,checkpoint=enable", the last option >>>> will override the ones before that. >>>> This is how the other mount options like fsync_mode, whint_mode and etc. >>>> So, the answer will be "checkpoint=enable". What do you think? >>> >>> We need to clarify a bit more. :) >>> >>> mount checkpoint=disable,checkpoint=merge >>> remount checkpoint=enable,checkpoint=merge >>> >>> Then, is it going to enable checkpoint with a thread? >>> >>>> >>>> >>>> >>>> 2021년 2월 1일 (월) 오후 9:40, Chao Yu 님이 작성: >>>>> >>>>> On 2021/2/1 8:06, Daeho Jeong wrote: >>>>>> From: Daeho Jeong >>>>>> >>>>>> As checkpoint=merge comes in, mount option setting related to >>>>>> checkpoint had been mixed up. Fixed it. >>>>>> >>>>>> Signed-off-by: Daeho Jeong >>>>>> --- >>>>>> fs/f2fs/super.c | 11 +++++------ >>>>>> 1 file changed, 5 insertions(+), 6 deletions(-) >>>>>> >>>>>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >>>>>> index 56696f6cfa86..8231c888c772 100644 >>>>>> --- a/fs/f2fs/super.c >>>>>> +++ b/fs/f2fs/super.c >>>>>> @@ -930,20 +930,25 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount) >>>>>> return -EINVAL; >>>>>> F2FS_OPTION(sbi).unusable_cap_perc = arg; >>>>>> set_opt(sbi, DISABLE_CHECKPOINT); >>>>>> + clear_opt(sbi, MERGE_CHECKPOINT); >>>>>> break; >>>>>> case Opt_checkpoint_disable_cap: >>>>>> if (args->from && match_int(args, &arg)) >>>>>> return -EINVAL; >>>>>> F2FS_OPTION(sbi).unusable_cap = arg; >>>>>> set_opt(sbi, DISABLE_CHECKPOINT); >>>>>> + clear_opt(sbi, MERGE_CHECKPOINT); >>>>>> break; >>>>>> case Opt_checkpoint_disable: >>>>>> set_opt(sbi, DISABLE_CHECKPOINT); >>>>>> + clear_opt(sbi, MERGE_CHECKPOINT); >>>>>> break; >>>>>> case Opt_checkpoint_enable: >>>>>> clear_opt(sbi, DISABLE_CHECKPOINT); >>>>>> + clear_opt(sbi, MERGE_CHECKPOINT); >>>>> >>>>> What if: -o checkpoint=merge,checkpoint=enable >>>>> >>>>> Can you please explain the rule of merge/disable/enable combination and their >>>>> result? e.g. >>>>> checkpoint=merge,checkpoint=enable >>>>> checkpoint=enable,checkpoint=merge >>>>> checkpoint=merge,checkpoint=disable >>>>> checkpoint=disable,checkpoint=merge >>>>> >>>>> If the rule/result is clear, it should be documented. >>>>> >>>>> Thanks, >>>>> >>>>> >>>>>> break; >>>>>> case Opt_checkpoint_merge: >>>>>> + clear_opt(sbi, DISABLE_CHECKPOINT); >>>>>> set_opt(sbi, MERGE_CHECKPOINT); >>>>>> break; >>>>>> #ifdef CONFIG_F2FS_FS_COMPRESSION >>>>>> @@ -1142,12 +1147,6 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount) >>>>>> return -EINVAL; >>>>>> } >>>>>> >>>>>> - if (test_opt(sbi, DISABLE_CHECKPOINT) && >>>>>> - test_opt(sbi, MERGE_CHECKPOINT)) { >>>>>> - f2fs_err(sbi, "checkpoint=merge cannot be used with checkpoint=disable\n"); >>>>>> - return -EINVAL; >>>>>> - } >>>>>> - >>>>>> /* Not pass down write hints if the number of active logs is lesser >>>>>> * than NR_CURSEG_PERSIST_TYPE. >>>>>> */ >>>>>> >>>> >>>> >>>> _______________________________________________ >>>> Linux-f2fs-devel mailing list >>>> Linux-f2fs-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel >