From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D725FC7EE29 for ; Mon, 29 May 2023 06:45:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231730AbjE2Gp2 (ORCPT ); Mon, 29 May 2023 02:45:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231745AbjE2GpE (ORCPT ); Mon, 29 May 2023 02:45:04 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1164F90; Sun, 28 May 2023 23:45:03 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id A62D380C4; Mon, 29 May 2023 14:45:01 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 29 May 2023 14:45:01 +0800 Received: from [192.168.120.57] (171.223.208.138) by EXMBX168.cuchost.com (172.16.6.78) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 29 May 2023 14:45:01 +0800 Message-ID: <042c560d-1f36-8e97-3796-7423245592f4@starfivetech.com> Date: Mon, 29 May 2023 14:44:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v1 2/3] spi: cadence-quadspi: Add clock configuration for StarFive JH7110 QSPI Content-Language: en-US To: Mark Brown CC: , , , , "Rob Herring" , Krzysztof Kozlowski , Conor Dooley , "Emil Renner Berthing" , Ziv Xu References: <20230526062529.46747-1-william.qiu@starfivetech.com> <20230526062529.46747-3-william.qiu@starfivetech.com> From: William Qiu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX168.cuchost.com (172.16.6.78) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/5/26 23:36, Mark Brown wrote: > On Fri, May 26, 2023 at 02:25:28PM +0800, William Qiu wrote: > >> if (of_device_is_compatible(pdev->dev.of_node, "starfive,jh7110-qspi")) { >> + qspi_ahb = devm_clk_get(dev, "qspi-ahb"); >> + if (IS_ERR(qspi_ahb)) { >> + dev_err(dev, "Cannot claim QSPI_AHB clock.\n"); >> + ret = PTR_ERR(qspi_ahb); >> + return ret; >> + } >> + >> + ret = clk_prepare_enable(qspi_ahb); >> + if (ret) { >> + dev_err(dev, "Cannot enable QSPI AHB clock.\n"); >> + goto probe_clk_failed; >> + } > > Nothing ever disables or unprepares this clock as far as I can tell? > Perhaps also consider using the clk_bulk_ APIs. I will add in next version. Thanks for taking time to review this patch series and give useful suggestions. Best regards, William