From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99137218AD9 for ; Fri, 20 Dec 2024 15:03:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734707035; cv=none; b=B9o5yLf07pT6ZEmPTR2w9gxZju8s4mcM+Lx/Qhbo7ARCcPxTuiXsaxOEIkSG5FPOCtxT+YjR7HXC9OnF4+CBC2pGT7ytshYr8D2NefxwrrdT91J0NQ6OLWVIeG8QC2jLbWfFy0kVWWXq7mu2Nnomom1SdNf7DvHl4+b/c1U+dyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734707035; c=relaxed/simple; bh=e+m7fBHPpMDdNahwnBtswauC8Bzq0gPI01dZRSoqa3w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=D6NPSR3wnQaXfmsqNqElc3ZE3AxEpwLPeoawBSdwkMKo0kUL8vchAZR+YrK6Jq+QtPHczDdc+Uj+ALaXTIHXwjsnT+GwBnRW1L9rgBsjDJm507nhacZ5k3a4foqLwK38+Kidde8HTgaNqsio7bgjLGl/FOPLkIgm3iwf3GnVskU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AirEV2NS; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AirEV2NS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734707032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OWAB0kDBETvYpu2MrV6mU0PsK+ELU4H4C8gE6dHo/1A=; b=AirEV2NSB8PWyfY7sK3vE/u74sweqAyb1Mz3zqqRvs2uVYp23R0LcxMfzbpUaurZJiIOoo Lg4655d6wF7tl3cK5A+ffvrUEOWsK6qZLrIskpf5lFl7Fbdiq/KQ32XKndhEduuPo+gJg1 cDZ/Bh8U5OcI1TKsmNCYJuq+dP5Gd8I= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-277-bG9Mi7MfPhuwltVJiPXF_A-1; Fri, 20 Dec 2024 10:03:50 -0500 X-MC-Unique: bG9Mi7MfPhuwltVJiPXF_A-1 X-Mimecast-MFC-AGG-ID: bG9Mi7MfPhuwltVJiPXF_A Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4361a8fc3bdso11474175e9.2 for ; Fri, 20 Dec 2024 07:03:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734707027; x=1735311827; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=OWAB0kDBETvYpu2MrV6mU0PsK+ELU4H4C8gE6dHo/1A=; b=VcFb9wyFLT3l4V4t+rIoI5MuMqLGh4Mt6CMjjEYYiv7ThCnVTy1MLDJlleX94FpD5U aEAESuAWXcUMWHr5enPLaF46rGi/6QoIqCXI5t9lay282Ha0OJavikPFVtrB2n52QzzA rX5Zcm0j0t2KNDzSoLlWtVwK8Q77BxUNa3ZRhra31dC0aqiM4oCtWWJzSAl+2V5c8lYm is9veP50hCwtDWg5J1nWvcO5V8ie81PREkQny7d6VK+rhKrTUTbstrBqW+Tt4KvmvP+x ASa9TA06pYCu6Mt38vpWXpN/YV+iZF/J2uJ7CmqaFWTAzvBeZFjbU4PegzXmKNFd835U JxZQ== X-Forwarded-Encrypted: i=1; AJvYcCVhl66hCyqSRR5aLEJu7pjssbcfySqYXJChRA+Y8j2PXnchIoxLPWXbvcEF2AqEL/Gb6hndZ4teNTrBUfw=@vger.kernel.org X-Gm-Message-State: AOJu0YwwMS2A3M1dqzSjnaqYiAxh/ULp9VNiey+JcLWIwnIhNBLwm1yI 6mtbHtHNJQEve9PxZOkzwBbNEcN6Njtlu+hMMT96LXbPH+OVtzART2yrEKYYq7GX3TOhdxutSAn //0wjMy6Uum4tdlfThco+sSVQrFnD5nqJGO08B/GATXRDP38pwtOSMFeeAtD75w== X-Gm-Gg: ASbGncsDMGHsXpUMMcgdb8dJE48SVfvQ+S0C1DKxZqrqI6AfJU93FmQqYrO81EUzUSB w2ovmbK3KRkWfRPevYXxAigO8j5rAH2vwURUVlmCWrZphKxoBDfGxgmtuBzT6r43GlYbYRfcoYX NeG+4uCEY4XAqPihJKRbkCRQHV5F9SqITzEnS7iBircZ8m+LtUWLTuqAkrYJ3Lw1Vk9HM3K8k70 0n+GNgXEG1vyscmNANkpqPSppovtxQ3eFhTKpVdzzRHO/VjaEupGveDc6xUfhCQ9hd5XWDdEPYw jg3cvZP231M8rrBln44BdY8D7tJ+rzOtYLV6YYCPosRtHLSgHvL+SuRULlcflZBaw2g4WsOHCSM FzKUdn0uC X-Received: by 2002:a05:6000:4012:b0:385:f892:c8fe with SMTP id ffacd0b85a97d-38a221fa22cmr3417270f8f.21.1734707026705; Fri, 20 Dec 2024 07:03:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnarzRDpKkohEao/pdyX0GNLj+85BhrAGPwqQr4aAIG/ckAEOg73IGCK6l092v0cKpqvqSWg== X-Received: by 2002:a05:6000:4012:b0:385:f892:c8fe with SMTP id ffacd0b85a97d-38a221fa22cmr3417166f8f.21.1734707025953; Fri, 20 Dec 2024 07:03:45 -0800 (PST) Received: from ?IPV6:2003:cb:c708:9d00:edd9:835b:4bfb:2ce3? (p200300cbc7089d00edd9835b4bfb2ce3.dip0.t-ipconnect.de. [2003:cb:c708:9d00:edd9:835b:4bfb:2ce3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c828ba0sm4188959f8f.14.2024.12.20.07.03.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 07:03:45 -0800 (PST) Message-ID: <042d3631-e3ab-437a-b628-4004ca3ddb45@redhat.com> Date: Fri, 20 Dec 2024 16:03:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/11] mm: add PG_dropbehind folio flag To: "Kirill A. Shutemov" , Jens Axboe Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, bfoster@redhat.com, Vlastimil Babka References: <20241213155557.105419-1-axboe@kernel.dk> <20241213155557.105419-5-axboe@kernel.dk> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20.12.24 12:08, Kirill A. Shutemov wrote: > On Fri, Dec 13, 2024 at 08:55:18AM -0700, Jens Axboe wrote: >> Add a folio flag that file IO can use to indicate that the cached IO >> being done should be dropped from the page cache upon completion. >> >> Signed-off-by: Jens Axboe > > Reviewed-by: Kirill A. Shutemov > > + David, Vlastimil. > > I think we should consider converting existing folio_set_reclaim() / > SetPageReclaim() users to the new flag. From a quick scan, all of them > would benefit from dropping the page after writeback is complete instead > of leaving the folio on the LRU. I wonder of there are some use cases where we write a lot of data to then only consume it read-only from that point on (databases? fancy AI stuff? no idea :) ). -- Cheers, David / dhildenb