From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5752FC2D0E2 for ; Thu, 24 Sep 2020 07:26:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05A4423600 for ; Thu, 24 Sep 2020 07:26:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GZi0Yoqk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727169AbgIXH0b (ORCPT ); Thu, 24 Sep 2020 03:26:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36207 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727136AbgIXH0b (ORCPT ); Thu, 24 Sep 2020 03:26:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600932390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K3pWzi6XBSxvJ/VWL3fyEt5ORCYjFGoEK4Nlb2X8zSM=; b=GZi0YoqkHbu1RzAz6dgg9A6MQh8h+JRiFyK1FRawGz8AExYq5o5pwYJ/bcI1RMNuLdMZjF T/oAX8wdWDLcM0lPSHs0w8f/itbpPQUZKChl8pfZDGqX/d3+gCBkBJmE3Y/QCMK5LgimQw IdrXpY4Mjl+VOelMdEy7RBYEsVLCNu4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-57-KhdlLsU5M-qlpT4HD7pE3w-1; Thu, 24 Sep 2020 03:26:26 -0400 X-MC-Unique: KhdlLsU5M-qlpT4HD7pE3w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DC2AD186DD33; Thu, 24 Sep 2020 07:26:24 +0000 (UTC) Received: from [10.72.13.193] (ovpn-13-193.pek2.redhat.com [10.72.13.193]) by smtp.corp.redhat.com (Postfix) with ESMTP id CD64A60C15; Thu, 24 Sep 2020 07:26:10 +0000 (UTC) Subject: Re: [RFC PATCH 01/24] vhost-vdpa: fix backend feature ioctls To: Eli Cohen Cc: mst@redhat.com, lulu@redhat.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, rob.miller@broadcom.com, lingshan.zhu@intel.com, eperezma@redhat.com, hanand@xilinx.com, mhabets@solarflare.com, eli@mellanox.com, amorenoz@redhat.com, maxime.coquelin@redhat.com, stefanha@redhat.com, sgarzare@redhat.com References: <20200924032125.18619-1-jasowang@redhat.com> <20200924032125.18619-2-jasowang@redhat.com> <20200924071609.GA170403@mtl-vdi-166.wap.labs.mlnx> From: Jason Wang Message-ID: <042dc3f9-40f0-f740-7ffc-611d315bc150@redhat.com> Date: Thu, 24 Sep 2020 15:26:08 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200924071609.GA170403@mtl-vdi-166.wap.labs.mlnx> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/9/24 下午3:16, Eli Cohen wrote: > On Thu, Sep 24, 2020 at 11:21:02AM +0800, Jason Wang wrote: >> Commit 653055b9acd4 ("vhost-vdpa: support get/set backend features") >> introduces two malfunction backend features ioctls: >> >> 1) the ioctls was blindly added to vring ioctl instead of vdpa device >> ioctl >> 2) vhost_set_backend_features() was called when dev mutex has already >> been held which will lead a deadlock >> > I assume this patch requires some patch in qemu as well. Do you have > such patch? > It's this series: [PATCH 0/3] Vhost-vDPA: batch IOTLB updating. You were copied. Thanks