From: Jia Zhu <zhujia.zj@bytedance.com>
To: Jingbo Xu <jefflexu@linux.alibaba.com>,
xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Phishing Risk] [External] [PATCH v2 2/2] erofs: enable large folios for fscache mode
Date: Mon, 28 Nov 2022 21:56:10 +0800 [thread overview]
Message-ID: <042ebc25-f9ab-b407-033b-86d6fe5fda98@bytedance.com> (raw)
In-Reply-To: <20221128025011.36352-3-jefflexu@linux.alibaba.com>
在 2022/11/28 10:50, Jingbo Xu 写道:
> Enable large folios for fscache mode. Enable this feature for
> non-compressed format for now, until the compression part supports large
> folios later.
>
> One thing worth noting is that, the feature is not enabled for the meta
> data routine since meta inodes don't need large folios for now, nor do
> they support readahead yet.
>
> Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
Reviewed-by: Jia Zhu <zhujia.zj@bytedance.com>
Thanks.
> ---
> fs/erofs/inode.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/erofs/inode.c b/fs/erofs/inode.c
> index e457b8a59ee7..85932086d23f 100644
> --- a/fs/erofs/inode.c
> +++ b/fs/erofs/inode.c
> @@ -295,8 +295,7 @@ static int erofs_fill_inode(struct inode *inode)
> goto out_unlock;
> }
> inode->i_mapping->a_ops = &erofs_raw_access_aops;
> - if (!erofs_is_fscache_mode(inode->i_sb))
> - mapping_set_large_folios(inode->i_mapping);
> + mapping_set_large_folios(inode->i_mapping);
> #ifdef CONFIG_EROFS_FS_ONDEMAND
> if (erofs_is_fscache_mode(inode->i_sb))
> inode->i_mapping->a_ops = &erofs_fscache_access_aops;
prev parent reply other threads:[~2022-11-28 13:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 2:50 [PATCH v2 0/2] erofs: support " Jingbo Xu
2022-11-28 2:50 ` [PATCH v2 1/2] " Jingbo Xu
2022-11-28 13:54 ` [Phishing Risk] [External] " Jia Zhu
2022-11-28 2:50 ` [PATCH v2 2/2] erofs: enable " Jingbo Xu
2022-11-28 13:56 ` Jia Zhu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=042ebc25-f9ab-b407-033b-86d6fe5fda98@bytedance.com \
--to=zhujia.zj@bytedance.com \
--cc=chao@kernel.org \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®