From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CA50372B3B for ; Thu, 26 Feb 2026 09:40:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772098830; cv=none; b=fTgfuGcaaQ/993jYTmIs3C4hpUlor35b/8q17i7OUK1kouKBiDNlHhmYks7EVKPQzHyKafrzxh0hx50CWtN9fOQLY7Eyt5+99f6sfTp8vn2hSpORmUB5j+o/0Lm21pEXAu6u6nc3FVgOQAUKHmDavAM2O7TtBdHXaqvFuD22gi4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772098830; c=relaxed/simple; bh=3uH3FBgkdH0OdfPwZ/VnlXYx1H8nmjI8dbYBnurNgWI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YE3dXWvRjkA3fG/AxacJ3WouZmshFEA9vfUqUuq69BPNlziB2nWLubCBjURra01fLM6y2wtFgouxeGs6dByWxmJVhZaT2++siWNpAydqvuVXoUVLmpVjm99DLddTV0iTedcP1uDYrOYHs1ij5+xRgrua+pEHSa2eRl0N4Ab6/r8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fHmLYZ4I; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fHmLYZ4I" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3178C19422; Thu, 26 Feb 2026 09:40:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772098829; bh=3uH3FBgkdH0OdfPwZ/VnlXYx1H8nmjI8dbYBnurNgWI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fHmLYZ4IkIVi9cVgJPYjmSmXlaJdVTh+vDU5ehkyNQaeserWhVW5uur6nImiVrcZi esARdS7umLqdvmgPyoIYbBKrHNXAi5ymbLNreLyPxbpDhSGN3ii+FEYrZrRoHvAqvz OWFmqHSkrO/1u1fEpN+cFgGOBmkO67O0D2jOguMp1E2q4K8ouwdPyZIkYoiewY+d0c MnQKIVs2FWJHfG/NFAY7MehYh47XNi4HqvR1dGPRgfDkFq4kjhfNkHD7ALo94tjz2y YdGgvZ7vrb/5lrhBfpEomBfjgoVqpbQmK2MHnR5ZJ9UwJY7BKiwOTcH6NP+SZt0JVY oMaZalVXC9pGQ== Message-ID: <042fceca-f2ba-4656-87d0-89676cdd435c@kernel.org> Date: Thu, 26 Feb 2026 10:40:25 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/1] mm/slab: mark alloc tags empty for sheaves allocated with __GFP_NO_OBJ_EXT Content-Language: en-US To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, vbabka@suse.cz, harry.yoo@oracle.com, 00107082@163.com, cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260225163407.2218712-1-surenb@google.com> <3ab53191-5aac-4b9f-a019-303d837ec517@suse.com> From: "Vlastimil Babka (SUSE)" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 2/25/26 22:28, Suren Baghdasaryan wrote: > On Wed, Feb 25, 2026 at 9:23 PM Vlastimil Babka wrote: >> >> On 2/25/26 8:08 PM, Suren Baghdasaryan wrote: >> > On Wed, Feb 25, 2026 at 4:34 PM Suren Baghdasaryan wrote: >> >> >> >> alloc_empty_sheaf() allocates sheaves from SLAB_KMALLOC caches using >> >> __GFP_NO_OBJ_EXT to avoid recursion, however it does not mark their >> >> allocation tags empty before freeing, which results in a warning when >> >> CONFIG_MEM_ALLOC_PROFILING_DEBUG is set. Fix this by marking allocation >> >> tags for such sheaves as empty. >> >> >> > >> > I think this should also have: >> > >> > Fixes: 4c0a17e28340 ("slab: prevent recursive kmalloc() in alloc_empty_sheaf()") >> > >> > and CC to stable for inclusion into 6.19. >> > Andrew, Vlastimil, should I post another version CC'ing stable or you >> > can add that line and forward to stable? >> >> I will add it. Note, they don't care about getting an actual email, but >> seeing the Cc: line in the mainline commit. > > Perfect! Thank you. Let me know if anything else is needed on my end. I tried to cherry-pick it to 6.19 stable and there were conflicts so I think it's easier to just remove the Cc stable. Instead I updated the changelog/trailer to contain: The problem was technically introduced in commit 4c0a17e28340 but only becomes possible to hit with commit 913ffd3a1bf5. Fixes: 4c0a17e28340 ("slab: prevent recursive kmalloc() in alloc_empty_sheaf()") Fixes: 913ffd3a1bf5 ("slab: handle kmalloc sheaves bootstrap") Reported-by: David Wang <00107082@163.com> ... Added to slab/for-next-fixes, thanks! >> >> >> Reported-by: David Wang <00107082@163.com> >> >> Closes: https://lore.kernel.org/all/20260223155128.3849-1-00107082@163.com/ >> >> Analyzed-by: Harry Yoo >> >> Signed-off-by: Suren Baghdasaryan >> >> Reviewed-by: Harry Yoo >> >> Tested-by: Harry Yoo >> >> Tested-by: David Wang <00107082@163.com>