From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B922B3BC672 for ; Mon, 30 Mar 2026 11:26:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869996; cv=none; b=hbm06UrW1uHYxxjoMXHLZKkfd1IeVOcD8zYDgYGjRmOAvc1nzo643hIuqlymgCzE0IXObbK14bEADxWyhzuG8oMJns2ilbMMeTwwWh6zEbd2cLbTMClQ3AGLgOuqOdT78L3iorvS0XtRBX946tG1sh6nHfHl9cuitR3OAvE6zGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869996; c=relaxed/simple; bh=nuwbVwX+dT7mTTqkTk6T2EzDvrPpUIcfoiRmSWimMtw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Pmc3zr2UHmITNLnPGHMzjyeJH51AFd5jaqiM0iPkJjfK40o4k7p7+ocEaxWiffeIUOuA5+ljL1uso5//7ZJF7KS4ch9rTg7PG1MOrM/p+muX8RNXLMB5DZUqi9IpYH60kYzUhy3sxLdBgJqu5w5VpQrKJg2m9JvoGeJ0botdWPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UDgkPzVO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OG1I5ZJg; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UDgkPzVO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OG1I5ZJg" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62U9nB2w3721921 for ; Mon, 30 Mar 2026 11:26:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= J9OacODv0jxOnFnHvap4XRUfvTFpgpYUyq/ZZHZUXA0=; b=UDgkPzVOlZfZxCFn QvJQ/9AkVsMn6h2/b13qH3kQAvpFmZ0fpBB8sDbGbBU9yMzQ50NENTemuqe15xH+ bDyslHAkeEoYWzKJsomdij6doHzcymE+dQASaT68GO+lfi/YgQDZzxrvZItgIdyU 6KjwF0X1D47rF+hdYg4jFCYXtasUZOdh0x7aTHlIx3S1zvFYAsyQu0y6kC7gBRwN 03qcxTOKNdc4tu++LPZ3aN5XJUOh0wFxfMbuY39unlNgcngZlA8Fpl795Vm7Z/DH lhKv0DYtISVEdRBXaDNobWk7/8xgsNWQnKy+VsmH15/XA/057MARmAg1TLPU1Ti+ iWj/tw== Received: from mail-dl1-f71.google.com (mail-dl1-f71.google.com [74.125.82.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7pvmrb14-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 11:26:32 +0000 (GMT) Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-12a77b008deso677608c88.0 for ; Mon, 30 Mar 2026 04:26:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774869992; x=1775474792; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=J9OacODv0jxOnFnHvap4XRUfvTFpgpYUyq/ZZHZUXA0=; b=OG1I5ZJgujn6Wb6jUZFM630BReIRNLiBEfF4DnXQcOx6V1Acxim4D792HvRmtrTQjh MhOOF40zMrszNQ1z7Z3ezY9frgo/BKMxT6e2i37WZQ/dEVGAlJwHrvwacCPPBANLjYAB +hWXFWmjnr+GpLZg+oCVGXpzRTO4RLn0GJkDtC9VptCw03XmiRYek6m6yKZL2oQBPSko tTrLJ7zXQGDD8llhH7fAcdnAWjEkB7SdEwdCW2ejqF/YSgvlJGjFYykIlp79ylbun3Oq 9rbOfR/DldG64gHJRy91XADj5h2H9UryM1y/Dx6kubo6IE7DIJIKi35jzTOZoJsjfCdK K9gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774869992; x=1775474792; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J9OacODv0jxOnFnHvap4XRUfvTFpgpYUyq/ZZHZUXA0=; b=op8g7WxK2O7l2wt+cxZBsnTo+EPG9umtidxAItCoQAcZmtzgINZWra5/5RgHdOLevN J9CdYKBMYyW8TsDwnjmUTY//Z+IZBRqXFwBXPzVwuszBScrg4bks0ryRoxHHtlexI+9I SVMrxusLIQrLu+xXKO3CE78bxFXlE500tmQ70bp2toKD+kbf7j59umGEr5NQkqDGu5f+ lxGG2EfkUoardfS6cK5FA21Zsr9RL+PDuhTyPeOcx8L8QsR8TpD5/UU3w7kZ1Zc2Qn4U oMKEmuqQSPlzoHsQ2hSgBR4pPczyoYvXrKuWfcNAxwbCD6ikQTf15W/Hx7ASSD2nHUnN kHkA== X-Forwarded-Encrypted: i=1; AJvYcCUM0uCqWPgNtNMGniW91S1q14YrLEax3cJGqWIekxTu3VnaDJzxUkRe+WKaDQ0ZHdBE7P3PTHiAdkI4Da8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzn6murOeTRvAJHX83Abs2ZV2/EU7NQ+pfvGekJfZYHmo76O7Y8 /99ywzuWVtuFfiVZM8EGqyWOYIX5xilusX3WSUB1bdawMTZhDXe8qfo2f2RIANAsClTdYpjksW4 rMdS84YKpdO9ABGidAWmX6dLlJjG9d82ZnHdCIf+aSCRud7kidU3YCJ+fRkk2JgP6zTU= X-Gm-Gg: ATEYQzxLQyHpPke5IuUei5qPT0nz+nbp5uO6/9G9DIAmpXlLo5Xx+oEHkH6JQ1Spucp dbeerGLOZXPKjAEgF0WtSvR66SXfYp+QO9NtYWkmGdhIeZTCz0xuY2S9IsE29bpT46q8wdpUrNS 6Z8L92V4hB2BzMpAMoZLgkHVhza6R/1M0hlxXrYzFuNy3tR2ComRlkKUFsyVCTkOiSaqXsdJ4uE 4LEmbRDzQibDuFCX+r3/cnF/YrO/D2FJmF6dESCb6sR1Unpmvg1EtFR/sXOzCTbMA9cOWlS4emd bFWTll+Po73Vztmpwud7HelgiHSIPmYlZMEWs43aWejlihTpPWR8FjUrR6vnPjL74hYJgLXd9lj fcxodcjVqT2Ibm0dedTDaYgH+zHqVK10Sz9al44iIuVPYmlryRH1Wfwny8uFpmb7l/H41HDBvKM ApBak= X-Received: by 2002:a05:7022:128b:b0:128:c9fa:4c32 with SMTP id a92af1059eb24-12ab28f861emr7327514c88.28.1774869991680; Mon, 30 Mar 2026 04:26:31 -0700 (PDT) X-Received: by 2002:a05:7022:128b:b0:128:c9fa:4c32 with SMTP id a92af1059eb24-12ab28f861emr7327494c88.28.1774869991104; Mon, 30 Mar 2026 04:26:31 -0700 (PDT) Received: from [10.110.38.145] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12ab97e7a57sm9133344c88.6.2026.03.30.04.26.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 04:26:30 -0700 (PDT) Message-ID: <04303789-2473-4030-817e-9a1dce99e6ae@oss.qualcomm.com> Date: Mon, 30 Mar 2026 19:26:24 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/38] drm/msm/dp: splite msm_dp_ctrl_config_ctrl() into link parts and stream parts To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250825-msm-dp-mst-v3-0-01faacfcdedd@oss.qualcomm.com> <20250825-msm-dp-mst-v3-5-01faacfcdedd@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 5UYOnl-ELQZtIQVvjgMLGQTZKBSIcNse X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA5MCBTYWx0ZWRfX9ty/Ji65/JwK VcBCJz3ymyM4Kh90qvPENMGTjnOifuEtaMKQJgmvi1jzTDfoVDGD6qO6GuLKKPKS5gX604uYE3F gS/vmq72fddF4mVBBqpXURyW0vgCFwElFExNzfLN5M/0+PkqYwaMKzkYVUhcN1GfMSyzrQeWkPF nqXcQ0/v8GyKO9vk0imFTD3KjQHRrhvZtXBbXMld9HyxtGzptgV2TgstpYryh0qtiyKB8HqPx3Z Mch98xeh9geL1cuRykt4h79zoklgWHsEUdu8kD6awBK1ExB7DcQq76PhfGvWcvc3h0KjQ9sleQV +0fAqRAltzywGdRrr5bIB/OE4f7IQ6IlKtOpxvddYyulWMDqwY6Kop6uoagB2l92zMAurNXFihT EshO0WIJhBfACB/NLXJTPReIY7zPzSuy8RgOwuJ9keu+PI03JcCLNOGb4Iklz9D/hXZWinf351M /haEhLH1snPOJoccSCw== X-Proofpoint-ORIG-GUID: 5UYOnl-ELQZtIQVvjgMLGQTZKBSIcNse X-Authority-Analysis: v=2.4 cv=S9rUAYsP c=1 sm=1 tr=0 ts=69ca5de8 cx=c_pps a=JYo30EpNSr/tUYqK9jHPoA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=_li15neZe1v-_mplcrYA:9 a=QEXdDO2ut3YA:10 a=Fk4IpSoW4aLDllm1B1p-:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 clxscore=1015 adultscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300090 On 3/30/2026 6:33 PM, Dmitry Baryshkov wrote: > On Mon, Mar 30, 2026 at 05:00:56PM +0800, Yongxing Mou wrote: >> >> >> On 8/26/2025 1:28 AM, Dmitry Baryshkov wrote: >>> On Mon, Aug 25, 2025 at 10:15:51PM +0800, Yongxing Mou wrote: >>>> The DP_CONFIGURATION_CTRL register contains both link-level and >>>> stream-specific fields. Currently, msm_dp_ctrl_config_ctrl() configures >>>> all of them together, which makes it harder to support MST. >>>> >>>> This patch separates the configuration into two functions: >>> >>> git grep "This patch" Documentation/process >>> Got it. Will fix it next patch. >>>> - msm_dp_ctrl_config_ctrl_link(): handles link-related fields >>>> - msm_dp_ctrl_config_ctrl_streams(): handles stream-specific fields >>>> >>>> It also moves the link-related configuration out of >>>> msm_dp_ctrl_configure_source_params(). >>> >>> Why? And it looks like a separate patch... >>> >> Because the patches following msm_dp_ctrl_configure_source_params() will >> take a panel parameter, and lane_mapping and peripheral_flush seem to be >> more closely related to the link, they have been moved out. > > This still looks like a separate patch. > Sure. Will update it next patch. >>>> >>>> Signed-off-by: Yongxing Mou >>>> --- >>>> drivers/gpu/drm/msm/dp/dp_ctrl.c | 49 +++++++++++++++++++++++++--------------- >>>> 1 file changed, 31 insertions(+), 18 deletions(-) >>>> >