mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <gaoxin@cdjrlc.com>, <miquel.raynal@bootlin.com>,
	<richard@nod.at>, <vigneshr@ti.com>
Cc: <jim.cromie@gmail.com>, <linux-mtd@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd:do not initialise statics to 0.
Date: Thu, 21 Jul 2022 06:43:56 +0000	[thread overview]
Message-ID: <04309792-a73f-2bb8-6138-c4151d168ef3@microchip.com> (raw)
In-Reply-To: <20220720195526.9289-1-gaoxin@cdjrlc.com>

On 7/20/22 22:55, Xin Gao wrote:
> [You don't often get email from gaoxin@cdjrlc.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> do not initialise statics to 0.

Please describe why. It may worth reading:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

> 
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
>  drivers/mtd/maps/scx200_docflash.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/maps/scx200_docflash.c b/drivers/mtd/maps/scx200_docflash.c
> index 8462662b7128..a565d69d28d6 100644
> --- a/drivers/mtd/maps/scx200_docflash.c
> +++ b/drivers/mtd/maps/scx200_docflash.c
> @@ -24,7 +24,7 @@ MODULE_AUTHOR("Christer Weinigel <wingel@hack.org>");
>  MODULE_DESCRIPTION("NatSemi SCx200 DOCCS Flash Driver");
>  MODULE_LICENSE("GPL");
> 
> -static int probe = 0;          /* Don't autoprobe */
> +static int probe;              /* Don't autoprobe */
>  static unsigned size = 0x1000000; /* 16 MiB the whole ISA address space */
>  static unsigned width = 8;     /* Default to 8 bits wide */
>  static char *flashtype = "cfi_probe";
> --
> 2.30.2
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/


      reply	other threads:[~2022-07-21  6:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 19:55 Xin Gao
2022-07-21  6:43 ` Tudor.Ambarus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04309792-a73f-2bb8-6138-c4151d168ef3@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=gaoxin@cdjrlc.com \
    --cc=jim.cromie@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®