From: Christian Loehle <christian.loehle@arm.com>
To: Zhongqiu Han <quic_zhonhan@quicinc.com>,
rafael@kernel.org, lenb@kernel.org, pavel@kernel.org,
tony.luck@intel.com, reinette.chatre@intel.com,
Dave.Martin@arm.com, james.morse@arm.com, ulf.hansson@linaro.org,
amit.kucheria@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] Documentation: PM: QoS: Fix return type and return value description
Date: Fri, 1 Aug 2025 12:27:28 +0100 [thread overview]
Message-ID: <04333423-56d8-4c4f-a5fe-143b179cdd43@arm.com> (raw)
In-Reply-To: <20250721124104.806120-5-quic_zhonhan@quicinc.com>
On 7/21/25 13:41, Zhongqiu Han wrote:
> The documentation for cpu_latency_qos_request_active() incorrectly stated
> the return type as 'int' instead of 'bool', and the return value
> description was incomplete. This patch corrects the return type and
> clarifies the return value semantics.
>
> Fixes: b8e6e27c626e ("Documentation: PM: QoS: Update to reflect previous code changes")
> Signed-off-by: Zhongqiu Han <quic_zhonhan@quicinc.com>
> ---
> Documentation/power/pm_qos_interface.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/power/pm_qos_interface.rst b/Documentation/power/pm_qos_interface.rst
> index 1ede4cafc2e3..c6b8b9cda166 100644
> --- a/Documentation/power/pm_qos_interface.rst
> +++ b/Documentation/power/pm_qos_interface.rst
> @@ -55,9 +55,9 @@ void cpu_latency_qos_remove_request(handle):
> int cpu_latency_qos_limit():
> Returns the aggregated value for the CPU latency QoS.
>
> -int cpu_latency_qos_request_active(handle):
> - Returns if the request is still active, i.e. it has not been removed from the
> - CPU latency QoS list.
> +bool cpu_latency_qos_request_active(handle):
> + Returns true if the request is still active, i.e. it has not been removed from
> + the CPU latency QoS list.
>
>
> From user space:
I guess this should be swapped in the series with patch 3? (First fix old, then add
new?)
Anyway it applies in and of itself.
Reviewed-by: Christian Loehle <christian.loehle@arm.com>
next prev parent reply other threads:[~2025-08-01 11:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 12:40 [PATCH v2 0/5] PM QoS: Add CPU affinity latency QoS support and resctrl integration Zhongqiu Han
2025-07-21 12:41 ` [PATCH v2 1/5] PM: QoS: Add support for CPU affinity latency PM QoS Zhongqiu Han
2025-08-21 10:37 ` Rafael J. Wysocki
2025-08-22 10:31 ` Zhongqiu Han
2025-07-21 12:41 ` [PATCH v2 2/5] PM: QOS: Remove unnecessary KERN_ERR on WARN() calls Zhongqiu Han
2025-07-21 12:41 ` [PATCH v2 3/5] Documentation: PM: QoS: Add CPU affinity latency PM QoS Interface documentation Zhongqiu Han
2025-07-21 12:41 ` [PATCH v2 4/5] Documentation: PM: QoS: Fix return type and return value description Zhongqiu Han
2025-08-01 11:27 ` Christian Loehle [this message]
2025-08-04 11:58 ` Zhongqiu Han
2025-07-21 12:41 ` [PATCH v2 5/5] resctrl: Replace PM QoS logic with cpu_affinity_latency_qos_* helpers Zhongqiu Han
2025-07-28 10:09 ` [PATCH v2 0/5] PM QoS: Add CPU affinity latency QoS support and resctrl integration Christian Loehle
2025-07-28 10:40 ` Zhongqiu Han
2025-08-02 14:38 ` Christian Loehle
2025-08-04 13:47 ` Zhongqiu Han
2025-08-15 12:48 ` Zhongqiu Han
2025-10-23 11:03 ` Ulf Hansson
2025-10-24 8:40 ` Zhongqiu Han
2025-10-24 10:44 ` Ulf Hansson
2025-10-27 12:38 ` Zhongqiu Han
2025-10-23 13:09 ` Lukasz Luba
2025-10-24 8:25 ` Zhongqiu Han
2025-10-28 13:12 ` Lukasz Luba
2025-10-30 13:25 ` Zhongqiu Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04333423-56d8-4c4f-a5fe-143b179cdd43@arm.com \
--to=christian.loehle@arm.com \
--cc=Dave.Martin@arm.com \
--cc=amit.kucheria@linaro.org \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=quic_zhonhan@quicinc.com \
--cc=rafael@kernel.org \
--cc=reinette.chatre@intel.com \
--cc=tony.luck@intel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®