From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E1493FCC for ; Wed, 4 Feb 2026 00:49:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770166190; cv=none; b=qDIP/fu7jifHmKcbkQwJz9gCtYjfyGKGGGEIkBvy++gdx7fk0WSEDzC6re7Huhdf/+plw9BeDbMZxzK2B1na6UW4S7lh37e30FpqbSysXo8NUgE1B888R8fDkmkSXv+YpCbJ8PAoNhu7X0AgKc4aInZXiuP4HxexNLy2w+2DqI0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770166190; c=relaxed/simple; bh=S5wqWJ/X9o7EGRxL5LCMmAmaRUc9szYlhY95kspTChI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qg6If9I1ZW9uvkaJUsB0YyhUI1Y+i0Os7Wk6IcOiQ9ib8RVLrl5bhwdE+Zrjw1Y9Hm665xLgK5Hv8TDg60gfcUy+FvQ+xthX3vK6tjEcSFPPlPsO4R8KaBH3dqworipFm9/CVJLmU7qIeTb6F3s4rkrzAzTXsfleu7wjo6wyAjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Ik5pRCAq; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Ik5pRCAq" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-45f015a3259so2405117b6e.2 for ; Tue, 03 Feb 2026 16:49:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1770166186; x=1770770986; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hMsM9JKT9K8kSTqNUb7Y1F/oUVnPtGz0MMvS4d5Lupw=; b=Ik5pRCAqnJIoAtkNH4wQLIZyq6mnXY5ghF2AYhA8ZKZwhENukbhE171blQZ7eO1nZ/ jxV9CRzTAwgrLMrSM18OUFY6EaPocl9Nr+bicCtuvJSblXewPW3+91VNnVEA4PWV9SSI Q3Dkw8QKW9tzdYvEV+gbTsGNT7TtSYqrkXAZD05038B+/Szd6u7BhG/MHb5nkvkx5aYW 99/k4kbzN0ilty5fTh+N9bIdbruMTc8RuKWl0fNAyjJmiN5+hbLDhErIQ9veFsGYkptP rmY98xsq+jLx3hB200WY+DBOjmPbMlfkYXjwcW6PqrXSl9+dpbJY0AzmkgsiQzGKDSLV mQrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770166186; x=1770770986; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hMsM9JKT9K8kSTqNUb7Y1F/oUVnPtGz0MMvS4d5Lupw=; b=UWETsBn2rcyylWFUyESePVszlqyG6GXp9fhAj/QiQxnDC4KKpdYBmmYOAybjnTpRNf /OqGR6pjT5RCcYuSdeNTdhBNQ2gbGKGYKu4S+WyEj9BnC2GmGqGiB3Y4V92hGtCkdb8F UZEOZjE9b9/NgJ2YIStU01E9qS+1ynmfrBHLklC2foKQ/FxdZtkE8cpo4WlFa7lDTv3h fL8QLJwIVfKaDyKosIScJ0IMC92jjmwm1WpqXGKuTZI8MWOmuEKyPMvrpGVFpDitdX29 B4UochGlS7WinqiKQAlo/Kpjdi8KCTZhYZ/jbQ3LomqzTy/v4hGfW8TEWAMvu+t0LA+Y YlTg== X-Forwarded-Encrypted: i=1; AJvYcCWuPDVv497AlB0+K50K7WWT/6Qx3KEKaRVLQMApgvfk10kuACjqX15l/65PFXLqRBUq1Yu+qfNCZNcuKrk=@vger.kernel.org X-Gm-Message-State: AOJu0YydaHJGnDXVI7SSgPagdFoDXNCziabGIXrV5mRRNX3DLDhm+NCx lglSJOJJcgyrEIGpzSJuzLZSIva9M3JZDNTcTCVCYgzV+diBdQayNhH52eQ7QPpYn8E= X-Gm-Gg: AZuq6aKdCDMh0oyh+22PtroTZSN1NQ4RNZGSkQT4EHLnNAgJn4NlIHRP7DU384Qcxtp c3we37VSjfHjfQYNU9jY7axees9Zf1GS4GEaK8S+LB7h/ah+W0xuKrJ/2kCLgF6QfiFcUwIAgi2 0fbDZrscBjvrOrmiW9jHHRqbt3kXcefZ3k8wvR8Pa+u0W85UsqlAs1EHuRjr8hE9CJx1z0R+Coy +IlFaKKtAfJO8oIU3R4F5Jh02BVwAbVBqS0uZ8gA1UYBV9CxIFpPWLU0dIpANxW7wL2kvXOzitf gU5EUCiTPwznAm9sBx2bqHMCLmVJgHNEHnwGkplXLSuUTQKn79689jLUp3DqTks0Q/WngowExZm wogweXN+JZDgw+af4lZM6UrWoqANrgKYVVZS2PEv4aJSmXu1wKmkP9QC44nO0rkFnPxRcuBqr2N H0klvR80PYjzK+Q5bFGz7Tkk5QlZEv0rMfDZ7c0suXlus9RCUBRuAa2t4= X-Received: by 2002:a05:6808:1b11:b0:44f:e912:ea97 with SMTP id 5614622812f47-462d58a27c3mr685412b6e.18.1770166186017; Tue, 03 Feb 2026 16:49:46 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:8e13:880:992:e796? ([2600:8803:e7e4:500:8e13:880:992:e796]) by smtp.gmail.com with ESMTPSA id 5614622812f47-462d6777405sm536198b6e.13.2026.02.03.16.49.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 16:49:45 -0800 (PST) Message-ID: <04336665-1766-4d93-bbe9-9b99bba48e29@baylibre.com> Date: Tue, 3 Feb 2026 18:49:44 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: magnetometer: bmc150_magn: Used guard() for mutex protection To: Neel Bullywon , Jonathan Cameron Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260204000350.25454-1-neelb2403@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260204000350.25454-1-neelb2403@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/3/26 6:03 PM, Neel Bullywon wrote: > Replaced the manual mutex lock/unlock calls using guard() to simplify > the error handling and reduce goto statement usage. > > By using RAII-style cleanup, it ensures the mutex is always released > when exiting the function, regardless of the return path taken > > This was compiled test only > > Signed-off-by: Neel Bullywon > --- > drivers/iio/magnetometer/bmc150_magn.c | 17 +++++------------ > 1 file changed, 5 insertions(+), 12 deletions(-) > > diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c > index 6a73f6e2f1f0..73d9183a354b 100644 > --- a/drivers/iio/magnetometer/bmc150_magn.c > +++ b/drivers/iio/magnetometer/bmc150_magn.c > @@ -796,29 +796,22 @@ static int bmc150_magn_data_rdy_trigger_set_state(struct iio_trigger *trig, > struct bmc150_magn_data *data = iio_priv(indio_dev); > int ret = 0; We can take this a bit farther and drop the init here. > > - mutex_lock(&data->mutex); > + guard(mutex)(&data->mutex); > + > if (state == data->dready_trigger_on) > - goto err_unlock; > + return 0; > > ret = regmap_update_bits(data->regmap, BMC150_MAGN_REG_INT_DRDY, > BMC150_MAGN_MASK_DRDY_EN, > state << BMC150_MAGN_SHIFT_DRDY_EN); > if (ret < 0) > - goto err_unlock; > + return ret; > > data->dready_trigger_on = state; > > - if (state) { > + if (state) > ret = bmc150_magn_reset_intr(data); return directly here > - if (ret < 0) > - goto err_unlock; > - } > - mutex_unlock(&data->mutex); > > - return 0; > - > -err_unlock: > - mutex_unlock(&data->mutex); > return ret; and return 0 here. > } >