From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753586AbdBUO71 (ORCPT ); Tue, 21 Feb 2017 09:59:27 -0500 Received: from nbfkord-smmo02.seg.att.com ([209.65.160.78]:44662 "EHLO nbfkord-smmo02.seg.att.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752571AbdBUO7U (ORCPT ); Tue, 21 Feb 2017 09:59:20 -0500 X-MXL-Hash: 58ac55c776c27579-2dd64184c83fad826e88f6f20810628f1d009acf X-MXL-Hash: 58ac55bf7b308ae5-daad9605a5a7c0b45d0496d5f13db3cb92b55c10 Subject: Re: [net-next][PATCH] RDS: keep data type consistent in the user visible header To: David Laight , "'David Miller'" , "sowmini.varadhan@oracle.com" References: <1487387747-5324-1-git-send-email-santosh.shilimkar@oracle.com> <20170220.101951.663166903772216217.davem@davemloft.net> <20170220153722.GB16561@oracle.com> <20170220.103912.194197218422769191.davem@davemloft.net> <063D6719AE5E284EB5DD2968C1650D6DCFE6CA26@AcuExch.aculab.com> CC: "santosh.shilimkar@oracle.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Edward Cree Message-ID: <0437debe-fd44-20ab-c2d2-02c14255da9a@solarflare.com> Date: Tue, 21 Feb 2017 14:58:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DCFE6CA26@AcuExch.aculab.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.20.45] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-22898.003 X-TM-AS-Result: No-1.284700-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-AnalysisOut: [v=2.1 cv=T6yKOq+Q c=1 sm=1 tr=0 a=8P+NB+fYZDP74ap4g4d9Kw==] X-AnalysisOut: [:17 a=fVG4DLb5TBsA:10 a=IkcTkHD0fZMA:10 a=n2v9WMKugxEA:10 ] X-AnalysisOut: [a=8XOKC7VvAAAA:8 a=MsXaa8F7GflvoQokmTwA:9 a=QEXdDO2ut3YA:1] X-AnalysisOut: [0 a=6PT1Oncw0HEA:10 a=Q-kz1oIm2yIA:10 a=9zekaur5fricKu9Bpq] X-AnalysisOut: [Pb:22] X-Spam: [F=0.2000000000; CM=0.500; S=0.200(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [193.34.186.16] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/02/17 14:29, David Laight wrote: >> The entire file should use the proper "__uX" kernel types >> rather than the uint* ones. > The uint* ones are part of the C standard :-) > > David > ... which is exactly why we can't use them. http://yarchive.net/comp/linux/kernel_headers.html#17 Visibility of types is defined by a twisty maze of standards, all different (POSIX, SuS, BSD_SOURCE, XOPEN_SOURCE...). __u8 and friends are in the reserved system namespace, so we can safely use them in user headers. -Ed