From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D1B5264FAB; Mon, 21 Apr 2025 12:38:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745239126; cv=none; b=s88cALVC2zMNI1kl0oMVB8xaOH8ltgfuWXJW74VNUwSmjklhs497sH2ijSYEGhebBbSjRIlOD00O+nfXj009dZU26J4oWZAb5ZjwWWSRWbXxgudOBlRjLGz4tAgw/+uCoZNryhbWhkhm5vd+Cs9mfne2BVXNjtvAekkEJwBgI1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745239126; c=relaxed/simple; bh=AjpZhxHgw7qMiRLv7rf7Jr0DwqV6Zg0U/YAwUhYlITY=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=gjTQ/QQ6lymngn09hi69C779PeI7sA1hPYTcP3GVtXlIxb+SBPp5i8Eu/00zGp3pJ3t+a27Yxksm36wv+dZsBXkCVrv5ZcIJyy86q8sh/dTOLfHIlEQvfWmDXt89bBA7XQfsamtRN/EL0HZ4LIn/72vGdo1zebUtz+Vonjw4m08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=fHprkbp2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="fHprkbp2" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53LAWRAh020861; Mon, 21 Apr 2025 12:38:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7koYvioPvRzXAFAbLV+hLSGgH6TDpYvLhnM6Qy1TsIc=; b=fHprkbp20vAaujXH UfZXJgJn1yULswonlH93+3n8225Fq938cE4UtGIWCGBDQy+semQRlXvzEXetNwRZ 3LTx5iJVuSWAulb02D2EKsofpFhrnuj3b1Bvh6WtVayLydXdlS+vUBKnsj+VfGhB /fQTPowTJbK0y2XkNLpLyCTwr5GOBu/PkmJKsZEx+PYeg6YBpNIS9OXLH/tpujSD 3mAS3cfT0OetZVH6WE9hzPcjnthvtAqIwZFgrKqFcqmaqR41jXy8kxLjS6QEYKXX kIOorW3iwVNDdKzrotpIl2U3b+LpGqRJAQwu/fkrWLA8cud5UX++n4+MVA2R0hpB z4N5rg== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4641hhmagb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Apr 2025 12:38:40 +0000 (GMT) Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 53LCce6a031453 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Apr 2025 12:38:40 GMT Received: from [10.204.100.69] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 21 Apr 2025 05:38:35 -0700 Message-ID: <043ad401-4c41-c64a-3ca8-a8c359218cb2@quicinc.com> Date: Mon, 21 Apr 2025 18:08:33 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v4 2/3] arm64: dts: qcom: sa8775p: add support for video node Content-Language: en-US To: Konrad Dybcio , Dikshita Agarwal , Abhinav Kumar , "Mauro Carvalho Chehab" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov CC: , , , , , Bryan O'Donoghue References: <20250321-dtbinding-v4-0-6abd4575bff4@quicinc.com> <20250321-dtbinding-v4-2-6abd4575bff4@quicinc.com> <84945c27-f4c2-444b-81bd-27a58f9afeea@oss.qualcomm.com> From: Vikash Garodia In-Reply-To: <84945c27-f4c2-444b-81bd-27a58f9afeea@oss.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Authority-Analysis: v=2.4 cv=Fe43xI+6 c=1 sm=1 tr=0 ts=68063c50 cx=c_pps a=JYp8KDb2vCoCEuGobkYCKw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=KKAkSRfTAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=LZ6umLkproNEgS6FCqMA:9 a=1ytpMVuofPDqXyPX:21 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: NLfJ7ICs7l8aUZd3xNEjV1OEAimXg-fl X-Proofpoint-ORIG-GUID: NLfJ7ICs7l8aUZd3xNEjV1OEAimXg-fl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-21_06,2025-04-21_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 adultscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504210098 On 4/14/2025 7:03 PM, Konrad Dybcio wrote: > On 3/21/25 4:19 AM, Vikash Garodia wrote: >> Video node enables video on Qualcomm SA8775P platform. >> >> Reviewed-by: Bryan O'Donoghue >> Signed-off-by: Vikash Garodia >> --- >> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 71 +++++++++++++++++++++++++++++++++++ >> 1 file changed, 71 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >> index 3394ae2d13003417a15e64c9e47833725ec779e6..6e4644b95fb678fd201310463709d7482d72d6e2 100644 >> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >> @@ -10,6 +10,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -3783,6 +3784,76 @@ llcc: system-cache-controller@9200000 { >> interrupts = ; >> }; >> >> + iris: video-codec@aa00000 { >> + compatible = "qcom,sa8775p-iris", "qcom,sm8550-iris"; >> + >> + reg = <0x0 0x0aa00000 0x0 0xf0000>; >> + interrupts = ; >> + >> + power-domains = <&videocc VIDEO_CC_MVS0C_GDSC>, >> + <&videocc VIDEO_CC_MVS0_GDSC>, >> + <&rpmhpd SA8775P_MXC>, >> + <&rpmhpd SA8775P_MMCX>; >> + power-domain-names = "venus", >> + "vcodec0", >> + "mxc", >> + "mmcx"; >> + operating-points-v2 = <&iris_opp_table>; >> + >> + clocks = <&gcc GCC_VIDEO_AXI0_CLK>, >> + <&videocc VIDEO_CC_MVS0C_CLK>, >> + <&videocc VIDEO_CC_MVS0_CLK>; >> + clock-names = "iface", >> + "core", >> + "vcodec0_core"; >> + >> + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY >> + &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ACTIVE_ONLY>, >> + <&mmss_noc MASTER_VIDEO_P0 QCOM_ICC_TAG_ALWAYS >> + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; >> + interconnect-names = "cpu-cfg", >> + "video-mem"; >> + >> + memory-region = <&pil_video_mem>; >> + >> + resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>; >> + reset-names = "bus"; >> + >> + iommus = <&apps_smmu 0x0880 0x0400>, >> + <&apps_smmu 0x0887 0x0400>; >> + dma-coherent; >> + >> + status = "disabled"; >> + >> + iris_opp_table: opp-table { >> + compatible = "operating-points-v2"; >> + >> + opp-366000000 { >> + opp-hz = /bits/ 64 <366000000>; >> + required-opps = <&rpmhpd_opp_svs_l1>, >> + <&rpmhpd_opp_svs_l1>; >> + }; >> + >> + opp-444000000 { >> + opp-hz = /bits/ 64 <444000000>; >> + required-opps = <&rpmhpd_opp_nom>, >> + <&rpmhpd_opp_nom>; >> + }; >> + >> + opp-533333334 { >> + opp-hz = /bits/ 64 <533333334>; > > I believe this should be 530-zeroes, not 533 and a third Thank you, will fix this. Regards, Vikash > > other than that > > Reviewed-by: Konrad Dybcio > > Konrad