From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AC1AC4360F for ; Wed, 3 Apr 2019 13:58:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E38D72084B for ; Wed, 3 Apr 2019 13:58:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726615AbfDCN64 (ORCPT ); Wed, 3 Apr 2019 09:58:56 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:59552 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725959AbfDCN64 (ORCPT ); Wed, 3 Apr 2019 09:58:56 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x33Dw1lf057267 for ; Wed, 3 Apr 2019 09:58:54 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2rmuedgxj5-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 03 Apr 2019 09:58:54 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 3 Apr 2019 14:58:52 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 3 Apr 2019 14:58:49 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x33Dwm1m50724990 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 3 Apr 2019 13:58:48 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A01F3AE057; Wed, 3 Apr 2019 13:58:48 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 591C6AE053; Wed, 3 Apr 2019 13:58:48 +0000 (GMT) Received: from [9.145.9.70] (unknown [9.145.9.70]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 3 Apr 2019 13:58:48 +0000 (GMT) Subject: Re: [PATCH -next] ocxl: remove set but not used variables 'tid' and 'lpid' To: Yue Haibing , andrew.donnellan@au1.ibm.com, arnd@arndb.de, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <20190329154456.27152-1-yuehaibing@huawei.com> From: Frederic Barrat Date: Wed, 3 Apr 2019 15:58:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190329154456.27152-1-yuehaibing@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19040313-0020-0000-0000-0000032BD5F1 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19040313-0021-0000-0000-0000217DE0FC Message-Id: <043b4570-24b3-64ef-0036-aa8467fab497@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-03_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904030096 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 29/03/2019 à 16:44, Yue Haibing a écrit : > From: YueHaibing > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/misc/ocxl/link.c: In function 'xsl_fault_handler': > drivers/misc/ocxl/link.c:187:17: warning: variable 'tid' set but not used [-Wunused-but-set-variable] > drivers/misc/ocxl/link.c:187:6: warning: variable 'lpid' set but not used [-Wunused-but-set-variable] > > They are never used and can be removed. > > Signed-off-by: YueHaibing > --- Acked-by: Frederic Barrat > drivers/misc/ocxl/link.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/misc/ocxl/link.c b/drivers/misc/ocxl/link.c > index d50b861..3be07e9 100644 > --- a/drivers/misc/ocxl/link.c > +++ b/drivers/misc/ocxl/link.c > @@ -184,7 +184,7 @@ static irqreturn_t xsl_fault_handler(int irq, void *data) > u64 dsisr, dar, pe_handle; > struct pe_data *pe_data; > struct ocxl_process_element *pe; > - int lpid, pid, tid; > + int pid; > bool schedule = false; > > read_irq(spa, &dsisr, &dar, &pe_handle); > @@ -192,9 +192,7 @@ static irqreturn_t xsl_fault_handler(int irq, void *data) > > WARN_ON(pe_handle > SPA_PE_MASK); > pe = spa->spa_mem + pe_handle; > - lpid = be32_to_cpu(pe->lpid); > pid = be32_to_cpu(pe->pid); > - tid = be32_to_cpu(pe->tid); > /* We could be reading all null values here if the PE is being > * removed while an interrupt kicks in. It's not supposed to > * happen if the driver notified the AFU to terminate the >