From: Joe Perches <joe@perches.com>
To: Michael Straube <straube.linux@gmail.com>, gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] staging: rtl8188eu: add spaces around '+' in usb_halinit.c
Date: Fri, 26 Jul 2019 11:21:36 -0700 [thread overview]
Message-ID: <0440fc0b1e8599df3cf0728261f74faf25fc4408.camel@perches.com> (raw)
In-Reply-To: <20190726180448.2290-1-straube.linux@gmail.com>
On Fri, 2019-07-26 at 20:04 +0200, Michael Straube wrote:
> Add spaces around '+' to improve readability and follow kernel
> coding style. Reported by checkpatch.
My preference would be to do all the horizontal whitespace
changes for the entire driver in one go without worrying
about long lines.
$ git ls-files -- 'drivers/staging/rtl8188eu/*.[ch]' | \
xargs ./scripts/checkpatch.pl -f --types=SPACING --fix-inplace
$ git diff -w drivers/staging/rtl8188eu/
$ git diff --shortstat drivers/staging/rtl8188eu
35 files changed, 603 insertions(+), 603 deletions(-)
Mention that git diff -w shows no difference and
verify that object files are unchanged and mention
both in the changelog.
Subject could be something like:
staging: rtl8188eu: Use typical kernel horizontal whitespace
prev parent reply other threads:[~2019-07-26 18:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 18:04 Michael Straube
2019-07-26 18:04 ` [PATCH 2/6] staging: rtl8188eu: add spaces around '&' " Michael Straube
2019-07-26 18:04 ` [PATCH 3/6] staging: rtl8188eu: add spaces around '|' " Michael Straube
2019-07-26 18:04 ` [PATCH 4/6] staging: rtl8188eu: add spaces around '<<' and '>>' " Michael Straube
2019-07-26 18:04 ` [PATCH 5/6] staging: rtl8188eu: add spaces around '-' and '*' " Michael Straube
2019-07-26 18:04 ` [PATCH 6/6] staging: rtl8188eu: cleanup comparsion to NULL " Michael Straube
2019-07-26 18:13 ` [PATCH 1/6] staging: rtl8188eu: add spaces around '+' " Larry Finger
2019-07-26 18:21 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0440fc0b1e8599df3cf0728261f74faf25fc4408.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®