From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964891AbdGTJUv (ORCPT ); Thu, 20 Jul 2017 05:20:51 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:33875 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933731AbdGTJUs (ORCPT ); Thu, 20 Jul 2017 05:20:48 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH] bluetooth: btwilink: remove unnecessary static in bt_ti_probe() From: Marcel Holtmann In-Reply-To: <20170719224931.GA16225@embeddedgus> Date: Thu, 20 Jul 2017 11:20:46 +0200 Cc: "Gustavo F. Padovan" , Johan Hedberg , "open list:BLUETOOTH DRIVERS" , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <04410763-BA78-422B-A4B3-B66D777E732F@holtmann.org> References: <20170719224931.GA16225@embeddedgus> To: "Gustavo A. R. Silva" X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gustavo, > Remove unnecessary static on local variable hst. > Such variable is initialized before being used, > on every execution path throughout the function. > The static has no benefit and, removing it reduces > the object file size. > > This issue was detected using Coccinelle and the > following semantic patch: > > @bad exists@ > position p; > identifier x; > type T; > @@ > > static T x@p; > ... > x = <+...x...+> > > @@ > identifier x; > expression e; > type T; > position p != bad.p; > @@ > > -static > T x@p; > ... when != x > when strict > ?x = e; > > In the following log you can see the difference in the object file size. > This log is the output of the size command, before and after the code > change: > > before: > text data bss dec hex filename > 4029 2528 128 6685 1a1d drivers/bluetooth/btwilink.o > > after: > text data bss dec hex filename > 4007 2472 64 6543 198f drivers/bluetooth/btwilink.o > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/bluetooth/btwilink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel