From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932110AbdASUD0 (ORCPT ); Thu, 19 Jan 2017 15:03:26 -0500 Received: from mail-by2nam01on0059.outbound.protection.outlook.com ([104.47.34.59]:24880 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932065AbdASUDW (ORCPT ); Thu, 19 Jan 2017 15:03:22 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Subject: Re: [PATCH 0/2] Introduce AMD Secure Processor device To: Greg KH References: <148484927002.30852.10568570584817827556.stgit@brijesh-build-machine> <20170119182101.GB30851@kroah.com> CC: , , , , , , , , , , From: Brijesh Singh Message-ID: <0442f536-221d-fcef-3009-4bc07403ccd8@amd.com> Date: Thu, 19 Jan 2017 14:03:12 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170119182101.GB30851@kroah.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR1301CA0001.namprd13.prod.outlook.com (10.174.164.142) To SN1PR12MB0671.namprd12.prod.outlook.com (10.163.208.29) X-MS-Office365-Filtering-Correlation-Id: 85d195dd-788b-4eee-9c45-08d440a635b5 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:SN1PR12MB0671; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0671;3:890FjR9DPqD+hNzcBVZ36ub8t0TuyrkyPhcrW/V1Iwo9kn8ZKW9wiaevughkJ33VvLEjhk15M7y3AsL67ZpTwbQkpp1sb70Av2qQJck6IRK3rUbmN++eUu/3lSAs9DU0ka7qwKSP5hVg3YUM9OojvvZJ9MGUUBiq/MizST5gd+CdMI4Qr7IvBPs+ZgEa0cikN1AV89zEB+VedquGZKBx4Nn5pG6fPj+7uq+V0btrfXkjtFbZAGie1LKEkPRzEH79/p3eQFi2Psi7GteiIGvoAg==;25:fX6wXZP2w/92TQGhTIo47gyz1aP4IJitQZxz2DSBYwuLKltMk3vLQwco7OwoJC/uK5DexoySK/41ELm0caU3vQNZqsUyKIlaQ7tyOPyQn1J4V/1h6G1fi2Al3JsabqC6ClTZBhDmysHQVpegXCgZioKoNyFEGMR/FKIJJYALCeJX1p0ieYIMQr97C/fDk39+bxVAI6J4ih6i07qKT94dtCf36g+jdxG9ZE2N/Un4GQMwqA7ZN0BKrGbVuMOI+DfPuhOjXZBvvW06oEcy1oXTKz5oJdJMgcNq0QEb+w/om1eci0frFpIj2/c/uPGozWTy7FvxgtYXAVwS/5VnGusUkoo/3vxGB9En6bLNsdSI8cLmr/pr4s4bXM8SxRb2xPBaV7G4UaidtmPMw9ylQcGSTWUzD/kdtVq1WONQYhUWiwJftBIYiLoJ/CbVlSGuYG2XDXgT3DoNU1gjraZqw7ohXA== X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0671;31:jy973nL7C5wIi1v1Ua4JSO1SaVlVeJY/mCW2oH4x6TvZVbL258XEoAuIKziqFaccb4OZ5jzZ1P4HhByKGSD539ATDCpkTIBoI/swdGedVa0oAgyRkEZZ8/fv7LyOeH8igKAveThrBcmi9A0o8xFDGnDCaKgi1VdIGmxaWOwcVZ1aYDJINmHAHvhC4r6+Cg1QXU/2XuWo7U0e40q3WNdsbgzUvg3PlNtm87JkYvfwa9MuDJtvMnw+FuTpaGzyTRS4;20:9/GEVvJtzJ/j9agpcZ6ChBSKXpBLDz++JHFV4xIaNd3OncqBcPNOpYgKN8fC9Aq6O7u7mRdHj9wHGSA/2rdmg+LsbW/VkoNZapwawa4EHbtOBBNfNkxfm8teyVrNvEYvjDCghoJjpqb8d21K5ipnP6W0pn8XiAr2WnAiZsyP99ZdKA/GPpsfUsIZCdwRykSpoN7L0t9WW22zXVqnZJ3p5H66aBaxqTFNPcZrbPGbmApTSRw8wWr4Dymw6+E323c7b7pfeJ+aLRdMFbfEsdE+Sf7xFpP/38HMoGFC61wIYF0BVjAqg7vT4wTgRveD9LrgFj0izcT3xdXYVTIdwlmKqDgizdJFr7JcNZbae2TFNENlG6z4e8ZB33IOidGGrHtvUiEFuLQlwpgIfBCSc5wF677rBcqRxxfLHoDNVxw6iwFZ7ic2lln1sagGpml/FOAfWnw/jVP7gJ3CoKY8tGdtzo9ddIPuE/VtCbZPnyECnz7nJ7wTlU71+Lol2iVw28IJ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123562025)(20161123564025)(20161123555025)(6072148);SRVR:SN1PR12MB0671;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0671; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0671;4:x8vg8iyRpfqZwfpRgX2UT6IlDdOgJukx8JzE2ISRu4Rio52PW5A1bNiORGUzmomOZOd+boAYTfQjqH3C+jKxr7ntVF4QTPqMvvCGNvha402elB4FJalGg3oAp/mmK24cUtKzZbKBiiHYNk54TzyGtj+ig4tdsaU2QR9K1SakvFh59V+Uc3shN01yNm6qEtixi8stOQkYcycrqHWLofXZKTnQboKo7KZ9cajIzRz7+GaP56RHpFGeHVyJevsKIW9R1NKmTiVbXvlEkGP5y/gYv9djNT3Jk0Z2tP7nARH4M1DZQedd1BoX1RIaBsj7AS+xtc87SwDOQn+jMrNTlMsVAaHdz9D4cVZJr9jkFmC3EE6VpBxtFQknZX/y6mwZt2nGOQbxXgxCm9eZpdzED+E09qsvgzY+4mdHUooDBZKSED4jLyfVN9u9vOMmcyabXV5rcBnhAbWjrpcaDiTnVLVJwDrWKdeDE3Gt5HRjIfMgHOtcHPsvox/w7p4MorrqfwF3KWU1zLvorTcmAsquVI2oDsNSy5l6tFayBE9xRK9PVc6TAEjxr0TIZgA8NuuzelTctDRkyRrtcqEJLAr1YjyaQ0PohkciEaaeZVzLWVn0HZHn2FO2nUTpK5QaFhVQmFFM5KyEW0h4dIKSrXyuaBghuA== X-Forefront-PRVS: 0192E812EC X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(39840400002)(39860400002)(39450400003)(39410400002)(39850400002)(209900001)(377454003)(199003)(24454002)(189002)(23746002)(36756003)(65806001)(7736002)(305945005)(47776003)(33646002)(230700001)(110136003)(92566002)(2906002)(50466002)(2950100002)(6666003)(6916009)(65826007)(68736007)(189998001)(5660300001)(86362001)(53936002)(97736004)(6306002)(31696002)(105586002)(6116002)(38730400001)(15395725005)(50986999)(76176999)(54356999)(25786008)(3846002)(8676002)(106356001)(81156014)(81166006)(4001350100001)(66066001)(54906002)(4326007)(101416001)(229853002)(65956001)(77096006)(90366009)(31686004)(6486002)(42186005)(39060400001)(64126003)(83506001)(6606295002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0671;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;SN1PR12MB0671;23:bIOEODIgDhgiUlwgldKjDlBy4qRLd6B1yHOSr?= =?Windows-1252?Q?YCSAf2j+t7oz/u1nj0oh28km35YNyek9uP6PMqTvGD8asmFR7dGQVfWj?= =?Windows-1252?Q?Iplmzsilp0Mw8G/l8BkJu9WuinMD3xVLjGsGhijI8eNyaeuRb53wCagc?= =?Windows-1252?Q?lW26HPBclEqqim4pc0Cjr5Ppa4DjvIfY0ZD2Af/wK0eLgZA1LMSS1WBw?= =?Windows-1252?Q?78gc65ABOQOOugL+OpF5I36AUHW+2hjHWhER5y+YbXv3UWUoMHN0EQJ4?= =?Windows-1252?Q?KHLAlLDEX3B9SgXLBNGuTfhe6WTKzql5x74LM6As0lfbzDE8+4vAN6cN?= =?Windows-1252?Q?I8B7nUnEBR5liFLS3L0rpWy9QARTgZwfmjPmU7eY224yyTaQrDHWXpvi?= =?Windows-1252?Q?5tOyt+D6Jtz4Rwof6DgD5/RT3c+koBfLIgCAqZ6bFKWPs8giok260Y+C?= =?Windows-1252?Q?19NFu2miKqpGEW4dcxvnPXpDqlY8r/AuqA9yvdD7YKpWsA1UsxIP6rVs?= =?Windows-1252?Q?H4lQg1mlxOPMTm+cL63jtDaYD9Shwy2hxOcDYbCHN+nhTPUS1A7E9h1z?= =?Windows-1252?Q?N8TJazrMYj0dBHY/y6bFQP1SH5w/35nx9kyLsDgVIEzUXIQZlUJ/Kzju?= =?Windows-1252?Q?N9LGWgXB9CjEHsMkLSEjG4Ipesdju+4R3tHmk5qym1AQkZi23Pg4VKTc?= =?Windows-1252?Q?sF0PadBiKodSl06VxJefPgTCLxJAYiGXxyr5pBPFAucHKhml2LFyoQUb?= =?Windows-1252?Q?WDymi0dThk4LxM4rJ04rWC3UxiqIhVPLzFtKPRsuTpqy0G5xdegbNTxT?= =?Windows-1252?Q?7mhEFlu+i9tpJfKz/7maLZN0fyL5JuyVSmwSloWAJYDcrbetH1jTnLVo?= =?Windows-1252?Q?cq63WMDMRYIwwe5vXpILQROKKpmoBtoazy1i5fdoGnrffUVCwEgtYHWE?= =?Windows-1252?Q?0VNV9+sTPQDldONaShDu0PZLeEPNhQu8b4IeKW5EY1By4zkEReKN9VXe?= =?Windows-1252?Q?ECACXw238K+rJDHULUgBb0ujbs8Vp6HZyW/Hgjsez95yiB5Be3L6nW2k?= =?Windows-1252?Q?yVAcZD35hbYhjoqvRoNbqF9aY6QRCUlSscthP2S97LqpZsppuK1OPte4?= =?Windows-1252?Q?rpCCdYxXn4iNk/WKrqPx3KNRxG4IsJ/DNbqn5K0iVica2UDwE3PMucoa?= =?Windows-1252?Q?cM6O4tWx3o8U6hJIF9g8+svWixrzXhOnsrSoha7gFu+ujovYTXvXjUeC?= =?Windows-1252?Q?mOKymJFicq1/MeU/hFi1XrQZCuc9ABzPrqdIWuy5KOsUL3gWwB4kC1lx?= =?Windows-1252?Q?ZRFa/kfsOaPqFgK57LjRGYiw19mx8hpccwmBlkB5i5OT/ywp9SmVutcI?= =?Windows-1252?Q?9uLjOJjBiRPs8hA6KHuGpck2GNySqeWVyc1d+UALZ0gINO61BtEWdHp3?= =?Windows-1252?Q?08bolTBFk3wsR4wH41VQWfW9Q/a9VbkzJyAQiGIouL2DdtE8Qr0X+bcf?= =?Windows-1252?Q?aBanVnSHLxn+No2kz0VzjxOaV3AJ/H0UgciJEc8StkvGGIfkGoiWqapU?= =?Windows-1252?Q?SsZ2n2WbzZxb8iiqTYh4e8OqhxzsayBAH15iTvk8zENpkvTXWbsN5FJk?= =?Windows-1252?Q?ntXMNJ9ouljNJ2r29YV1El38JbpxTMDkCWpA8dxiHno9ZijFtsiELbh+?= =?Windows-1252?Q?3+D4yRqWwYbaejT2DT2FORzkRh4VRwAg2+K6GAyDtDTbeOn25w7Nq92R?= =?Windows-1252?Q?pOL/d6fK+7N0VRc2w=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0671;6:ycUC4HWolNSdBLL8rJtVCh6K8UjKaE+rhjaOnPJ1BppVKrYFoqT8xtYycHGDu5YPYjqJQzRPdcIYTtm6svR8N2nAKOdgwMCuvn6zHOVRWhK8X5mMDRtLHSAPEMeXGZUpzqIuyL18/eZerfCVOwGS25DaijTlnj3v4AeuXRLi9B4L07EvW9+8c1+7IsVdZd/XBKLz3EHoKyIh67qALMhqj4jZa7v0ZLXhzC17V6fhbTzprVjk3wolqL96/kz4FZK7API6lGXXyV9+yL2O42l1WoZsVKE5A1/c7ZDJunJ1ZsXp2OjRFr1hMoPym1uUCWvHA9XlE9WgKrIaOpwz233KrZsOeKKIohmUITKYchQy/okOHJeggaO4wIBw6boQGEXcJ0yany91pd1S1hcn0o5AIHFLldLzq4/C/JyXdelhSWyL8W6bySSS5VjbVpOr8yBoBC3sFB042lDYMJilCmDGZA==;5:bYygqEFQ1FIeqsDP8CHdbNdeK9G0x46tRQXJcVMK7zta4LVUHA6P3NKvolfkyZsgX6jA/tnOXj2U+M0ha8s3PWR2e8WiG85D73896Y4CKiD6pCpivKbsvuJflnio306ug9hkAbcKVHa7z0SqJeTG5w==;24:wmj+si3UliJysTM51sEU8DkbKwpdlTZU6djtHr9FOQmMc7Nn4s2AWxjq/ca//88vc3k0TxOiGPDa6YxgF/X58FzCaYj3kKLuUyJzyUMUkuM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0671;7:k9pHIj052GOSAZ37Ay8oek+e1o2ZCWSBOr1eKnBmqopyF38bWvIXWql6cu9lli8IgiGkbCsqlDI8h+EP9Mk/waPw5OCnDUYrreMgS+tidJXKKAAWrX3ECbkbSKe2HqE2tk6p1THI220wyWrMirSz14xRQIFOfZ+SJ4gTOblGPAEvQfBBMr8pTR1DzHf/qpBNbmHmbtrYKkdGsvvhXzE4FJmybSeIgq+74+H8n7j0bO3UUHNJYOpmG7XFCoZuVMqYOF4s2rMsjljdhpzWWh1dv+9N3IAcBdeRvnTrhIWzeHqZfpyHEEljgi68zMFoU4yCA2V2Vv42wBP58uudLTUj/EJ7nk5tqkFvCzmpmdhcA1fQXiL3oUBZurFHA1+0SKHMM5nv15UMLePnvOK/yPD0WZiVENbYPPx2oDOQQDXMriwuENJ+pm47HwVqkzTOgyqsS8poKbWvrwLXRKKvXzAg3g==;20:UvKaY1tLlY32N67QrpiZv/CfmAIp7PPKzY9nwc/YtFgFQ2o5H0Qk+prC88mr+poH1X93WYDIO9TSPQ6OKf3Tic3oS5Ds2z3ulkHZzPQ7fZoC8NitWlHMimy/UmKgYiEjjB+l9z1zBpCbembvWLNp90XhMx7NLvYrijs3muniFT786j3hq4PbaWhJYLd29OgPRDrcFNJ5kjNVZLVOlMZFrGQKK8CVW6+lo95BsxAz+WKr8Yo4t0M1x4PIBPENBzff X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2017 20:03:16.1862 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0671 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On 01/19/2017 12:21 PM, Greg KH wrote: > On Thu, Jan 19, 2017 at 01:07:50PM -0500, Brijesh Singh wrote: >> The CCP device (drivers/crypto/ccp/ccp.ko) is part of AMD Secure Processor, >> which is not dedicated solely to crypto. The AMD Secure Processor includes >> CCP and PSP (Platform Secure Processor) devices. >> >> This patch series moves the CCP device driver to the misc directory and >> creates a framework that allows functional component of the AMD Secure >> Processor to be initialized and handled appropriately. > > Why the misc directory? I don't see the justification here... > Since this driver is not solely for crypto purposes and do not fit in any of the standard categories hence I thought of moving it into misc directory. I am open to other suggestions unless Herbert is ok with leaving it into crypto and allowing the addition of the Secure Processor support. The patch series allows the CCP driver to support other Secure Processor functions, e.g Secure Encrypted Virtualization (SEV) key management. In past, I tried to add SEV support into existing CCP driver [1] but we quickly learned that CCP driver should be moved outside the crypto directory otherwise will end up adding non crypto code into drivers/crypto directory. Once this cleanup is accepted then I can work to add SEV support inside the CCP driver. [1] http://marc.info/?l=linux-kernel&m=147204118426151&w=2 -Brijesh