From: Yunsheng Lin <linyunsheng@huawei.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <davem@davemloft.net>, <f.fainelli@gmail.com>,
<huangdaode@hisilicon.com>, <xuwei5@hisilicon.com>,
<liguozhu@hisilicon.com>, <Yisen.Zhuang@huawei.com>,
<gabriele.paoloni@huawei.com>, <john.garry@huawei.com>,
<linuxarm@huawei.com>, <salil.mehta@huawei.com>,
<lipeng321@huawei.com>, <tremyfr@gmail.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH NET V7 1/2] net: phy: Add phy loopback support in net phy framework
Date: Thu, 29 Jun 2017 09:35:32 +0800 [thread overview]
Message-ID: <0445a290-50ae-98f4-f3ff-9e5520147f3d@huawei.com> (raw)
In-Reply-To: <20170628132750.GA12559@lunn.ch>
Hi, Andrew
On 2017/6/28 21:27, Andrew Lunn wrote:
> On Wed, Jun 28, 2017 at 05:13:10PM +0800, Lin Yun Sheng wrote:
>> This patch add set_loopback in phy_driver, which is used by MAC
>> driver to enable or disable phy loopback. it also add a generic
>> genphy_loopback function, which use BMCR loopback bit to enable
>> or disable loopback.
>>
>> Signed-off-by: Lin Yun Sheng <linyunsheng@huawei.com>
>
> Hi Lin
>
> It is normal to include my
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> when resubmitting a patch. The only time you drop such tags is when
> you make a big change.
Will do next time, thanks for reviewing.
Best Regards
Yunsheng Lin
next prev parent reply other threads:[~2017-06-29 1:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 9:13 [PATCH NET V7 0/2] Add loopback support in phy_driver and hns ethtool fix Lin Yun Sheng
2017-06-28 9:13 ` [PATCH NET V7 1/2] net: phy: Add phy loopback support in net phy framework Lin Yun Sheng
2017-06-28 13:27 ` Andrew Lunn
2017-06-29 1:35 ` Yunsheng Lin [this message]
2017-06-28 9:13 ` [PATCH NET V7 2/2] net: hns: Use phy_driver to setup Phy loopback Lin Yun Sheng
2017-06-29 18:14 ` [PATCH NET V7 0/2] Add loopback support in phy_driver and hns ethtool fix David Miller
2017-06-29 18:22 ` Andrew Lunn
2017-06-29 20:08 ` David Miller
2017-06-30 6:15 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0445a290-50ae-98f4-f3ff-9e5520147f3d@huawei.com \
--to=linyunsheng@huawei.com \
--cc=Yisen.Zhuang@huawei.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gabriele.paoloni@huawei.com \
--cc=huangdaode@hisilicon.com \
--cc=john.garry@huawei.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=tremyfr@gmail.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®