From: "Maíra Canal" <mcanal@igalia.com>
To: Maxime Ripard <maxime@cerno.tech>,
Maxime Ripard <mripard@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Daniel Vetter <daniel@ffwll.ch>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>
Cc: "David Gow" <davidgow@google.com>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Maíra Canal" <mcanal@igalia.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linaro-mm-sig@lists.linaro.org,
"Brendan Higgins" <brendan.higgins@linux.dev>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-media@vger.kernel.org
Subject: Re: [PATCH v3 04/20] drm/tests: helpers: Switch to EXPORT_SYMBOL_GPL
Date: Wed, 7 Dec 2022 10:59:08 -0300 [thread overview]
Message-ID: <04478451-4237-1aec-7edd-85049c96d7d5@igalia.com> (raw)
In-Reply-To: <20221123-rpi-kunit-tests-v3-4-4615a663a84a@cerno.tech>
On 12/1/22 12:11, Maxime Ripard wrote:
> drm_kunit_device_init() among other things will allocate a device and
> wrap around root_device_register. This function is exported with
> EXPORT_SYMBOL_GPL, so we can't really change the license.
>
> Fixes: 199557fab925 ("drm/tests: helpers: Add missing export")
> Suggested-by: Javier Martinez Canillas <javierm@redhat.com>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: Maíra Canal <mcanal@igalia.com>
Best Regards,
- Maíra Canal
> ---
> drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> index 9ed3cfc2ac03..4fe131141718 100644
> --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
> +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> @@ -82,7 +82,7 @@ struct drm_device *drm_kunit_device_init(struct kunit *test, u32 features, char
>
> return drm;
> }
> -EXPORT_SYMBOL(drm_kunit_device_init);
> +EXPORT_SYMBOL_GPL(drm_kunit_device_init);
>
> MODULE_AUTHOR("Maxime Ripard <maxime@cerno.tech>");
> MODULE_LICENSE("GPL");
>
next prev parent reply other threads:[~2022-12-07 13:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221123-rpi-kunit-tests-v3-0-4615a663a84a@cerno.tech>
[not found] ` <20221123-rpi-kunit-tests-v3-20-4615a663a84a@cerno.tech>
2022-12-07 13:55 ` [PATCH v3 20/20] Documentation: gpu: vc4: Add KUnit Tests Section Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v3-2-4615a663a84a@cerno.tech>
2022-12-07 13:57 ` [PATCH v3 02/20] drm/tests: Introduce a config option for the KUnit helpers Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v3-4-4615a663a84a@cerno.tech>
2022-12-07 13:59 ` Maíra Canal [this message]
[not found] ` <20221123-rpi-kunit-tests-v3-17-4615a663a84a@cerno.tech>
2022-12-07 14:08 ` [PATCH v3 17/20] drm/vc4: tests: Introduce a mocking infrastructure Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v3-19-4615a663a84a@cerno.tech>
2022-12-07 14:24 ` [PATCH v3 19/20] drm/vc4: tests: Add unit test suite for the PV muxing Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v3-18-4615a663a84a@cerno.tech>
2022-12-07 14:26 ` [PATCH v3 18/20] drm/vc4: tests: Fail the current test if we access a register Maíra Canal
2022-12-07 16:11 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04478451-4237-1aec-7edd-85049c96d7d5@igalia.com \
--to=mcanal@igalia.com \
--cc=airlied@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=daniel@ffwll.ch \
--cc=dave.stevenson@raspberrypi.com \
--cc=davidgow@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=kunit-dev@googlegroups.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®