mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Doug Anderson'" <dianders@chromium.org>,
	"'Tomasz Figa'" <t.figa@samsung.com>
Cc: "'Olof Johansson'" <olof@lixom.net>,
	"'Thomas Abraham'" <thomas.abraham@linaro.org>,
	"'Simon Glass'" <sjg@chromium.org>,
	"'Alim Akhtar'" <alim.akhtar@samsung.com>,
	"'Russell King'" <linux@arm.linux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: RE: [PATCH] ARM: exynos: Select PINCTRL_EXYNOS for exynos5
Date: Fri, 10 May 2013 08:29:40 +0900	[thread overview]
Message-ID: <044901ce4d0d$142a8e90$3c7fabb0$%kim@samsung.com> (raw)
In-Reply-To: <CAD=FV=X1XL++O43GBcJK5Js=ci8pfoj=uSADMcqq_jGJEvhXdQ@mail.gmail.com>

Doug Anderson wrote:
> 
> Tomasz / Olof,
> 
Hi Doug, Tomasz and Olof

> On Thu, May 9, 2013 at 2:45 AM, Tomasz Figa <t.figa@samsung.com> wrote:
> >> Nothing stops you from doing that on your own. I tend to push back
> >> onto the maintainers to get them engaged in their own housekeeping,
> >> but anyone is free to :)
> 
> I will probably leave this to the maintainers at this point...  ;)
> 


> >> Yeah, it should -- this is just in transition since 5440 was first out
> >> of the gate with pinctrl.
> >
> > AFAIK, Exynos5440 contains a completely different pin controller block,
> which
> > is not compatible with pinctrl-samsung driver, so I don't see any point
> of
> > moving it under PINCTRL_EXYNOS, which is currently used for Exynos 4210,
> 4x12
> > and 5250, but will be also extended with driver data for S5PV210 as
well.
> >
> > I'd say that CPU_EXYNOS4210, SOC_EXYNOS4212, SOC_EXYNOS4412 and
> SOC_EXYNOS5250
> > should select PINCTRL_EXYNOS and SOC_EXYNOS5440 should be left as is,
> > selecting PINCTRL_EXYNOS5440.
> 
> OK, sounds reasonable.  I didn't dig into all of the details of the
> 5440 pin control driver and don't have a user manual in front of me.
> I will do as you say.
> 
Tomasz is right. The current exynos pinctrl stuff is quite different with
exynos5440 pinctrl, it means there is no reason to move exynos5440 pinctrl
under exynos pinctrl. Of course, both can be built together without problem.

> New patch coming shortly.
> 
Thanks, the PINCTRL_EXYNOS can be moved into under SoC condition not board.

- Kukjin


  reply	other threads:[~2013-05-09 23:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-08 17:32 Doug Anderson
2013-05-08 18:19 ` Olof Johansson
2013-05-08 18:48   ` Doug Anderson
2013-05-08 19:33     ` Olof Johansson
2013-05-09  9:45       ` Tomasz Figa
2013-05-09 18:11         ` Doug Anderson
2013-05-09 23:29           ` Kukjin Kim [this message]
2013-05-08 18:52 ` [PATCH v2] ARM: exynos: Select PINCTRL_EXYNOS for exynos4/5 at arch level Doug Anderson
2013-05-09 18:12   ` [PATCH v3] ARM: exynos: Select PINCTRL_EXYNOS for exynos4/5 at chip level Doug Anderson
2013-05-14 12:07     ` Linus Walleij
2013-05-14 12:25       ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='044901ce4d0d$142a8e90$3c7fabb0$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=dianders@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=olof@lixom.net \
    --cc=sjg@chromium.org \
    --cc=t.figa@samsung.com \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®