From: Daniel Borkmann <daniel@iogearbox.net>
To: Jiayuan Chen <jiayuan.chen@linux.dev>,
bpf@vger.kernel.org, memxor@gmail.com
Cc: Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
Alexei Starovoitov <ast@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Jiri Olsa <jolsa@kernel.org>,
Emil Tsalapatis <emil@etsalapatis.com>,
Shuah Khan <shuah@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Mykyta Yatsenko <yatsenko@meta.com>,
Taegu Ha <hataegu0826@gmail.com>,
Amery Hung <ameryhung@gmail.com>,
Paul Chaignon <paul.chaignon@gmail.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH net-next v1] selftests/bpf: Fix insn count expectations in chained global subprogs test
Date: Thu, 13 Aug 2026 21:50:05 +0200 [thread overview]
Message-ID: <04493cfc-98a6-418b-8d8a-8f85688aca1b@iogearbox.net> (raw)
In-Reply-To: <20260813051635.121670-1-jiayuan.chen@linux.dev>
On 8/13/26 7:16 AM, Jiayuan Chen wrote:
> The test asserts exact per-subprog insns_self/insns_total values and the
> aggregate processed count, but these depend on compiler codegen. The
> expected values match -mcpu=v3 output; under -mcpu=v4 clang emits a
> sign-extending load in global_good() instead of a load plus two shifts,
> so the subprog is verified in 3 insns instead of 5 and the test fails on
> the cpuv4 flavor.
>
> Rewrite the involved subprogs as naked functions with hand-written
> instruction sequences using only v1 instructions, so the verified insn
> counts no longer depend on cpu version or compiler codegen.
>
> Fixes: c2e6c7de8830 ("bpf: Show more useful info in stack depth stats")
> Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev>
$subj should have been bpf-next to route to BPF CI.
Anyway, it was fixed in the tree via:
9786d424a36b ("selftests/bpf: Fix chained_global_func_calls_success() for cpu v4for-next")
Thanks,
Daniel
prev parent reply other threads:[~2026-08-13 19:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 5:16 Jiayuan Chen
2026-08-13 19:50 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04493cfc-98a6-418b-8d8a-8f85688aca1b@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=hataegu0826@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=jiayuan.chen@linux.dev \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=paul.chaignon@gmail.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yatsenko@meta.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®