From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 267D43AB5B2 for ; Fri, 19 Jun 2026 15:12:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781881968; cv=none; b=lLUn38WNlZ73wN5rkgQ4ZQokK5p7CaoKzEZ0RAnQpJZfC+tlJOd+1T84ufpnL0BfcA/Dqhj1g9bGSMCLPQbzRRUUHN4iZGfOc1ttkN7ZBtcXzqzZTYmKjvsUDl5i953124COco0tGYPnisp3NFgm0921jNDQpncHn77UyV0qT3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781881968; c=relaxed/simple; bh=GRj1sgqzYGCEgcL3nAikH53kEMjykGRo6DuvwrkeGHw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jxq//R9XlX6Fas+7gvWFIeH0RurM39KKvLOlNvQbI5LbQV+FmVheZpRFcXSG5S3iC4MPCXTfJ+nkVQqAfrxp00w4wqJIwkZfbb6DO9d8LbKY2KtoZEruyC1fFVXH4dB0+ERg2A/f6p9JepoBujJzZZT7SXe3ZxD1p4fzmMo8NN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YEqPUls8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=a6/20cwe; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YEqPUls8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="a6/20cwe" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65JDCKQl746395 for ; Fri, 19 Jun 2026 15:12:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= h7yHqNvHf7zsxMoKY4S/aHvIz1bHIGx2ls9sOtVtBQE=; b=YEqPUls8augKfigE aqLZFa2egqWqhqKUNoRWF9aU8/R+a6S1y8pX9bWShu5UAFWtG0b8Wb6fNjfhPYIp dVqbm4bA8l7Os0XSZx9TmhNoES6pZwe/SkYUGe0Q7PVrOeHZmLRn2vbn9h72z+ZZ O08j+NYonIwsw5yYlAY7sZCMSb7+rQIbdlGthqJqmOVXIkgAS5Q/cYOKJCfZUWx2 PBQPef2J3RVxNnChf1Q0US+07rO5PeL5eRi7KGTuSAlD5lJCeOKax5p6sp1dGYT4 wyJ43C4uzcUTU8h7Ts6BxKz99Jel+C9XLDg0N2d2mHHacVaBaostBnstVW7tNcgA akcPXw== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4evp6sbsdk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Jun 2026 15:12:45 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-7265c1b71f6so127904137.0 for ; Fri, 19 Jun 2026 08:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781881964; x=1782486764; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=h7yHqNvHf7zsxMoKY4S/aHvIz1bHIGx2ls9sOtVtBQE=; b=a6/20cwe+P8G1Sr6ZhggdCZbIdjBqNsq3qGR/2wdDWlWLUlvqbdIqtZqeF5tuXO5QS cNVSfZDenzm9c3+hUL1ocbWTyH1HHO2Urm2x+dlYKfYLYdiqqJnxuDXyWzyX+4mrHW96 eg3TiK55d/cOq6SKF1FzvhSUcdPgN4+3T3iKEKQ4iKA3kCcLjTOeNFKQt6B7WMugclAc 9G3alnkVXEMF5uZ48zGA7vyzPQ2Stf0TxbnZrUJ3Z7djvjWqfdqDLBggWcBUH/VfZZlV xhEEBWncmSaMw6+py0CfWHwuAMEN13B4QQLS/ccP+15Y8A6fdM22sbk/I9S9BqEAGqJc ys3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781881964; x=1782486764; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=h7yHqNvHf7zsxMoKY4S/aHvIz1bHIGx2ls9sOtVtBQE=; b=nWxXrlAK4wO4/jKD0INTuKWfgi9Zsb0gcNszrHLUmOKnmtSjmeg92enDgIYxQAwNCe cr2BLLbfKcZEPLAiy3nEcpxunVjEYBxKXWOByLlwYyX/jXmwzZmwQGBHIQ0wD3WWrWM7 WqZLwHeCyGP6EwKeL9Qx0zz37ubiKMfF7EaWxnl9AU1XuRRO0Oh+jB0/BhFO1BeY7B5W iL1taJjA3Sk9c0Uzl01uaKtIIH0OD9NvNgitn1bm2lk402v+WePHgpWS6Pr1wj963Qki 9lea/rlLiwbNacftlu+G5gZr/P1QgPu/OhoO+6bYPVx/zTXT64uMi9uBcJ/Kpl8X1BLY O4EQ== X-Forwarded-Encrypted: i=1; AFNElJ8G22a7zF6ooqyzfifc7NXMGuup/onn20B5xpjIPd7PywSwpnibuyY6wYx+rLsDNgYYQosRj68BDyiP8ag=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5MYKzQ73wS4Mdk3lt7F+85gqD502v76t5YQ8ww/BrVIZGijdC 1ojZmzX2etoMGON5TB7/6Meios7wWTnavxHqPzFM5/MH6U/sHcxSYJFBbHL+4zIZ7vhYWSdsUBR GDmNshrLemZXXkJkS9CC7NhTLCPpG+mnsVNppSZe3gmBDjBE8RtXWVx3u77/krXXLUSkYhCQf4e c= X-Gm-Gg: AfdE7cmhM9hXBhlTO2lNpGESjvtEmGExYP4+i9eN2dGA1Hasgc0lwM5pVqE8SqxsGuV +K1RBmxWHs1kR+x5IUv3B7bu+tEiCoAnmkanZyMT98ouTzVvXs55im5b5EKSkX1j6ZwASvy3+vJ I3sC1RsedCkIxrucOg7KLKSMTYZcixBTbDFJG8b99c5eCoDUopF2ywCSKnuZ9i0BEWPFpoOH3ct DKdoXZ2jiPSPdDvcTwtlEwoSWMpPT7v3YU/dBoqhmfRNqF7e4QBwwwH5QGtjFiPcJxESpc0TCJ9 z/3v3v1zh+e/x0v+CKcC+mCs/vk2G+OA6HdyijwLSVkUyBux/hJA9ZzPomuxwIoTLb5s+MpkbOp ZNKDUC28XM3gzWSvXfZAiktBRJB4+4415/hA= X-Received: by 2002:a05:6102:a4d:b0:633:7c8:37aa with SMTP id ada2fe7eead31-72a010296bbmr1121393137.2.1781881964382; Fri, 19 Jun 2026 08:12:44 -0700 (PDT) X-Received: by 2002:a05:6102:a4d:b0:633:7c8:37aa with SMTP id ada2fe7eead31-72a010296bbmr1121367137.2.1781881963829; Fri, 19 Jun 2026 08:12:43 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-696fbcbb9d8sm946703a12.13.2026.06.19.08.12.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2026 08:12:42 -0700 (PDT) Message-ID: <044c0fa3-4793-4907-9058-347263511232@oss.qualcomm.com> Date: Fri, 19 Jun 2026 17:12:40 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for Shikra To: Dmitry Baryshkov Cc: Krishna Kurapati , Krzysztof Kozlowski , Neil Armstrong , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Xiangxu Yin , Johan Hovold , Loic Poulain , Kathiravan Thirumoorthy , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <29571bdd-23bf-42a7-a9e3-918a28c79700@kernel.org> <62161822-2365-4ec7-80f7-8660bdadb177@oss.qualcomm.com> <40b5e0f6-bc61-4750-9560-bdcc268f0fe3@kernel.org> <5baeeeed-7c18-46f7-82a3-5bb299ba05ef@kernel.org> <42ba6ac7-306a-419f-96b6-3427c51ef567@oss.qualcomm.com> <9ed7c714-07c1-48de-8d27-cbe24356c606@kernel.org> <34586ed6-4f78-490f-a916-baf7657cca7a@oss.qualcomm.com> <0947e485-4619-43a3-a127-5b887780190b@oss.qualcomm.com> <5vfu3h66pelbhzyfqnagxg2j6r5mn7jupx3nmewt2zsggfa6sj@ttqr775cybxa> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <5vfu3h66pelbhzyfqnagxg2j6r5mn7jupx3nmewt2zsggfa6sj@ttqr775cybxa> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: HdbF0kwGhxqgzVpVxZnZIya0nTbCks0K X-Proofpoint-ORIG-GUID: HdbF0kwGhxqgzVpVxZnZIya0nTbCks0K X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE5MDE0NCBTYWx0ZWRfX4MawlgNyEOrw eb0hEi+Qd4Xhe+JAQttuWQ3vHhdo9J+x4LiL1xXfjIuHbdxu5Td87qDDpGsAG5vJqW7X+o79/XV AusOuR09QqfC9sx77FyZFRfDcbqBKaZvLurQ7rwxhyK1XwqrjkDU3brMktCuv0EF0vuezCMpRBg B9ZVaTUlTa+G22wmU7PtiMdcZrMz8RJc1vUG3lmmf1B0DmK15gI7EPRPJnCm/wfGwlxQpCbj1oq AkvCysPkZDCb08RNwhoBGa/47Ae27rRoS2mli/K2FP97J/57QL4OL5EZGJniVD6w9rYs4/OFYKW f/6Kp14oMy5hVOobW6LVvxDu5d/eSZHJ5FYqzgp/7inoUtSSRNWQrdM23QelEKHxhwNfYDByhE0 ExYeJYAUZ0BoDSOVvC8fZWrxKUGRhCTRslek4fStIPEHZz8tdHsCKunwBRfu95CnNvzcXVvOJxC TiXlimI+26EjO2nw9ag== X-Authority-Analysis: v=2.4 cv=H6LrBeYi c=1 sm=1 tr=0 ts=6a355c6d cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=OOGWXGrbggnT5pNHG1IA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE5MDE0NCBTYWx0ZWRfXzC/EvJMtxZe5 Nt3r3muLy6JGRSC2M5jSPmvk+4Nb1iCxVPzJPfBSsqJcAoWESsNp3jUCERZT8GM2bWKjbWjilO1 BQZfk/6hnu+MqmqbFwRiw6vzo6soM98= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-19_03,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 suspectscore=0 malwarescore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606190144 On 6/12/26 10:00 AM, Dmitry Baryshkov wrote: > On Wed, Jun 10, 2026 at 03:36:20PM +0200, Konrad Dybcio wrote: >> On 5/17/26 9:16 PM, Dmitry Baryshkov wrote: >>> On Fri, May 15, 2026 at 09:06:21PM +0530, Krishna Kurapati wrote: >>>> >>>> >>>> On 5/14/2026 8:07 PM, Krzysztof Kozlowski wrote: >>>>> On 14/05/2026 08:22, Krishna Kurapati wrote: >>>>>> >>>>>> >>>>>> On 5/14/2026 12:26 AM, Krzysztof Kozlowski wrote: >>>>>>> On 07/05/2026 13:37, Krishna Kurapati wrote: >>>>>>>> >>>>>>>> >>>>>>>> On 5/5/2026 7:30 PM, Krzysztof Kozlowski wrote: >>>>>>>>> On 05/05/2026 15:57, Krishna Kurapati wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On 5/5/2026 6:59 PM, Krzysztof Kozlowski wrote: >>>>>>>>>>> On 05/05/2026 15:27, Krishna Kurapati wrote: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On 5/5/2026 4:22 PM, Krzysztof Kozlowski wrote: >>>>>>>>>>>>> On 05/05/2026 12:49, Krzysztof Kozlowski wrote: >>>>>>>>>>>>>> On Mon, May 04, 2026 at 10:36:57PM +0530, Krishna Kurapati wrote: >>>>>>>>>>>>>>> Declare the USB-C QMP PHY present on the Qualcomm Shikra platform. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Signed-off-by: Krishna Kurapati >>>>>>>>>>>>>>> --- >>>>>>>>>>>>>>> .../devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml | 2 ++ >>>>>>>>>>>>>>> 1 file changed, 2 insertions(+) >>>>>>>>>>>>>> >>>>>>>>>>>>>> Reviewed-by: Krzysztof Kozlowski >>>>>>>>>>>>> >>>>>>>>>>>>> ... and then I looked at the driver. So un-reviewed. Devices are clearly >>>>>>>>>>>>> compatible. If not, explain what is not compatible. >>>>>>>>>>>>> >>>>>>>>>>>> Talos uses GCC_USB3_PRIM_PHY_AUX_CLK. >>>>>>>>>>>> >>>>>>>>>>>> In Shikra, we are using GCC_USB3_PRIM_PHY_COM_AUX_CLK. We don't have >>>>>>>>>>>> GCC_USB3_PRIM_PHY_AUX_CLK. >>>>>>>>>>>> >>>>>>>>>>>> Hence, I didn't use a fallback compatible. >>>>>>>>>>> >>>>>>>>>>> This still explains nothing. How different clock makes interface for SW >>>>>>>>>>> incompatible exactly? >>>>>>>>>>> >>>>>>>>>> So I went by the naming. AUX vs COM_AUX. >>>>>>>>> >>>>>>>>> The naming does not matter. If the clock is called >>>>>>>>> "no_one_expects_spanish_inquisition", does that make software >>>>>>>>> incompatible? Why would the name itself matter? >>>>>>>>> >>>>>>>>>> >>>>>>>>>> Can I use a fallback compatible and in DT vote for "COM_AUX" clock with >>>>>>>>>> clock-names mentioning "aux" ? >>>>>>>>> >>>>>>>>> I don't know, I asked what is different in software interface. >>>>>>>>> >>>>>>>> >>>>>>>> Hi Krzysztof, >>>>>>>> >>>>>>>> I checked with the hw team here and found out two things. >>>>>>>> >>>>>>>> 1. Shikra is a spinoff of Agatti and its sw interface (clocks used and >>>>>>>> regulators used) is the same as agatti. >>>>>>>> >>>>>>>> 2. I thought we could use qcm2290 as a fallback since the phy register >>>>>>>> init sequence is the same for Talos/Shikra/Agatti. The difference >>>>>>>> between Talos and agatti when checked in the driver was the init load >>>>>>>> settings. I checked with the hw team and they suggested using the init >>>>>>>> load settings which talos was using. >>>>>>>> >>>>>>>> Hence both these compatibles (qcm2290 and qcs615) cannot be used as >>>>>>>> fallback for Shikra. >>>>>>> >>>>>>> Then I do not understand why you are using qcs615_usb3phy_cfg for >>>>>>> Shikra. You say that the initialization is different, but you use >>>>>>> exactly the same initialization. So in a meaning of compatibility >>>>>>> between hardware for Devicetree they are compatible. >>>>>>> >>>>>> Hi Krzysztof, >>>>>> >>>>>> There are 3 things: >>>>>> >>>>>> 1. Clocks used: >>>>>> -> Talos supports AUX Clock since it supports DP over USB. >>>>>> -> Agatti and Shikra use COM_AUX clock since they dont support DP over USB. >>>>>> >>>>>> 2. Phy register Init sequence - same for all 3 targets >>>>>> >>>>>> 3. Regulator init load: >>>>>> -> Different for both Talos and Agatti >>>>>> -> Recommendation is to use Talos regulator load values. >>>>>> >>>>>> SW interface wise, shikra is comaptible with agatti. If we use agatti as >>>>>> fallback, we would end up using the platform data of Agatti where the >>>>>> regulator init load is not suitable for Shikra. Hence not using Agatti >>>>>> as fallback. >>>>>> >>>>>> Coming to driver changes, I used qcs615_cfg because it has required phy >>>>>> register sequence and regulator init load as needed by shikra. >>>>> >>>>> So is it compatible with QCS615? If not, then something is incomplete or >>>>> confusing. The driver uses the same software interface. >>>>> >>>> Sorry for the confusion. The Talos compatible represents the USB/DP PHY with >>>> aux clock input, while Shikra is a USB-only PHY with com_aux input clock, so >>>> the two PHYs are not compatible with each other. >>> >>> According to the memory map, there is an (unused) DP registers part >>> right after the QMP USB3 PHY. So, sofware-wise it is compatible to >>> Talos. Having the different clock input means different integration of >>> the block rather than the differences in the hardware block. >>> >>> So, the block should be compatible to qcom,qcs615-qmp-usb3-dp-phy >> >> It should still carry its own compatible though, to let the driver >> disallow powering up the DP part > > Why? The DP part is there, in the PHY, pretty much like it's present on > most of USBC platforms. I assume it can be powered on. There is no > point in it though as there is no DP controller (nor DP pins). I wouldn't bet too much on that sub-block being fully silicon-validated given its of no use as there isn't a DPTX onboard.. Konrad