From: Greg Ungerer <gerg@linux-m68k.org>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
kernel test robot <lkp@intel.com>,
Henning Colliander <henning.colliander@evidente.se>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Jimmy Assarsson <extja@kvaser.com>,
Christer Beskow <chbe@kvaser.com>
Subject: Re: drivers/net/can/kvaser_pciefd.c:801:17: sparse: sparse: cast removes address space '<asn:2>' of expression
Date: Mon, 15 Jun 2020 17:07:13 +1000 [thread overview]
Message-ID: <044ff868-00f1-90a4-25e6-9f62f7a042ad@linux-m68k.org> (raw)
In-Reply-To: <20200612163509.6ieqxm4peqcfgd7o@ltop.local>
On 13/6/20 2:35 am, Luc Van Oostenryck wrote:
> On Sat, Jun 13, 2020 at 01:33:16AM +1000, Greg Ungerer wrote:
>>>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>>
>> This one I am not sure about yet.
>> Still investigating.
>
> swab32(__raw_readl(addr)) ?
>
> Keeping __le32_to_cpu() will only force you to use ugly casts for no benefits
> and the comment above explain clearly the situation about the endianness.
That is unfortunate, the use of le32_to_cpu() made it very clear
what was going on - for those that don't choose to read comments.
In any case that would seem to be the cleanest solution.
Patch to follow.
Regards
Greg
prev parent reply other threads:[~2020-06-15 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 5:28 kernel test robot
2020-06-12 7:48 ` Marc Kleine-Budde
2020-06-12 15:33 ` Greg Ungerer
2020-06-12 16:35 ` Luc Van Oostenryck
2020-06-13 2:19 ` Greg Ungerer
2020-06-15 7:07 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=044ff868-00f1-90a4-25e6-9f62f7a042ad@linux-m68k.org \
--to=gerg@linux-m68k.org \
--cc=chbe@kvaser.com \
--cc=extja@kvaser.com \
--cc=henning.colliander@evidente.se \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=luc.vanoostenryck@gmail.com \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®