From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CA04EB64DC for ; Mon, 17 Jul 2023 08:15:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231298AbjGQIPl (ORCPT ); Mon, 17 Jul 2023 04:15:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230496AbjGQIPi (ORCPT ); Mon, 17 Jul 2023 04:15:38 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B4A3136 for ; Mon, 17 Jul 2023 01:15:37 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4fb7b2e3dacso6562537e87.0 for ; Mon, 17 Jul 2023 01:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689581735; x=1692173735; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AxftnQ3CNTrVOjYH5VYYCvLOpYPsnqVN2ihvqFHedaY=; b=OaVyt1x/nakusfj9bPvL0EcjR/vJkisACkK7ke8H60mvPHsrvxgoGQ8bdW/Lx5uHth gtM8yXWDIjieGQYIHC4esKxgVf/2Hc+Qeyy0+T0kF6FKWgfmA2niCjj0l7wzQ8GCalfu 8V5/sPuLDMmZxgIVo+n4tvdDXLHEV9dsUWUOGN80egP+FK5f8+rctieFRPq2JJclgdT8 +SxnIKYiEPXDso4Qsp5WAKUwPmL+J25e83BGsfZg9uqyMWFfx6+spg7NMVzeJJxMncbl 9zTltd/XjzlF3MfHZbyF4N2mDdLYoJJls7JY+a/3l/I0Uh5YKglHiQ4ZRerCnmaey/Du yjIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689581735; x=1692173735; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AxftnQ3CNTrVOjYH5VYYCvLOpYPsnqVN2ihvqFHedaY=; b=WgfcjIwdzTsrypULYuBspTZs2IPsvHeYfLj98Yk5RT378HYuzXIerOXP2NoLMWO4nj illfl7o2N0F1zTGTPSD11uJyZxZimdeMOsPXaZUUnTmCuV87nWsAMfQFIMdZJxPJHn92 dHWgGR+bXM/FrsaP4VwABSoicIo7Kri++iWT7LSqx9BK4RSUqGpViCaJXNfNz6hHcETS ZSvC93zJDuYu7pC3/YwA0rAl2n+YzE5jVzjDPH8KXtPlpINQW8vCmQHG9zAv0T2s1x1p AHnPXW3Ek3VnsCNU46vBacWEJNcZzctxDwiG1NiPwHFothFJtB3lh+0Gm18jSyqfjsf2 cKYw== X-Gm-Message-State: ABy/qLZl6pCcHy9N43w6TVloE4xMiy1rvboOfeMEPD6xDi5ReDlc6NxR 4/rQd0csS7Qr4OCdpClxddI4giwdPTHTcqwFslA= X-Google-Smtp-Source: APBJJlHTmB2ZXqSG2Z7ZQZs43rQgaUnAYkwbYO1fUQdKuwiQICnK30oLhvBIZeIvvQfOxDto3Ng5Sw== X-Received: by 2002:ac2:4da3:0:b0:4f8:6e52:68ae with SMTP id h3-20020ac24da3000000b004f86e5268aemr6790640lfe.31.1689581735260; Mon, 17 Jul 2023 01:15:35 -0700 (PDT) Received: from [192.168.69.115] ([176.176.144.39]) by smtp.gmail.com with ESMTPSA id e14-20020a5d65ce000000b0031437ec7ec1sm18700656wrw.2.2023.07.17.01.15.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jul 2023 01:15:34 -0700 (PDT) Message-ID: <045467d8-1122-b1d3-07b6-bddd92bfa9b3@linaro.org> Date: Mon, 17 Jul 2023 10:15:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] soc: bcm: Explicitly include correct DT includes Content-Language: en-US To: Rob Herring , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Florian Fainelli , Broadcom internal kernel review list Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230714175130.4067236-1-robh@kernel.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230714175130.4067236-1-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 14/7/23 19:51, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. "before it was"? > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring > --- > drivers/soc/bcm/bcm63xx/bcm-pmb.c | 1 - > drivers/soc/bcm/bcm63xx/bcm63xx-power.c | 1 - > 2 files changed, 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé