From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C405C3019CB for ; Wed, 10 Sep 2025 09:40:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757497238; cv=none; b=h8Q3B0HCruDDs07TZWwnHeVBaJhG/ideFCIdpD8L6BrEEShWGVxVAWGlYfTVZUlMvtkgqFalxQvqcWewq7hOfzPkaef/Akp6pj/QHc02y9+m1bn9TzE8kDbZZ2HBY4zox60sSgEDZaIXTTk1CMd4qIioQHZNoWCgjauYhIwQVgo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757497238; c=relaxed/simple; bh=PMrygF5tQEBETNNlK2TURt60yHgbiNe7/3/KcHUD8tk=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=l/ydZ2Ie2gNNu+sU6y908cKEKDdhYlxOuv+5Zkb/Yn7kDBLJlLwsnXc7I/Yda20UvwOvksJvjb7ubLvTmGCkFhT9+ymJEhwWJHPGcMFQr2DGUkVvPwMXEpy6iyjpJoXZ0H1I6SHruFBt3RwwZ+0QfJI1SCXVVCjnCi5r9twYRTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nSLTTmZn; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nSLTTmZn" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58A9730e000839 for ; Wed, 10 Sep 2025 09:40:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2Gclb0Ihbq4U0dzyWeLi7fsQ8/l2l+bvwlN9BvdXuZ0=; b=nSLTTmZnKr6ScU92 Fyb392PZn7uFi1XNswYjKJ12/rbtN2iAb4OajNPKN0JJJpB8uJi1eJMPeX4greiE 9sZ5s48WLAUzk+c1QSV2NBPzOGVgcNfQ8zB1t3h8y3dMfbZzQnQbNBl2MH1L9Cz2 G54kAIe6rivYEbIG/WWRs0vd9NSB/x/3fQWPIOfGMEkNiYMI+kXJNLAd09B4AvWg DWjSR1c105Kx7ziFCn6LAPfgdGYLY664rK7gONlhwPZ7mZZOrTMQael2gSyPlNFm s9A7krBD1swlKPefKWiUV4bf298daJlUjKy4kopPyzK+pDl1/UORNLNYhmZWBJA5 1RiLow== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 490c9jbg4y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 10 Sep 2025 09:40:35 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-329ccb59ef6so7621788a91.0 for ; Wed, 10 Sep 2025 02:40:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757497234; x=1758102034; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2Gclb0Ihbq4U0dzyWeLi7fsQ8/l2l+bvwlN9BvdXuZ0=; b=B6HZACIpg7W+OIWemiWltx6XkkHZhpXSqb30hVmmZooHATiOTfiu4hYsWWiqDm7vho X7IvY8VVG2J693NVLnlAxWEdJcOXnWBeN7pv20YHwfvzx8p1td9irICOI9d3hDDbMYP3 uH7bHlSMbqU3OEh4Zs+qfJliCCmA6w2d8wYL29mzG5kbHeIeYmgkIIf8adm1zhlD2zvS JfccOKZZ6NuwxQxkHfRD/+eRcTd70iUjlpMMG8wIrrB2iPVEkRyS+LTLcz5pokWSiciv h3MgtkmGpttqJOdWxo/rKGc72902D/lF7Q1/mxY2lzZ7yOvT7hh+SiztU2c5+b25bnjH 7HyA== X-Forwarded-Encrypted: i=1; AJvYcCWhvrRJqIB7Mg6xOJEG4KlxFWCURkw0DrsuaoD+Ep4Q7SMTZmODzSsznSVRs7mI9/9bcXLYoWxvtYuJ7uU=@vger.kernel.org X-Gm-Message-State: AOJu0YxQZhBxcKKDw3wxjWrrhd2XwwzLSPHK4sAVS8IJg55CFwbUXdD6 jt+HQUFMSbtdbL7kHLdpiycF+RQilzWAVkl91m4K5LR99WipFZaTAydmREylmVywRUPsVi84dKM 1X30Mvxquy7N4IP1U1Q/3z6Ju/ymrCp9ADYY4WrZzxa/Vm/BTMgA0sg3vig+zkuiLAW4= X-Gm-Gg: ASbGncvigUVxP8lHg5BaiDQE5tw8slDSQoeoa9VR03FgfR/HYQa9xlV9TAzlTgOTaxS iUL0xRgCpiviIEMl7XkPd0pLgPZOYokTiXGDCs+Gwjq1s0AHS+Wen3pNykxUGdiq5NN7zDUQ9pd MN6vsgFIS+6vyVCkxIMcV2n9yvzE8hLOeEF5QJ6MBGWefTuwuqWyreWCpjjB5M1+hiszmqxK5RJ f1CeotUM+KyL7mnQl+aF4GQEV7iBp/jh+a7pCbnZu9O3PgDnK1jG1vbRJgWOUjsZ7h45CHBG4Y4 cJqts9CBFgSSqpJjuEjgAx34vjEjUvP5RuJoSOnX4TCkJoSUitPQDlmBRzvHnFgc21MvQ/6fR63 Q9A== X-Received: by 2002:a17:90b:4e83:b0:32b:9774:d340 with SMTP id 98e67ed59e1d1-32d43fb9041mr20757083a91.33.1757497233998; Wed, 10 Sep 2025 02:40:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHaecEzrQFrPqSdW4dQERZAIFQpKAkVm5A9reVkG5A2GgX835tsdd4acUFKiggHGiBsSO6+GQ== X-Received: by 2002:a17:90b:4e83:b0:32b:9774:d340 with SMTP id 98e67ed59e1d1-32d43fb9041mr20757048a91.33.1757497233496; Wed, 10 Sep 2025 02:40:33 -0700 (PDT) Received: from [10.92.178.42] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-32dbb35576esm1832190a91.16.2025.09.10.02.40.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Sep 2025 02:40:33 -0700 (PDT) Message-ID: <04554d6c-132d-4f3b-9284-4b54d5047805@oss.qualcomm.com> Date: Wed, 10 Sep 2025 15:10:27 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] ASoC: dt-bindings: qcom,sm8250: Add QCS8300 sound card From: Mohammad Rafi Shaik To: Krzysztof Kozlowski , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai Cc: linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@oss.qualcomm.com, prasad.kumpatla@oss.qualcomm.com, ajay.nandam@oss.qualcomm.com References: <20250905142647.2566951-1-mohammad.rafi.shaik@oss.qualcomm.com> <20250905142647.2566951-2-mohammad.rafi.shaik@oss.qualcomm.com> <43090acb-ea36-4015-b14f-78d44d789d42@kernel.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTA2MDAyMiBTYWx0ZWRfX2dL4++jAYTBo cc91ydzQl6q+sUZQRyP7AA7NKvFX6OJenOfPnjzbQBdV1nAoejFsD2Lq3Mr6zw8oh6POtn4dIEz +AEiD2Mur3eXbZn7XsCnPpKflpurkYnTu4G0v+iF+YE94s4/EK+7y6jrzJu/OKN/uLNJiMsPc9m RkoakYwmgP1UplP+RQ2wAkqv27rL6vJS5QmXog9XEu4CKFSuzgiSmyx209X42YY752mXmyIScrM LqS3VbHtyLWPIAjj71c3VPCTISVySRlU6DPR8hKX70LVjJT7W1dUL86fexITQF4SGo1IZl8KYSh 2IiuYlPk1HX/FFQEjVYFoxuieaAMuW7wF5PHcAP/iC/cKOD4bXMOeQK9bd7YdsAe6VKh+0igI2g vlx0Y3Ix X-Proofpoint-ORIG-GUID: 3lscMK1FVY3_k_7ZKX0xJlMAJShDvczz X-Authority-Analysis: v=2.4 cv=PpOTbxM3 c=1 sm=1 tr=0 ts=68c14793 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ExpgeREpyeptk5CJGqkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: 3lscMK1FVY3_k_7ZKX0xJlMAJShDvczz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-09_03,2025-09-10_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 spamscore=0 bulkscore=0 clxscore=1015 malwarescore=0 adultscore=0 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509060022 On 9/10/2025 1:35 PM, Mohammad Rafi Shaik wrote: > > > On 9/10/2025 1:09 PM, Krzysztof Kozlowski wrote: >> On 10/09/2025 09:26, Krzysztof Kozlowski wrote: >>>> diff --git a/Documentation/devicetree/bindings/sound/ >>>> qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/ >>>> qcom,sm8250.yaml >>>> index 8ac91625dce5..eebf80c1d79a 100644 >>>> --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml >>>> +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml >>>> @@ -35,6 +35,7 @@ properties: >>>>             - qcom,qcm6490-idp-sndcard >>>>             - qcom,qcs6490-rb3gen2-sndcard >>>>             - qcom,qcs8275-sndcard >>> >>> So what is the point of this compatible? There is no user of it and I >>> think you added QCS8275 for this case exactly... >>> >>> Shall I start reverting commits from Qualcomm because you post patches >>> "just in case" and turns out they are completely not needed? No single >>> user of such code? >> >> >> @Mark, >> >> In case it wasn't obvious, please do not merge the patch till we get >> some clarification. For sure it is wrong one way or another: either >> incomplete or just duplicated. >> > > The device tree currently uses qcs8275 as the sound compatible, and > the corresponding Device tree changes have already been applied and merged. > > Reverting this now would break the ABI. > > A new device tree patch with qcs8300 is currently under review: > > https://lore.kernel.org/linux-arm-msm/20250910044512.1369640-1- > mohammad.rafi.shaik@oss.qualcomm.com/ > > Once the machine driver and device tree patch with qcs8300 are accepted > and merged, > > I will promptly submit a cleanup patch to remove of discontinued > compatibles from the machine driver. If the above explanation is acceptable, please help with approvals. I will submit the cleanup patch to remove discontinued compatibles,once the qcs8300 support added in driver and device tree considering ABI should not break. Thanks & Regards, Rafi. > >> Best regards, >> Krzysztof >