From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40419220F46 for ; Wed, 21 May 2025 14:52:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747839171; cv=none; b=UaDQT+UEnd+QIjRpzPFekAO+M3LdxypP7xDkxysJ9lnDDu88Z3oKICptBcOGujtJYD+/IYNdkQlYCdOyvUzfZpUYp9Zr5EoK/+dhh9Tudk73GeCTU/Jvl0HtjTJQBD8P8jwr0Bmj1AvQITYoYAoUVax6Y74ds7l1O0FdNEFgq/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747839171; c=relaxed/simple; bh=aNzroqIxURgqE3w48N8JYf0Tg2XM1K6UlHLDOl3M1i0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GIDMOk1NuxPF/qLF9vYvsg0qUboLZkZhWmElFgX38a+Yh9CxESFSLjA9swtW6FoZK2NfsAwCmEmZgO/rGLgzoFl/bZiWuDLFfbRzcf+UQRKuLYj+jiayio1U3Pzoo2GYvlpYqNo5/0867xEbJ94f6F57JKQ1GpKaM9vC4Be0/uE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XpZJc3Nk; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XpZJc3Nk" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54L9XMJ5000805 for ; Wed, 21 May 2025 14:52:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= u4Zvv4Lve36XriRiQpKqbCb+vrtuRWZbxGxM5SWigA4=; b=XpZJc3NkPQt8OtDT GLE+y7ZeRuA01WtsNGl6DONfKQuKvfC4im+3olz3RgzjKmCzFR/EOvQknYo0VMML S3KNpxtOaXqX4IfdUUlqBuaily69GBZT2haLwjm0FRxUdSl2okPbsm7QcYv3DIdG 8rdLQdI8mUfq3VwYpJ40Ly+FcJqRX8cJr1SzMiV5a+15Gb7tX2SV1IoHnB5yRvmt HpZt+ZT+NMhq/Dmhw8PtqDKIbGdiuHaGu+v6HklTUocnJEcqsH10XRN/WTPj4Ztr df+dA+ORoGr9wW43cROAHBia/duLMc27GItA66o5/8wpbXIJit08qlA0MCf3tfUZ JYQNEA== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46s95thnrk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 21 May 2025 14:52:48 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6f8cb4b1861so67434396d6.3 for ; Wed, 21 May 2025 07:52:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747839168; x=1748443968; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u4Zvv4Lve36XriRiQpKqbCb+vrtuRWZbxGxM5SWigA4=; b=Yw8c5qX+goE0SugmBlbXC2SUh1XofIp9uDEaD6Z4rLG4ZK2Jd4z8+Y8/WWauhiBqWq yBAdaCN4aDo350ZMZEBTfdn48DXvD+5PVSSey6/VdhkUMDVnUkiOjvANrLJD3XNW1wa0 WHorGkxkCBM4k2z7ejuSQQ+KyZg0hqPUAQA68MW185M/X4Z/H/ckeakMHLNpyWiMPLTn u5yw9DIq9MkxmJnEcHV718UeqeikWjURfS6CrjX/HD4Gyy6UtAYPYYyWu5ZI4cIh62jv 7GaoSR5PTnIw6n6F/osmbfmtTD9Nd5KCIYVRnnr8wJhz2CyNhLJayjWdEL3iSV81ZUMS 8a8Q== X-Forwarded-Encrypted: i=1; AJvYcCUlgQmmEJCWJc+iajS6bew0Lkr2hcltX3s8+aL/nPvv6Zk9DEIQ/sCbcsbn/yLJnPirE9iytBfKogZLPmM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9wIx0souUOupKDLMVl/g6gU1KlMNuyDPmRM3F49WLfLPO5o3M eLF9Ty7RHErMRwTyjtkD3UPvGBBej8ryUK/ooZLXhuXuLBjbrk5FWKQ39DLGfkSk7bJk7GKCLuJ /9+4ez1pFQLc0FG05QP8C9NjA2jcxirckNGMnJoQF0luoiLzUI0GZI7kNr4CsW1b8IjQ= X-Gm-Gg: ASbGncviEa5BNTnilXKe5YTerV2bY9UKteDOw/nn5xX93q8hRyQGjJBb6loMOogAff7 QzVdEstXGJW5ZUVKMCo7j58KbojODzT3uqfW6a1jtQPqCS+tsOfWzCN2z4LFuk2t+S+Fvtd7HdS Yeee1nQzOs8SL2WOOYdbNKrU+BiiiHL98yvRgjM9kTsTZ8ePM2PIzdTBAosVufldZ8CWNULYyUh QQbW9wsbcLkU0C2ddYln2Du55VPwq0G1mJHkZgqOFNpycEAK9bBv6ppa3Du7IOW7V5z26T+1ppB psPV/2jKtpPuZcUHcfM74nr4vWhbRX7HvKZKweULVuM9CEK/uqWM+yMaG3GzvYePuATr/nctFKp jviyQ7tM/tO6BZA/NTCdQ1U9S8CquOmLKnHuHwf3O0it/wD0+WHwVm30dPYh3XdBA X-Received: by 2002:a05:6214:1ccf:b0:6f8:b011:cbac with SMTP id 6a1803df08f44-6f8b08ceae1mr337215436d6.35.1747839168064; Wed, 21 May 2025 07:52:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEY5yP0CLnTt//gohFf5UwR7ErzPhdBiAag+ixC0szgLaww/eW1j4yyAr2W8/zdejzufNwJ2g== X-Received: by 2002:a05:6214:1ccf:b0:6f8:b011:cbac with SMTP id 6a1803df08f44-6f8b08ceae1mr337215096d6.35.1747839167522; Wed, 21 May 2025 07:52:47 -0700 (PDT) Received: from ?IPV6:2001:14bb:c7:69ba:b852:d3f4:8957:5a1e? (2001-14bb-c7-69ba-b852-d3f4-8957-5a1e.rev.dnainternet.fi. [2001:14bb:c7:69ba:b852:d3f4:8957:5a1e]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-328084dc67bsm27690351fa.59.2025.05.21.07.52.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 May 2025 07:52:46 -0700 (PDT) Message-ID: <045c2ba8-3ac5-4773-ac7b-a6d8625891c8@oss.qualcomm.com> Date: Wed, 21 May 2025 17:52:45 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Mark FastRPC context banks as dma-coherent To: Xilin Wu Cc: cros-qcom-dts-watchers@chromium.org, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250416-sc7280-fastrpc-dma-v1-1-60ca91116b1e@radxa.com> Content-Language: en-US From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=QKBoRhLL c=1 sm=1 tr=0 ts=682de8c0 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=ksxQWNrZAAAA:8 a=mSK3FFS5vNSzVinocfkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 a=TjNXssC_j7lpFel5tvFf:22 a=l7WU34MJF0Z5EO9KEJC3:22 X-Proofpoint-ORIG-GUID: pT_ZXy5wPpPZPXTO5hGgtd_5XmTU7pYX X-Proofpoint-GUID: pT_ZXy5wPpPZPXTO5hGgtd_5XmTU7pYX X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTIxMDE0NSBTYWx0ZWRfX6X10tc0ryPLV gKsKF51KaxPNxE+itbqb+I4EAz4padhYF6vv/hHYk7qx8YDJ0HmWBQn1X2WvGedNPAOTpUagCdk vv26ZNasvkC0ax8rIAU14L/zij6q/nfd5nJw/4k+dCVN/U0vhv7pLPswYciCIoiANvMCx8bVLbf /FSoT6v+o3kv0Sp7mCE2oJ3ZJy8n9Csdr7nlW9uIUPaoC+OEbOtORkXqzEcx+x0DS7tVtQOxnJA ShKhnivqp3nSNImgi9Zt9utBI2H/4JdDFIw2FPpfofLBfbWq/tPyipd3madQlGDgCqDj2DdcZai KOw4JSJCjyctCrIhy39V0CvRcpynRZvsSKK8q7oxM3GnEL9c5rxSK0SQ35jnS6YGwUi+ZlSOwIa uUnj7WoZ6/MCBDSdq0T9iHx9Ztv3o9WJnjouqFt5gUl033ksyncrn7rQagIltbzj1kHma3QM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-21_04,2025-05-20_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 adultscore=0 mlxlogscore=623 suspectscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505210145 On 21/05/2025 17:08, Xilin Wu wrote: > On 2025/5/21 05:34:08, Dmitry Baryshkov wrote: >> On Wed, Apr 16, 2025 at 06:54:18PM +0800, Xilin Wu wrote: >>> The FastRPC context banks are DMA-coherent on sc7280 platform. Mark them >>> as such. >>> >>> This allows LLM inferencing on the CDSP using Qualcomm AI Engine Direct >>> SDK on the qcs6490 platform. >>> >>> Signed-off-by: Xilin Wu >>> --- >>>   arch/arm64/boot/dts/qcom/sc7280.dtsi | 15 +++++++++++++++ >>>   1 file changed, 15 insertions(+) >> >> Are context banks coherent on FP5? On Herobrine? Or Nothing Phone? >> > > Hi, > > This was tested on an upcoming SBC (Radxa Dragon Q6A) with the Qualcomm > Linux cdsp firmware. There would be an error in the LLM demo app without > this patch. > > I'm honestly not sure about the devices that you mentioned, since I > don't have any other sc7280 devices to test. You have enabled dma-coherency for the several families of devices using SC7280, QCM/QCS6490 and SM7350. Some of them might have older firmware, etc. We had this issue with SDM845 / RB3 boards. Bjorn, do we need to revert this patch? See corresponding discussion at https://lore.kernel.org/linux-arm-msm/70ffec25-17c9-4424-9d0b-da6560f7160d@quicinc.com -- With best wishes Dmitry