From: John Garry <john.garry@huawei.com>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
Riccardo Mancini <rickyman7@gmail.com>,
"Sohaib Mohamed" <sohaib.amhmd@gmail.com>,
Carsten Haitzler <carsten.haitzler@arm.com>,
Marco Elver <elver@google.com>,
Michael Petlan <mpetlan@redhat.com>,
<linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 1/7] perf test: Skip reason for suites with 1 test
Date: Fri, 13 May 2022 17:46:43 +0100 [thread overview]
Message-ID: <0461c8ea-a872-2581-55ec-0e2ed4912b21@huawei.com> (raw)
In-Reply-To: <CAP-5=fVA+x_sNuWCOMj9ASBpFanms8DkAvLkbs5URDvcBW1itg@mail.gmail.com>
On 13/05/2022 17:34, Ian Rogers wrote:
>>>> john@localhost:~/acme/tools/perf> sudo ./perf test 63
>>>> 63: Test libpfm4 support : Skip (not compiled in)
>>>>
>>>> Although it is odd to have a single sub-test, is there a reason for
>>>> which we don't print its name? We print the name when there are multiple
>>>> sub-tests.
>>> The reason was to replicate the existing "perf test" behavior before
>>> the kunit style transition. The main place we get tests with a single
>>> sub-test is from the DEFINE_SUITE macro:
>>> https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/tests/tests.h?h=perf/core#n67
>>> I agree it looks kind of weird and was inheriting the data structures
>>> from kunit and the format of the output from perf test.
>> Out of curiosity, which suite is this that you find only has a single
>> subtest? Does it possibly only have a single subtest as some others may
>> be compiled out?
> I was getting it when I added a skip message to the openat syscall
> tests in patch 3:
> https://lore.kernel.org/lkml/20220513040519.1499333-4-irogers@google.com/
>
> I didn't see any changes with any existing tests.
I suppose it works when the suite has the same name as the subtest, so,
FWIW:
Reviewed-by: John Garry <john.garry@huawei.com>
next prev parent reply other threads:[~2022-05-13 16:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 4:05 [PATCH 0/7] Make more tests skip rather than fail Ian Rogers
2022-05-13 4:05 ` [PATCH 1/7] perf test: Skip reason for suites with 1 test Ian Rogers
2022-05-13 15:29 ` John Garry
2022-05-13 15:42 ` Ian Rogers
2022-05-13 16:26 ` John Garry
2022-05-13 16:34 ` Ian Rogers
2022-05-13 16:46 ` John Garry [this message]
2022-05-17 3:53 ` Namhyung Kim
2022-05-13 4:05 ` [PATCH 2/7] perf test: Use skip in vmlinux kallsyms Ian Rogers
2022-05-13 17:01 ` John Garry
2022-05-13 17:05 ` Ian Rogers
2022-05-17 3:21 ` Namhyung Kim
2022-05-18 3:37 ` Ian Rogers
2022-05-13 4:05 ` [PATCH 3/7] perf test: Use skip in openat syscall Ian Rogers
2022-05-13 4:05 ` [PATCH 4/7] perf test: Basic mmap use skip Ian Rogers
2022-05-17 3:42 ` Namhyung Kim
2022-05-18 3:48 ` Ian Rogers
2022-05-13 4:05 ` [PATCH 5/7] perf test: Parse events tidy terms_test Ian Rogers
2022-05-13 4:05 ` [PATCH 6/7] perf test: Parse events tidy evlist_test Ian Rogers
2022-05-13 4:05 ` [PATCH 7/7] perf test: Parse events break apart tests Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0461c8ea-a872-2581-55ec-0e2ed4912b21@huawei.com \
--to=john.garry@huawei.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=carsten.haitzler@arm.com \
--cc=elver@google.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rickyman7@gmail.com \
--cc=sohaib.amhmd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®