From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754344AbcIIU0z (ORCPT ); Fri, 9 Sep 2016 16:26:55 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:55534 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751064AbcIIU0t (ORCPT ); Fri, 9 Sep 2016 16:26:49 -0400 Subject: Re: [Nbd] [PATCH 0/5] nbd improvements To: Wouter Verhelst References: <1473363221-142264-1-git-send-email-jbacik@fb.com> <20160909200816.spdbyericjehvmcq@grep.be> CC: Josef Bacik , , , , , From: Jens Axboe Message-ID: <046ee110-1951-be3b-9251-fbd03bef9f53@fb.com> Date: Fri, 9 Sep 2016 14:26:21 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160909200816.spdbyericjehvmcq@grep.be> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [66.29.164.166] X-ClientProxiedBy: CO2PR05CA040.namprd05.prod.outlook.com (10.141.241.168) To CY4PR15MB1192.namprd15.prod.outlook.com (10.172.177.14) X-MS-Office365-Filtering-Correlation-Id: d7282ef9-ef3a-48b3-0ed3-08d3d8ef96c0 X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;2:qPBtTiIgtuGl+EVddPmyezP/K6v0bgblA0CTsG1nxEhLKtynl9zSNKWrpE3XBL53ou06+AU01zN72wT5EBgixkrjDmZUlWNOJ0dD3FnQiT7HkTi9CRyKYhTTL56xE8WF2/o67XBXEG43T3IWLwNsNpFmR9iqsT50e0k8VHRJEeJ4ogu4fW4xe6p7pQs/6iHj;3:o7kwczxElKXqLnEUm4y7QGTCp6NkU60Y9EYWCXVM0rMtJsqkGsgLkDiHcAb6hHVf2ZV3EJ0DTeZ0l4gIU4hX6lgi2Pwt6AJXgtgkgiP8wgff3I6g3mYxdzvwDW7MtQpO X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1192; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;25:67y1Uql7RnMxb/0UHcOM9cQVUpjjkGfNFvjWrBpyWyGPwcDVxS+qS2/LkmtzswWrMQUtLT72N+VcT0NYkeAaf5W7+r6KG8c29JSVk5O1BbUhAjeyS/9jQqfrdBZeU5YMpo5B549bInUASxojjsVaT+ld586tpB+DnFwxTI2EvdUOIAdEXU8GS2JtrU36SM1GHNd+RAEBI6NrbO5Lot9EezhTFd+Qyaaalaj+V0wASAlfQapHL7bH5A+F1km3UwkYgEDX4uh5zYNW0ubBY0RFvhRqM0f1W8iLwNF18BZpWctbxraYHU/wGKs0Rx7/tZM5BJOqfBNZ55y8TI+R3bFnH7tlRzK5tz7XDDC3aAgShoAZu33QB2rbIVQeLrp5bsyFj6MuRX59mXozgnPlnhGleUjfB4nB+ZuV5maQMF9FeBNg/rmoGA6eEIwXyT7s6hg/TOR2ZJFz7yE+1Q3xHMGt7mbZhq5Rx5cWgJRfedp7MvZyiZzlGXX8EQOn26+iNgcW1ViVLXDkYEX1mTs6ttqwY3luI+fLkVy0bIFVK3LMjxiez6/cCoygf8I8r1KSnj5C8A2DOIz0QxAGOzKFeginCkC0JBuRVdgIGJbxe5UiWceKcAF5sw+djCUmVfH7YZiIlgT6OxFeKtH+xKNJPdjAjL2C1TqfZHoz5Mpx3Kf+xNaYjP/XwvMvgGmnl+cdGSAe;31:LIrzcnQ20Bh+qY4S8j7bKkKkdpRsorQqmFh/N96xCz6otHHqL60oL7oNQUV7Y6qMnWVxYQqoRFKr7EtCDlhWi1+E7nt59Z1ftykgG1AuSPBQDzArv353YZ7uxC9GhyoPq3vdePD/hrLfp946zf1MQT3ZDNJoagSvodhe2Q3O+YhOJSZkoL83CZrP7JqMJkM8oJkib25dgKQgfUqFY8j7yq87MCHr4lgilKxo9J9tDpo= X-LD-Processed: 8ae927fe-1255-47a7-a2af-5f3a069daaa2,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;20:8/bXYOd6SnvQ5umB4za4n+hcib220lhkrQKYsa14lW20bmKJAUe51D/9WxydrhTvB5GvCdn3IOm1T+w24HQ7D/jboGk6j/12GM3mKZ3fqzMCV7Oh+DozrZUKfkhyiGdjxQ4M25A38viQoSX68VAAYWBl1/xshqxyqREyyXGwKZo=;4:L6ait+r9zAJk0mRpwzCcEvZ1zxH3SuAm5cc0NM0VInnxRWUXaawxieWeh6T7wzzL0Y3e+WokU+EpDmW1jf0IxZlVZjd0BzFuC2YWeNLGFNWIP7yxzPu7JpxRqm+wzr77T2xEenqyNd8vM15rl6wIMCXTjtT4wjIFTM8cHrCLg+SVPu/BXvPOgJOOtMXJ8zr/mczOElT25fSAK27K5bQhO7JkVCVSvfvfFbw1ydOXVMPyC6tvZYVPYe1wPavwSSvM+esW4MNDJUXcYulmbYnNeedEqbrKpchFr2yz9qXPS4tI+qOtZh9Hmlw7yswSrnsYWxem09dN7eVaWNuWus1xv6O5emBWQ8t4pY6KDUjG8y03LFT0tW+lENAejCOZAqMgZ6pXwdK+WokoSc+sygIG9w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:CY4PR15MB1192;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1192; X-Forefront-PRVS: 00603B7EEF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(189002)(377454003)(24454002)(199003)(54356999)(65956001)(64126003)(7736002)(47776003)(66066001)(65806001)(105586002)(106356001)(7846002)(101416001)(31696002)(81166006)(3846002)(33646002)(110136002)(5660300001)(8676002)(4001350100001)(86362001)(117156001)(81156014)(65826007)(83506001)(97736004)(77096005)(76176999)(189998001)(586003)(305945005)(230700001)(2950100001)(50466002)(92566002)(2906002)(23746002)(42186005)(68736007)(36756003)(4326007)(50986999)(31686004)(6116002)(781001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1192;H:[192.168.1.176];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1192;23:q0i/jrj3gMuMZErX7QDy2GRtClorp7/heixNR?= =?Windows-1252?Q?n0gDb8YgDiwrxGSCq/5IrIvgRvrTyXVQkjtI8kaQmBVV7PLLjNQunmzv?= =?Windows-1252?Q?Se9r4UgTYPJZvpso91VQg82fFYACUsdN+zFYWt2i76sxj4beqmUshK9y?= =?Windows-1252?Q?fhplr2CFW9dJ2XNPvWq7aUaGZdDB9zlqXqew0CkSS9wGPsazuUUNEB9T?= =?Windows-1252?Q?r/93TMTXNP4GxDAqlxgQvADSw38PlVyEtndEhggQEjuS6zIJ1WqNVP/E?= =?Windows-1252?Q?YklrO+hRP8yS8JNOHvB9/L2HGs5z+wvw8Pg7oxV1En9ksqTAgcSo8Ra/?= =?Windows-1252?Q?YzszxIvmYp+pDiQvXUESXzegJk97aYtJPkbOz6KpsfCz4RE+TqvoV9Gi?= =?Windows-1252?Q?LtBQ3YvfuP3K4eKpqxX+XBsJUbgvSL5ruOUYJDeBcuGaAkeMwIIu0aZd?= =?Windows-1252?Q?/kdDFFoqsIeID7jeRQyoZEZA2HCZZ0ckNQicNiZR0ZfC0iGiWrDPOqhg?= =?Windows-1252?Q?mfLTLi/iYLR7/+naR+srCrO0WrAW+SJtOslHsxVrAJC9RJQaiB62EkBS?= =?Windows-1252?Q?j2q/DbC3yyDF/1P7RJrJO9yHg4fIF5s3s9FqMxWhipKTmLwUoPZXs05L?= =?Windows-1252?Q?Rq+hWHcDPSNTaZZ3VR2oPOU6yAGhbkhlBYzOClPKBzxScFqVRTpDscvG?= =?Windows-1252?Q?ryfRKF/iHEpKt1DBn6xXtnSLHQ2RvGQFoBk4obE5HGIAcS3fyQP39Y4G?= =?Windows-1252?Q?gV/Ym8YWifJHcsgoD6kyq5WD/CPqJPPZHE8G8KlWxOfd+TiagV0Kz5sq?= =?Windows-1252?Q?2rs+Cpe//cxT39H/NxNNJ/AjvUxEvjT3lVr1Pvjei01fuO1WRqWMYwU3?= =?Windows-1252?Q?S6vk2zsyh2Q5YU1vm2WCRyCSRmo6Dg21R3U2WaE3ATuE3o5d8vbv4cSU?= =?Windows-1252?Q?l7QijEn9YtaINE03YVBVhZJIY9qeGd1UpyOfjBffYSy/Wp5e8Z6dNgcb?= =?Windows-1252?Q?NPUXMT1UKEk5EANPsmU6h5Z/kixAsoF4s3asxWSIFfMdSZXrXTK62mD9?= =?Windows-1252?Q?ccfuUiJoGZyzp5J9InjVqwXtVciygdms7JtAApyqxgcbtboi6KXULUVI?= =?Windows-1252?Q?4crGGpgqGncr4e727r1GcmCQcdYNwxydjGinASJtfWfZtS7uXH99c3XO?= =?Windows-1252?Q?LwXyIOsjRaJHQNbk1Oc65LmRCVJGZzguZDWtMNUJzaSztPN56iXAW12Y?= =?Windows-1252?Q?gHBB2PTwB60iwIx5FLD+AtGj/eirQwohz5S77AxjneQUKcuUk2RRUIUk?= =?Windows-1252?Q?7vSKIOQl26Opo6CRx7mRa5dQo37vvDrY/yFgbuR0/iUBKNQU8lA6xOtu?= =?Windows-1252?Q?nDpZ+4lUSME?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;6:CuIknaHy2QOXtc8Dxi2yI1n4xg2KZxnVNDK0zhEC2tWAmWA6pZka4coXzuSxKmgsv1WuCnf6uZSzqvtjd2eYua4xfYOYFvqMDMrSCbqX/EiNaqA+XLIHjh5Fz52BF07SLZTfRL/aeYeBLbC9vuq2GaPAs64Zarevd59JuDQmXsH9dYpbd26CCguX4xR3bxmdnOMoiRrPLPivmDHGx6OUqIL6zER854W1Zv4GEoQiIJ9qAkgIl6O5LfNAgeg1t6Ekj6eyaLLjnDseQSKb4avCqe/Z4a0yOG+W+oU/KALvWcI=;5:aTN6AivUfVh0WBkMWs78mMIC33FHCG8evmKS7n1hjEvB94ihx+ZWXEU39g1LNpue4OjeCM23rEZ6kMP0Eb+0Ba7WLV1t8mH+bDkd3MEILa8t7ZAgHcex1GD+oe36GqjPMgaXhnj/L3d6aiLmGXzwpQ==;24:kDVEfSMgJ8Q1o0+9ehj6wcIPJQjgfk9r2fHnvsGiOutngyEHkbVgkxP2drA1EeiZ41+bg+a3Y9n/nNGN2qQzKWTh8RwzOaLmX8tlZbC7JTc=;7:PH0RXiDlwzKolPomfb0p4tbKVbqITBkzsShJUYcTy8Fdhkbq2r7awSsrIK2Cl99xBl9LNClMD6eNkU87RZSQxS2Q4XLlvNFUqqpLHpbNCwhqick2QCxNeGQRg2+XYdLvjuhk9fmbyA9cadbpmVEdByjORDi7ZKTN0yoIp5S7BWpzaPaJaRVhdrtiFBs9AmziaBNy+jjjBmElySpDAtSoHyNiexnwcyI1mOV/u6blpIwTd9y7lzaaNWiLwHcZ8usv SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;20:pHrn8gMkNYnpgJEoEEQHdpmVtYyshFQ524AUm2SZCyTok8uccMPBIAOTnUbxkUo20pNFntzynrSRPifvdMt0713CWO0taEtSplbrvQcVa8130UYdxmbdZ4r+U35ljRCmcsGwtDhsE3udb8O5euKN4nvr9gtmbnqt+U9ePCnvQSA= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2016 20:26:30.6807 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1192 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-09_11:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/09/2016 02:08 PM, Wouter Verhelst wrote: > Hi Jens, > > On Thu, Sep 08, 2016 at 02:13:46PM -0600, Jens Axboe wrote: >> Not only are these nice performance improvements, it also cleans up the >> code a lot and kills crufty old driver code in favor of using the proper >> APIs instead. I have applied the series for 4.9. > > Please ensure that the comments I made in my other mail are addressed > before you push this to Linus; otherwise this will result in significant > problems for userspace (that it would then be my responsibility to deal > with). We've got some time to hash this out, before it goes upstream. I agree on the 'pid' file being an issue, we need to bring that back to avoid breaking userspace. For the other part, Josef, did you test the multiple connection setup against re-connection? -- Jens Axboe