From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6791617E00B for ; Tue, 1 Oct 2024 13:42:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727790148; cv=none; b=ZSeG1jM/15BAbxSnxRwtm/hrqkFXIsexIAyINyy0oMyzY9MfyncSSnb0xz0c1jpTDI9OPgxR//9parHN5akmFm7cPfud8b53CRrdu8hQC0VrJ2juKE1aqjo84frVRoIO+EgwSu58JFlYJK2FZU/JNSjKMl5nlcZdLyGXUV2CowM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727790148; c=relaxed/simple; bh=Hxb93VBN2wjQjq7K7CdVUFSYbZsXI3NIAZECR/42fBI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dyfXARPdS+W0ZDgdMo2eI63JV0MRR6OEBXViM7lpHJOZGoaPDtD+QjUPGppPm1OxZAetO/B8brPN9e0pG/elq+G2DLpq5M6l95t+Pdf3rAGSJtHzcCgGAhfM67dNoXy0XWERj3cYh6jHsKz1xTkDMtqUPmLI9kU1mX0WFceYy7U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=a6eolNAq; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="a6eolNAq" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-71116d8504bso3479167a34.3 for ; Tue, 01 Oct 2024 06:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1727790144; x=1728394944; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zO30q9nPhm3Q0tzD5dpPGZWjk6LKGp2tiZZl58C+1tQ=; b=a6eolNAqg22EG38jDFtNyR6guZblbQak/M1hurm/mnq2Is1Wd5OUf09eAa0iBLedRn RVYt/WlHBY4OARtLjEukhSWKmMmNRB3S3gpd1I9ldHqi5lojz7Jw1UOWR6jpoUeAruun fdsDyErKzImR8LNgrMP6LtKhWTHuRTudxRa2FomX6C1JvpxP4BcNbClp9hkVvI/gh5n9 Zssw8CxjeliWmKH9u6a906n+wGEZt6PWNU4AGCFYfZ90Nch3miPPL4NOXf68BmJpdBhY wrWM8GJq0eSvIbvYoPtrBbQOY91qyQ6v/Ky1ccKnw0IorxCbezerzY9xpjkFCBDH40rj XhiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727790144; x=1728394944; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zO30q9nPhm3Q0tzD5dpPGZWjk6LKGp2tiZZl58C+1tQ=; b=gUQ4LlPfMvYE4FA9+G+83dj+pBbRF9L+PQ0hQMADjy4OMBGAyp0knZ4Ov4R0sqfd/e r81xkuPy2yRZslb4yQifMJOeLsut53tfLyZy+OgwwK5lptNH0QxbqvvXqQo86GnMmuMp 2f90k7wIrGcP1v09mrGcrnm/TqRd3LedG65cOvLNGXSND0hOGZomTNZM+bG1WdUMgmmq /qtH6blOpD79s41qpRuYxj6cLeekoVJnWs+YJLKdpND/BJxZMk893rE/HaHRlYTPwnG7 R5nx9VxUBo9LBPNN5JNbRjxxS2Oeate9FyNpJjqQNIgfGR7c7KA5mFEeDrYCg6/30Ov2 QLVA== X-Forwarded-Encrypted: i=1; AJvYcCVWhE+qiDPLyrPlsoNOV0PxtNN34CUeWySf3IoGT+CA6MjwJzqKvp7eIWbHE+/QZp0zGQbWbqglZsmOXRo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9ME5fz/aQoZFXwpp62O6iZIIjDfx8i6dGa7GLZqWqHgXBqLCc I4BfEaioVMKAgaZj7OAUq32hBiE3qQ3oEC3TwWL7Z8oNP9qnfurH1+6e+TpUzRg= X-Google-Smtp-Source: AGHT+IHFNuEbhuCxlZk9FEMhWvFEJI416om35o/BvxuQUNU1PzqlhDNXl67kUSrg3vRnuGn7A+ok6g== X-Received: by 2002:a05:6830:3819:b0:713:8b3b:8289 with SMTP id 46e09a7af769-714fbe8fc85mr12996098a34.10.1727790144500; Tue, 01 Oct 2024 06:42:24 -0700 (PDT) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-714fb64fd10sm2889619a34.10.2024.10.01.06.42.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Oct 2024 06:42:24 -0700 (PDT) Message-ID: <047034ae-135b-4ce9-a407-9b2a00841324@baylibre.com> Date: Tue, 1 Oct 2024 08:42:23 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 8/8] iio: adc: ad7606: add support for AD7606C-{16,18} parts To: Alexandru Ardelean , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: jic23@kernel.org, krzk+dt@kernel.org, robh@kernel.org, lars@metafoo.de, michael.hennerich@analog.com, gstols@baylibre.com References: <20240919130444.2100447-1-aardelean@baylibre.com> <20240919130444.2100447-9-aardelean@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/1/24 3:26 AM, Alexandru Ardelean wrote: > On Thu, Sep 19, 2024 at 4:05 PM Alexandru Ardelean > wrote: >> ... >> @@ -153,7 +349,19 @@ static int ad7606_scan_direct(struct iio_dev *indio_dev, unsigned int ch, >> if (ret) >> goto error_ret; >> >> - *val = sign_extend32(st->data[ch], 15); >> + chan = &indio_dev->channels[ch + 1]; >> + if (chan->scan_type.sign == 'u') { >> + if (storagebits > 16) >> + *val = st->data.buf32[ch]; >> + else >> + *val = st->data.buf16[ch]; >> + return 0; > > Arrggh... > I messed up here. > Guillaume found a bug here, where this should be "goto error_ret" or > do an "if () {} else {}" > How should we do it here? > > Do we send a fix-patch or send a new series? > Since this patch is already applied, just follow up with another patch with a Fixes: tag.