From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8622413FFA for ; Sat, 2 Mar 2024 10:22:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709374977; cv=none; b=S83kbJsn/cNhR/UUFaWvRj7v6rpt5wJ+gniQvH5FhBsTePQOBQ26DbKshALMBJ22fmvosHWUBAYRGpCaAJn8nDnPwwmxiu1wDqQiR4s9fH+UaaLw6c/fK0c1nN8kQ6/kmPlGBbh47OR/7heA5GbU5sI94vOzbmP8n3fbnRBHVwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709374977; c=relaxed/simple; bh=/0QmJ9fSROWFqfGEyhsejzGlrxyZAkEvZidBoUr+Jm4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gdVjRsVL71hspTQMaHDZ4KxSz1ghY2mWmk2pYRUiJnroNtIDkt6gh0TQa8TY3s6wxM3qzkIokFT7oT3PNJ+4Mqd5/idN3Ka6SBKTBia3a7aDdP2pDufvvyzq7H6MQIY9mhIzjEAKdVr2qZBcqbh65feXpbbANoIMKM3SLQMH3kQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=F++qLLeN; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="F++qLLeN" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-412d67e4e91so1259015e9.2 for ; Sat, 02 Mar 2024 02:22:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709374974; x=1709979774; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pMdekztujkt4AzA7D7S8LzaTnjsciXQ/ToTUP2Gu6E0=; b=F++qLLeN+9acaQqFBJyIQMsRmZakTD+nQ2ahzgW6VebDxp8TQxMgDl4G6+wPE0Q9Zo BKXs5ycBRvia6rd7IO3uYgYd8ZKNSmFn9AjKd2nAVkmlFROw9y2pzLn+i0tKBNJt+q/3 wkqfXu4vi+n8i0w8gSvvi6a0+t6UTHQPfTnaUDMG1fiqT5264JtKfeurtOLlxUlzODZR HTH2zeUVzmIIwOA3zSjZfp706RQLAynjcCOtXMVQx0MFVJb96qlM9DOsSOuZ7sLBy5fb At/Z5N8XIKzpqf9PC6rAxCAd0TaP8XJbtoFDEpXAtjc78NtMO4OxGXF3Jg+6kMLnvc3H 079g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709374974; x=1709979774; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pMdekztujkt4AzA7D7S8LzaTnjsciXQ/ToTUP2Gu6E0=; b=BhXB+LrwesZHOOKHkp8vouFQq/+y/+RxOerklTX7iclsGUowhbZ/d2MVJeJ3DzV5iv VlYOuDOIKmytJNUBqobBcIyuLUJeiYioy37oVSHf8VF4wNQAhZorElQzRLrek+ig+Lsz iH+F5KfxA3y6eKu7i8W/NG/mE3dQ+MMrYwAQMVaRV8REe1eueK/a9Ep4dh/piO18rsBp hjYZXaEAcR5z7ufgSuYWRTnUK/pgVRcnFJIjjr0iV47d6B8lKPXG9HKsFVCrBm9QexJs Xgzss6vMtn+HI8Lb91wncAlcf1oZYaBSCGu4xYelKvexjZ11cu+qGP3VsQaT2bylIprX anzg== X-Forwarded-Encrypted: i=1; AJvYcCX1ewDosjFhCjcCIyClwKgtUhZdekpHetZ03x7GFiaZVUAjwUGBVqlVMFfiw2XogugRT7WXShmZMOcNqF7QmlVbNVlbHPIGxjBJN163 X-Gm-Message-State: AOJu0Yz/oOHB8t+uR6SnxyPWv7os1C7H8o4FTXc4Kh1Re+QkaDeJL2Te 5AoNGUTNwMPywc7cm/18l5RtowEYPND04AdSAO2YTBEHQfLU0o+L8rRIpaXnctU= X-Google-Smtp-Source: AGHT+IGto6zf48uW6nzQNBBDCaj4Rx9fjM8ygjSJUN3ZcpzxRro+pdXUvseP3v/8bDsBxgZ2BNgAPA== X-Received: by 2002:a05:600c:3149:b0:412:b652:27b7 with SMTP id h9-20020a05600c314900b00412b65227b7mr4001193wmo.33.1709374973835; Sat, 02 Mar 2024 02:22:53 -0800 (PST) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id jl24-20020a05600c6a9800b004126732390asm11126200wmb.37.2024.03.02.02.22.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Mar 2024 02:22:53 -0800 (PST) Date: Sat, 2 Mar 2024 13:22:49 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Xi Pardee Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Hans de Goede , Rajvi Jingar , Ilpo =?iso-8859-1?Q?J=E4rvinen?= Subject: Re: drivers/platform/x86/intel/pmc/core.c:500 pmc_core_send_ltr_ignore() error: uninitialized symbol 'map'. Message-ID: <047a3af2-682b-4a2a-89ea-ab2112e0cdea@moroto.mountain> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Mar 02, 2024 at 01:05:45PM +0300, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 5ad3cb0ed525b80c7f66c32b49a68c1f3510bec9 > commit: 2bcef4529222424559ac9b45948ee9d82c09d9b5 platform/x86:intel/pmc: Enable debugfs multiple PMC support > config: i386-randconfig-141-20240302 (https://download.01.org/0day-ci/archive/20240302/202403021544.6qtkaAly-lkp@intel.com/config) > compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Closes: https://lore.kernel.org/r/202403021544.6qtkaAly-lkp@intel.com/ > > New smatch warnings: > drivers/platform/x86/intel/pmc/core.c:500 pmc_core_send_ltr_ignore() error: uninitialized symbol 'map'. > > Old smatch warnings: > drivers/platform/x86/intel/pmc/core.c:500 pmc_core_send_ltr_ignore() error: uninitialized symbol 'pmc'. > > vim +/map +500 drivers/platform/x86/intel/pmc/core.c > > 92f530edd7c955 drivers/platform/x86/intel/pmc/core.c Gayatri Kammela 2022-11-14 463 int pmc_core_send_ltr_ignore(struct pmc_dev *pmcdev, u32 value) > 9c2ee19987ef02 drivers/platform/x86/intel_pmc_core.c Rajneesh Bhardwaj 2016-10-07 464 { > 2bcef452922242 drivers/platform/x86/intel/pmc/core.c Xi Pardee 2023-06-13 465 struct pmc *pmc; > 2bcef452922242 drivers/platform/x86/intel/pmc/core.c Xi Pardee 2023-06-13 466 const struct pmc_reg_map *map; > 36974daf53888e drivers/platform/x86/intel_pmc_core.c David E. Box 2021-03-19 467 u32 reg; > 2bcef452922242 drivers/platform/x86/intel/pmc/core.c Xi Pardee 2023-06-13 468 int pmc_index, ltr_index; > 9592438886756c drivers/platform/x86/intel_pmc_core.c Andy Shevchenko 2019-12-18 469 > 2bcef452922242 drivers/platform/x86/intel/pmc/core.c Xi Pardee 2023-06-13 470 ltr_index = value; > 2bcef452922242 drivers/platform/x86/intel/pmc/core.c Xi Pardee 2023-06-13 471 /* For platforms with multiple pmcs, ltr index value given by user > 2bcef452922242 drivers/platform/x86/intel/pmc/core.c Xi Pardee 2023-06-13 472 * is based on the contiguous indexes from ltr_show output. > 2bcef452922242 drivers/platform/x86/intel/pmc/core.c Xi Pardee 2023-06-13 473 * pmc index and ltr index needs to be calculated from it. > 2bcef452922242 drivers/platform/x86/intel/pmc/core.c Xi Pardee 2023-06-13 474 */ > 2bcef452922242 drivers/platform/x86/intel/pmc/core.c Xi Pardee 2023-06-13 475 for (pmc_index = 0; pmc_index < ARRAY_SIZE(pmcdev->pmcs) && ltr_index > 0; pmc_index++) { > > > ltr_index comes from the user via pmc_core_ltr_ignore_write() Assume > that it is zero. Never mind. This was fixed in fbcf67ce5a9e ("platform/x86/intel/pmc: Fix hang in pmc_core_send_ltr_ignore()"). regards, dan carpenter