From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B89CBC433EF for ; Tue, 14 Jun 2022 16:31:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244892AbiFNQbw (ORCPT ); Tue, 14 Jun 2022 12:31:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245157AbiFNQbo (ORCPT ); Tue, 14 Jun 2022 12:31:44 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 42EE54477A for ; Tue, 14 Jun 2022 09:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655224300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oavP8gsV6cJWMEx/ty3RSD/S2p03O0ZnolvRU2i8U0U=; b=AXaSp1R5dTOazmBr/xwLsKeIcCQEs8omJNxnUKnr5gFRtHZFo9ymOUIiLNTWDUSmzOXP1e 82JqXBY+dYVZ1Zn/YHuF32yjoaD4mpYLDL0yijDLvHhVOCBJjIKCj1/8+sjtnZjIAa7BMa TzgtVf9U3h/Uy6M5f6ssgdz1i5FqWMU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-324-moV3zpJ0OUOLDLd4kuu_Fg-1; Tue, 14 Jun 2022 12:31:39 -0400 X-MC-Unique: moV3zpJ0OUOLDLd4kuu_Fg-1 Received: by mail-wm1-f69.google.com with SMTP id k32-20020a05600c1ca000b0039c4cf75023so7810550wms.9 for ; Tue, 14 Jun 2022 09:31:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=oavP8gsV6cJWMEx/ty3RSD/S2p03O0ZnolvRU2i8U0U=; b=NVfApTfAZCLacdPPIYjEkdLw5kQdTXeMNdkvJXg67L0eg9ia0MSfHQFDdVvl0lz1I9 qoCIpIE98oOg20g+sNQgunzZa4aai3z1CPo3BoYznn3HXYtN6lc6qLUU0fYXhApXS1eC 6L0fwwylcSKLBMK1JVYPi3SC7QHKFRHj/mJMoDiy8FL0ctxw5wkQv8I3hFSJc14wpiXQ 0QFbInTeNvTiGgsUt/MBOpotyvOUTbam/hpOxBW16eBvAvO9+OIBWjZyWsCbpwrlYEdD NftEn9aA65k2UH8/aAS+gMV7RYOM/FRpfYm14odKvYHZ55YKH7IUY146Zo0T/tf3SHio NmxQ== X-Gm-Message-State: AJIora8O+i5r19I32XnzsCNz/8rp++03ZV/xtR0TMcf+UZlK+QU3EPYE YhfF6VM2GbPD183e2EsWhmj810iU1ceYWJiY0K1jz/oaYUCoVkpH9/gyYZqckQ9DHridGZLHqcf /bh6m3eRzWCNZtI4qAFkl5A5n X-Received: by 2002:a5d:6da3:0:b0:219:bcdd:97cd with SMTP id u3-20020a5d6da3000000b00219bcdd97cdmr5702991wrs.274.1655224297799; Tue, 14 Jun 2022 09:31:37 -0700 (PDT) X-Google-Smtp-Source: AGRyM1svQzIL6zLCvemWeG8M2S6FR8uXiEVS4pzOzqfRybaUZfeRrJrTeJlYzJRR2cIqLDUDDp3ugw== X-Received: by 2002:a5d:6da3:0:b0:219:bcdd:97cd with SMTP id u3-20020a5d6da3000000b00219bcdd97cdmr5702966wrs.274.1655224297599; Tue, 14 Jun 2022 09:31:37 -0700 (PDT) Received: from [192.168.0.3] (ip-109-42-114-75.web.vodafone.de. [109.42.114.75]) by smtp.gmail.com with ESMTPSA id m17-20020adfc591000000b0020fff0ea0a3sm12632199wrg.116.2022.06.14.09.31.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jun 2022 09:31:37 -0700 (PDT) Message-ID: <047aa23e-7926-6f8f-eadd-122dc81a3159@redhat.com> Date: Tue, 14 Jun 2022 18:31:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] KVM: s390: selftests: Fix memop extension capability check Content-Language: en-US To: Janis Schoetterl-Glausch , borntraeger@linux.ibm.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com, pbonzini@redhat.com Cc: david@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org, shuah@kernel.org References: <36d83871-343d-e8a0-1aed-05bf386f9b1b@redhat.com> <20220614162635.3445019-1-scgl@linux.ibm.com> From: Thomas Huth In-Reply-To: <20220614162635.3445019-1-scgl@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/06/2022 18.26, Janis Schoetterl-Glausch wrote: > Fix the inverted logic of the memop extension capability check. > > Fixes: 97da92c0ff92 ("KVM: s390: selftests: Use TAP interface in the memop test") > Signed-off-by: Janis Schoetterl-Glausch > --- > > > Here you go. > Hope it doesn't get lost as a reply, but I can always resend > and it's not super critical after all. > > > tools/testing/selftests/kvm/s390x/memop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/kvm/s390x/memop.c b/tools/testing/selftests/kvm/s390x/memop.c > index e704c6fa5758..e1056f20dfa1 100644 > --- a/tools/testing/selftests/kvm/s390x/memop.c > +++ b/tools/testing/selftests/kvm/s390x/memop.c > @@ -769,7 +769,7 @@ int main(int argc, char *argv[]) > ksft_set_plan(ARRAY_SIZE(testlist)); > > for (idx = 0; idx < ARRAY_SIZE(testlist); idx++) { > - if (testlist[idx].extension >= extension_cap) { > + if (extension_cap >= testlist[idx].extension) { > testlist[idx].test(); > ksft_test_result_pass("%s\n", testlist[idx].name); > } else { Thanks! Reviewed-by: Thomas Huth Paolo, could you please queue this directly as a fix for the "Use TAP interface in the memop test" patch that is currently already in your "next" branch? (or in case you rebase that branch, squash it directly into that patch?) Thanks, Thomas