From: sunran001@208suo.com
To: hare@suse.com, jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] scsi: aic7xxx: fix the following errors
Date: Thu, 20 Jul 2023 17:31:09 +0800 [thread overview]
Message-ID: <047fe06a541e4cc69e5f22b8b2cb33b5@208suo.com> (raw)
In-Reply-To: <20230720092958.3730-1-xujianghui@cdjrlc.com>
ERROR: space required before the open parenthesis '('
ERROR: return is not a function, parentheses are not required
ERROR: that open brace { should be on the previous line
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
drivers/scsi/aic7xxx/aic7770.c | 23 +++++++++++------------
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic7770.c
b/drivers/scsi/aic7xxx/aic7770.c
index 176704b24e6a..21f3ef4ac230 100644
--- a/drivers/scsi/aic7xxx/aic7770.c
+++ b/drivers/scsi/aic7xxx/aic7770.c
@@ -59,8 +59,7 @@ static ahc_device_setup_t ahc_aic7770_VL_setup;
static ahc_device_setup_t ahc_aic7770_EISA_setup;
static ahc_device_setup_t ahc_aic7770_setup;
-struct aic7770_identity aic7770_ident_table[] =
-{
+struct aic7770_identity aic7770_ident_table[] = {
{
ID_AHA_274x,
0xFFFFFFFF,
@@ -237,11 +236,11 @@ aic7770_config(struct ahc_softc *ahc, struct
aic7770_identity *entry, u_int io)
*/
error = ahc_init(ahc);
if (error != 0)
- return (error);
+ return error;
error = aic7770_map_int(ahc, irq);
if (error != 0)
- return (error);
+ return error;
ahc->init_level++;
@@ -249,7 +248,7 @@ aic7770_config(struct ahc_softc *ahc, struct
aic7770_identity *entry, u_int io)
* Enable the board's BUS drivers
*/
ahc_outb(ahc, BCTL, ENABLE);
- return (0);
+ return 0;
}
static int
@@ -259,7 +258,7 @@ aic7770_chip_init(struct ahc_softc *ahc)
ahc_outb(ahc, BUSTIME, ahc->bus_softc.aic7770_softc.bustime);
ahc_outb(ahc, SBLKCTL, ahc_inb(ahc, SBLKCTL) & ~AUTOFLUSHDIS);
ahc_outb(ahc, BCTL, ENABLE);
- return (ahc_chip_init(ahc));
+ return ahc_chip_init(ahc);
}
/*
@@ -294,7 +293,7 @@ aha2840_load_seeprom(struct ahc_softc *ahc)
if (have_seeprom) {
if (ahc_verify_cksum(sc) == 0) {
- if(bootverbose)
+ if (bootverbose)
printk ("checksum error\n");
have_seeprom = 0;
} else if (bootverbose) {
@@ -317,7 +316,7 @@ aha2840_load_seeprom(struct ahc_softc *ahc)
max_targ = (ahc->features & AHC_WIDE) != 0 ? 16 : 8;
discenable = 0;
- for (i = 0; i < max_targ; i++){
+ for (i = 0; i < max_targ; i++) {
uint8_t target_settings;
target_settings = (sc->device_flags[i] & CFXFER) << 4;
@@ -348,7 +347,7 @@ aha2840_load_seeprom(struct ahc_softc *ahc)
if (sc->adapter_control & CF284XSTERM)
ahc->flags |= AHC_TERM_ENB_A;
}
- return (have_seeprom);
+ return have_seeprom;
}
static int
@@ -358,7 +357,7 @@ ahc_aic7770_VL_setup(struct ahc_softc *ahc)
error = ahc_aic7770_setup(ahc);
ahc->chip |= AHC_VL;
- return (error);
+ return error;
}
static int
@@ -368,7 +367,7 @@ ahc_aic7770_EISA_setup(struct ahc_softc *ahc)
error = ahc_aic7770_setup(ahc);
ahc->chip |= AHC_EISA;
- return (error);
+ return error;
}
static int
@@ -381,5 +380,5 @@ ahc_aic7770_setup(struct ahc_softc *ahc)
ahc->bugs |= AHC_TMODE_WIDEODD_BUG;
ahc->flags |= AHC_PAGESCBS;
ahc->instruction_ram_size = 448;
- return (0);
+ return 0;
}
next parent reply other threads:[~2023-07-20 9:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230720092958.3730-1-xujianghui@cdjrlc.com>
2023-07-20 9:31 ` sunran001 [this message]
[not found] <20230720094503.3863-1-xujianghui@cdjrlc.com>
2023-07-20 9:46 ` sunran001
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=047fe06a541e4cc69e5f22b8b2cb33b5@208suo.com \
--to=sunran001@208suo.com \
--cc=hare@suse.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome