From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752545AbdJ3Nkr (ORCPT <rfc822;w@1wt.eu>);
        Mon, 30 Oct 2017 09:40:47 -0400
Received: from mout.web.de ([212.227.17.11]:60784 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752159AbdJ3Nkn (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Oct 2017 09:40:43 -0400
Subject: Re: [PATCH 1/5] wlcore: Use common error handling code in
 wlcore_nvs_cb()
To: Julian Calaby <julian.calaby@gmail.com>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>
Cc: Arend Van Spriel <arend.vanspriel@broadcom.com>,
        Eyal Reizer <eyalr@ti.com>, Iain Hunter <drhunter95@gmail.com>,
        James Minor <james.minor@ni.com>,
        Johannes Berg <johannes.berg@intel.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        Maxim Altshul <maxim.altshul@ti.com>,
        Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>,
        LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors <kernel-janitors@vger.kernel.org>
References: <dc2b8a7c-b4a9-2f92-12b4-a1d0d6911d7c@users.sourceforge.net>
 <7b40d50f-cdac-bd47-5070-894140f7ceb3@users.sourceforge.net>
 <CAGRGNgULQRFo7T2TKr_=xNY9csYXTnnPc4k1AjS2OQ20zg+cbA@mail.gmail.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <0487c19a-a662-1e74-cba7-12508a0b4307@users.sourceforge.net>
Date: Mon, 30 Oct 2017 14:40:25 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAGRGNgULQRFo7T2TKr_=xNY9csYXTnnPc4k1AjS2OQ20zg+cbA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:txN9gmJzAXa+Xl8hus1HiNC4r79HdRnik+KHFNz2yLauyVUR3X9
 powHcZDEP6nacbMZ/oHgpxC6IAyVxhUk2PRJIdr+x/MvTLqP3HUTxBtEZMNFa2q6pzOCEJM
 56HBWgybWRfUypCnBy4xYsampqYpj2H4FTV3iSbzHW2TMblhKFpVukFT0M58J6ZiDR/sj9u
 nArFWsbMkvWT/thtfvHdQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:MbveP5dk0n8=:tQNVlRqiu/d6oIn6KkNVgd
 Orp8aiV25JHBoNsgcx5ed89rlWFKzprSYOMob0nlXPwNSGLMT5M2OXOVcg3iSftZ3jKxo8sYF
 qt/mHNUX6FqTRbj4Cce16ktJXKBMZ2qtQ/rCSdoQ0uw0SMHqNYoaCCKeS4JLOCWqIlZ3Nh5jA
 /UCZYXiyP74kanthiVBgUVAV+VTYLUkA21GcWGAEbacjZSzuZep/igrOHAERMiDHZBVhrXp22
 PRE9wzrM4q2zpk1ZxhiMg2yVvxyWC13HOIIUurgvyh9CzYU6hvSo1rTe7gC01nbOyr1+l/Kxz
 mloidEVjYyRoJTi4ksbNUp6daJpYcEbi136LBPMGaj307lZtPwcqhHX6eFbesNBETOCaBO8B0
 Bln1XQoba05AWEIWWy/yoN+1N6LVsLFh6zQ0LF13tHWFtERQN0zy12e+RdyGvoIWS1g3r98Ms
 TiKjdKEpniEZCaoQyg+O4qZAh8jeik1oiphDGts7ReugEci6A7IpI5vlovcx51YH09SKmGdMs
 KzCuVt2gWyufjJHnOyC+avcmPJnCdp6X3AcuoN2BydjMM5uGs0OByOLOZtZmrVXJkL/WUEbPN
 9H065UiH1tZHw6ja2RB6Zkv664Eoax4adINOeIaZ5i/+XaARD9W9vaRk7bJncCI6BUGDEXcUQ
 TTp+mkR4bZsjJ+z5u180GlQX0XLolWXEe4t6iRt1RZXGaIo4Su5UubE3Rf+K7AhfsDFbNGwJB
 5EXtCvnbIKs+yaW0OWyZ8v0O0ZSKxo92DJ0S4wx1GhNNUY7Yu+GK7W/kVpxQMzKtJI+Kusu08
 Gbbv0NZ/bTZU7Q3AEQ9bK5RtDYSR6J6LOK10ba6CQwKB5WuYGg=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -6551,6 +6549,11 @@ static void wlcore_nvs_cb(const struct firmware *fw, void *context)
>>  out:
>>         release_firmware(fw);
>>         complete_all(&wl->nvs_loading_complete);
>> +       return;
>> +
>> +power_off:
> 
> Name this "out_power_off" to match the other labels.

Do you expect a second approach for this patch series then?


>> +       wl1271_power_off(wl);
>> +       goto out_free_nvs;
> 
> Why not put this in front of the out_free_nvs label?

It seems that I can not really follow this suggestion at the moment.


> It looks weird here.

Which detail do you not like?

Regards,
Markus