From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 221133AC0F1 for ; Thu, 14 May 2026 09:11:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778749876; cv=none; b=n1iIzqwFVXU8XSRMlG8bt/N7GPjXC1A2QXkXOlpAYlTRiSGGpMXLUFwF6ywj/a/u9Uu0XEE1wLW71wb8cJicOKau9ELifxYZBoE4cOHF1cx/JK5vfj+7jepaTRw3XUnoZIdxnbJv6l82AGTJNvQIUnLbcsggH0nJN01hZeWn/dU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778749876; c=relaxed/simple; bh=daa+1XvYSzE8eOwfhbectImkCDlzbI1HYNTaBEaId50=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oIfIeebD9hF1X+o6jXUU5PiJ791XZm64w9cByxuDTLlnJN8MDXRSKdh5Cp+OBC+ws5UCTDub2qF3Y8WxDl7f/KBHvIImyPrq6ngIuBp41AYbehh/tUXk3PFu0aLJgaU0GuDpFgv6dYQdccgThW/pimdPFh8lHXn/R5jukK4/Rcw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cS/TiBom; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DibwPNbn; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cS/TiBom"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DibwPNbn" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64E8EPU91621090 for ; Thu, 14 May 2026 09:11:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0sOG4Pf5i797Nk7IZxKARPdtVNQssiq4kiFqW2LPT+A=; b=cS/TiBomZ8UTWeIv WqqhxZuIzZOCw4IjcpYdPZJnjv1rTZ9EaUkZuqOLl0o23iNNEYWw4HpI0A7NKpn5 c2F7zHvOunZ6yST7ZgjNSOMBkwqx6Sa4KZ64g30+zbcugo3YrhuS6D3cKETBmD6t MV7yE+UJ+fkPMli6Woi8n93IWA14kvXSKKAIfJu3DQer3XxlCjChTsYdvmdSEhd+ aOIuBhhhqUa2ZJeoM+eZMdDMuPdMOZdeHOLoOaEdMKcmmwquHocJ58RSDQTzO0Eg KOyO39X+zsAabXf2G4TbekvWGm30Z3Pqd/NdK8RYUUnmZ3W+swzgYFs9rk0zRaKZ 9JdlTw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5492sfg0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 14 May 2026 09:11:13 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50fb98b09d3so23934961cf.2 for ; Thu, 14 May 2026 02:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778749872; x=1779354672; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0sOG4Pf5i797Nk7IZxKARPdtVNQssiq4kiFqW2LPT+A=; b=DibwPNbnupuUJqkyGyVND5RfQ91rLmU5joU+MP2hbwcts9i15lEhvmKOJPgkWELRTU Hnv9+nHCFrjXsY2VHCcfrS3Q2VYPu3wYdGeo0CVYruUg9zmjWYlbk2mHOx79Dh6gYTsI 2lh+a3RuWsxeBkC8hf04rxgQ0zN+GyuKuABfzjTd5KFziooVNFoJAWR0blZmsFDJn/bb 5JLXBerOe32RJHFhwdP7mESsekfTIvJgK59rUht+UUtW2pFG3D/8aDpHMScI1qzVb8Ct vmj9KBeFsFACimem5ev4dJG8J+wbbpVV/x+9jG8ClLr3S8SXCr76io88mW90C+fjJqjL yKpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778749872; x=1779354672; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0sOG4Pf5i797Nk7IZxKARPdtVNQssiq4kiFqW2LPT+A=; b=fDS0ESYeJ/P0/WjgUp0iLFHPM/opOZM5P0UWyOFAGNwj+MIkqBgLRJlfvYL+jDq1EC oP6ZYdYTQlRd54Zu6GVaitXUapETlTsTmUYgD0NAuWKhOCdmcGJdoxgaJVTro2AB032A y9FEFsbph51WQPMqU27nWImlVuaz0NPrz31edlMNVTk4+ya+BWksfZspm1yHn4XVkeUX G/9eVcEZUrJdTb1M2gj+Wzn78uA0OQ0SVAgiyDfOmjQfEFrhdUrThQ3SXWROGGAEu9lB 0e72ZnLIdj8+jcCIRt3F8IiJog310PgXxJEmb3sK6Z8/yHpZ+QezMMSjJcT/HXBMOSN2 qZYg== X-Forwarded-Encrypted: i=1; AFNElJ9uUTp38mRr++dH4/CvcZlso496rrb0gdIMs4FFmZfXR8w+xV7ntiOf3V8vBGSnwIwx8DqE2OXaxSknK3Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwcPYKlniaoikAfoHOcJKhBxnR81lUkkLPo8vXoP3G9XFm0Y7nP PGj2na2iQjNXcntQNufbk1RPN9KXXldFGgjya4uauNptZ/beeiQcNOg5PI4Wbe5QRGVA/h6787g GVEoYUdqYVn5AazuqROsoCqI77x0TqKVoutyEUaOM1MYvrSLL9rERzh0tE51SRWRZXhs+CNP296 U= X-Gm-Gg: Acq92OEAkGzmzFSWG98tSDKu7wOt6UTMjDVp6n3dXCDV5wo19BWOu/++BOFj091umcW SBt/n9qJOi6VlKfF7q4qdA5ehlYHbiCdTLzUBWvWjWrNmKUP9AL37qC108VYJMAQCUy8pHDJkPZ P6sg3fZhCcxVZeeOI2Ztl5AKHQGHDMxc4SLzrmC9SuFAwN7+GBq5Lx857ZKojR7nX3CoMPnySBf Tthm1Ausabhhq092hZClgImxYg9u7tgvvkTC14Cagyo5DafJ6h4N59b4xxh1StgConvKJmGyutP sx3s9ajG2SMy9+naIvH5ExVFIj/lX1NY1XKW/cyHgoUpCE98qRGc9GD9/ZqzXZK6gXtThiyC3hH AVDkWhKZ8iK4xXdQLcJexnwyuX4pUjkcaRVgGIL3CoejuB06KVowEzzMwGcXyNTQNxPDdQFujx3 V8EcsKA8Tn7n6sjw== X-Received: by 2002:a05:622a:5818:b0:50e:5e6a:c7d5 with SMTP id d75a77b69052e-5162f447e81mr62623751cf.1.1778749872302; Thu, 14 May 2026 02:11:12 -0700 (PDT) X-Received: by 2002:a05:622a:5818:b0:50e:5e6a:c7d5 with SMTP id d75a77b69052e-5162f447e81mr62623481cf.1.1778749871750; Thu, 14 May 2026 02:11:11 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6831187ecf7sm494479a12.30.2026.05.14.02.11.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 May 2026 02:11:10 -0700 (PDT) Message-ID: <048b1110-2de6-485e-995d-e328df69dcb2@oss.qualcomm.com> Date: Thu, 14 May 2026 11:11:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] soc: qcom: rpmpd: Add Shikra RPM Power Domains To: Rakesh Kota Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Ulf Hansson , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, kamal.wadhwa@oss.qualcomm.com, jishnu.prakash@oss.qualcomm.com References: <20260429-add_rpmpd_shikra-v1-0-fdba28564380@oss.qualcomm.com> <20260429-add_rpmpd_shikra-v1-2-fdba28564380@oss.qualcomm.com> <20260514084512.q5pzh226zdkuw53f@hu-kotarake-hyd.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260514084512.q5pzh226zdkuw53f@hu-kotarake-hyd.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 9AIpJnG8BIdQnPTsCpX0cgApEYMdBWEQ X-Authority-Analysis: v=2.4 cv=R74z39RX c=1 sm=1 tr=0 ts=6a0591b1 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=psDV2xRu-4Ixecqm65UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: 9AIpJnG8BIdQnPTsCpX0cgApEYMdBWEQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE0MDA5MSBTYWx0ZWRfXwXSeC+u5jzxC b0slkegGSXkMQYAQtPseRaWW2ngkIYCKynVovuhyqBVaZwq0VcNGFO6YP8+gWcKHqgOACwJkPzE iuWPt9naiac+/S4Rr5MaKyjZy7LK7ZNTWlXF9RkTsDEX6yoxTVA04tO9R37yU82Oj11kkDwEp4u MoJ2ehQNT5msO3WxDwUKKk/ZB0yHNsggBDsirstORfbhXr2TSsezNGQydE9spzc6kI88Q02REgs giyvE1EeWP+zmwEFZfyC2vd0OY8c1s0q1rzkHvl8fXlQGA5U/g1/Ky2zFHoxjrvyVSPKt0wIdsB Q01324I1J41bhU+G4pe5nX/kTkbz6sQI1Uh1zl4Izapq0lp/bahp2s8cEXeCcLjKI47HF93x611 eq3xPsFfjxnPC3CrC9bpK4QFrbMiCZelHZh64Fd+hAP1JcAh5TCg7BeFsOatVgE0CkHoqJSm7k6 A6EKFIonApS5ImKr7Lg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-14_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605140091 On 5/14/26 10:45 AM, Rakesh Kota wrote: > On Tue, May 12, 2026 at 02:16:07PM +0200, Konrad Dybcio wrote: >> On 4/29/26 4:09 PM, Rakesh Kota wrote: >>> Add RPM Power Domains support for the Shikra platform. >>> >>> Signed-off-by: Rakesh Kota >>> --- >>> drivers/pmdomain/qcom/rpmpd.c | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/drivers/pmdomain/qcom/rpmpd.c b/drivers/pmdomain/qcom/rpmpd.c >>> index 15a11ff282c3f86b1e86c6604d165e297620f6cf..6f751ee5a7833912d54d2bcfd5d85837ab7a97d3 100644 >>> --- a/drivers/pmdomain/qcom/rpmpd.c >>> +++ b/drivers/pmdomain/qcom/rpmpd.c >>> @@ -863,6 +863,21 @@ static const struct rpmpd_desc sdm660_desc = { >>> .max_state = RPM_SMD_LEVEL_TURBO, >>> }; >>> >>> +static struct rpmpd *shikra_rpmpds[] = { >>> + [RPMPD_VDDCX] = &cx_rwcx0_lvl, >>> + [RPMPD_VDDCX_AO] = &cx_rwcx0_lvl_ao, >>> + [RPMPD_VDDCX_VFL] = &cx_rwcx0_vfl, >>> + [RPMPD_VDDMX] = &mx_rwmx0_lvl, >>> + [RPMPD_VDDMX_AO] = &mx_rwmx0_lvl_ao, >>> + [RPMPD_VDDMX_VFL] = &mx_rwmx0_vfl, >>> +}; >> >> This is identical to sm6125_rpmpds. If you're sure the list is correct >> and complete (no LPI domains etc.), you can drop this patch, and proceed >> with just this change: >> > There is one difference — the max_state for Shikra is > RPM_SMD_LEVEL_TURBO_NO_CPR, whereas sm6125 uses RPM_SMD_LEVEL_BINNING. You're right Reviewed-by: Konrad Dybcio Konrad