From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39D18C6FA91 for ; Mon, 19 Sep 2022 11:29:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229484AbiISL3T (ORCPT ); Mon, 19 Sep 2022 07:29:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230264AbiISL20 (ORCPT ); Mon, 19 Sep 2022 07:28:26 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3B1622B35 for ; Mon, 19 Sep 2022 04:28:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663586902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oodm6OJpA67tJPepr09e9s0DknkTL2oMoUxFz8HlkE8=; b=GpEGyT3AEcvNN0j2XFNkpYSmRhB+O5oBJ/oyLK5F10qQ/5orQ/a6LoL+2EvZhSFr8TO+OT Bon89pq+Mm//QImmUGDvSSYybkrsvLqODRCjAwYxnbVLxek7YJL92HDXTjv5pE2Ge97jTi wRxf9uTrp060KVWYAlML/SySY5LlgFg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-17-xBxd94SoMDSZVJHQf9PzQw-1; Mon, 19 Sep 2022 07:28:21 -0400 X-MC-Unique: xBxd94SoMDSZVJHQf9PzQw-1 Received: by mail-wr1-f71.google.com with SMTP id o7-20020adfba07000000b00228663f217fso5761886wrg.20 for ; Mon, 19 Sep 2022 04:28:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=oodm6OJpA67tJPepr09e9s0DknkTL2oMoUxFz8HlkE8=; b=X/y7FttF/7QwSinS2Hz8SIKO6ULDg0xx4Fsja6rMJv6Y+bTgY22V+N+9jpriNxdRLh ni0GgaiD67KS9Nn7dwDX0+BfyE4/O/t69vgDMFk29/U01t+OHa2Ti0ES4EBTUJB2jRLQ bq0rV/XIBnQMMkOAt40hz3zXPNIE+5TP/H/WFa1P7b82PvJSO5gQSpXCAiEjGOPYLI7N nZbyVmeXuy3bA36/k//0tUY1Cme/kzaadkSjQsVlcgooUj/Dplqeh0F+UoljNIGDvauo JHFgyv5TXdfCrm8445n/xkByI0Qwbk0Oh2/t8W4T4Or9JJRWDOEgzcWpfyRM79wyoqRF 2tWQ== X-Gm-Message-State: ACrzQf30O64O6BKWskfKzNrmXv3E/33DwJ2umELpUMoqKSqLlKkAWrkM SD4uVYRV9otFU9kF9cvrdM32dwwy5c/H/Kj8AFqcLnRTpwEsDAhVi/Nc5Vr9m/faeZISbMj2oqw x70wTTs647xOrax3rroNb+Wip X-Received: by 2002:a5d:6483:0:b0:226:db59:2f94 with SMTP id o3-20020a5d6483000000b00226db592f94mr10366785wri.200.1663586900713; Mon, 19 Sep 2022 04:28:20 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Sl5nC0graOkIpn8iRTnr2fj+01+hG88H0gN7NiVwzUFFQD+UX9cyE6omnkL8gRdHZPEbfRw== X-Received: by 2002:a5d:6483:0:b0:226:db59:2f94 with SMTP id o3-20020a5d6483000000b00226db592f94mr10366773wri.200.1663586900420; Mon, 19 Sep 2022 04:28:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c703:c100:c136:f914:345f:f5f3? (p200300cbc703c100c136f914345ff5f3.dip0.t-ipconnect.de. [2003:cb:c703:c100:c136:f914:345f:f5f3]) by smtp.gmail.com with ESMTPSA id 26-20020a05600c231a00b003b47a99d928sm13420690wmo.18.2022.09.19.04.28.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 04:28:20 -0700 (PDT) Message-ID: <04907907-8eab-01ef-8341-e2fecb10b601@redhat.com> Date: Mon, 19 Sep 2022 13:28:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Content-Language: en-US To: Michael Nazzareno Trimarchi Cc: Mike Rapoport , LKML , Andrew Morton References: <826cd775-14d2-12ae-2e96-cf0766aa1502@redhat.com> <4475783a-73c1-94f1-804e-507abeb84ab1@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: Correlation CMA size and FORCE_MAX_ZONEORDER In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19.09.22 13:17, Michael Nazzareno Trimarchi wrote: > Hi > > On Mon, Sep 19, 2022 at 1:03 PM David Hildenbrand wrote: >> >> On 19.09.22 11:57, Michael Nazzareno Trimarchi wrote: >>> Hi >>> >>> On Mon, Sep 19, 2022 at 11:31 AM David Hildenbrand wrote: >>>> >>>> On 19.09.22 11:17, Michael Nazzareno Trimarchi wrote: >>>>> Hi David >>>>> >>>>> On Mon, Sep 19, 2022 at 10:38 AM David Hildenbrand wrote: >>>>>> >>>>>> On 15.09.22 23:36, Michael Nazzareno Trimarchi wrote: >>>>>>> Hi all >>>>>> >>>>>> Hi, >>>>>> >>>>>>> >>>>>>> Working on a small device with 128MB of memory and using imx_v6_v7 >>>>>>> defconfig I found that CMA_SIZE_MBYTES, CMA_SIZE_PERCENTAGE >>>>>>> are not respected. The calculation done does not allow the requested >>>>>>> size. I think that this should be somehow documented and described but >>>>>>> I did not >>>>>>> find the documentation. Does it work this way? >>>>>>> >>>>>>> With CMA_SIZE of 8MB I need to have FORCE_MAX_ZONEORDER=12 if I have >>>>>>> the default FORCE_MAX_ZONEORDER=14 the min size is 32Mb >>>>>> >>>>>> The underlying constraint is that CMA regions require a certain minimum >>>>>> alignment+size. They cannot be arbitrarily in size. >>>>>> >>>>>> CMA_MIN_ALIGNMENT_BYTES expresses that, and corresponds in upstream >>>>>> kernels to the size of a single pageblock. >>>>>> >>>>>> In previous kernels, it used to be the size of the largest buddy >>>>>> allocation granularity (derived from MAX_ORDER, derived from >>>>>> FORCE_MAX_ZONEORDER). >>>>>> >>>>>> On upstream kernels, the FORCE_MAX_ZONEORDER constraint should no longer >>>>>> apply. On most archs, the minimum alignment+size should be 2 MiB >>>>>> (x86-64, aarch64 with 4k base pages) -- the size of a single pageblock. >>>>>> >>>>>> So far the theory. Are you still running into this limitation on >>>>>> upstream kernels? >>>>>> >>>>> >>>>> I can run 6-rc2 on my board. I test again but according to it, if I >>>>> put 4M as CMA in cma=4M in boot >>>>> parameters, the result is 32Mb of CMA. Apart of that seems that >>>>> process lime tiny membench can not even start >>>>> to mblock memory >>>>> >>>> >>>> The CMA alignemnt change went into v5.19. If "cma=4M" still gives you > >>>> 4M, can you post /proc/meminfo and the early console output? >>>> >>> >>> cat /proc/cmdline >>> cma=4M mtdparts=gpmi-nand:4m(nandboot),1m(env),24m(kernel),1m(nanddtb),-(rootfs) >>> root=ubi0:root rw ubi.mtd=ro >>> otfs rootfstype=ubifs rootwait=1 >>> # cat /proc/meminfo >>> MemTotal: 109560 kB >>> MemFree: 56084 kB >>> MemAvailable: 56820 kB >>> Buffers: 0 kB >>> Cached: 39680 kB >>> SwapCached: 0 kB >>> Active: 44 kB >>> Inactive: 644 kB >>> Active(anon): 44 kB >>> Inactive(anon): 644 kB >>> Active(file): 0 kB >>> Inactive(file): 0 kB >>> Unevictable: 39596 kB >>> Mlocked: 0 kB >>> HighTotal: 0 kB >>> HighFree: 0 kB >>> LowTotal: 109560 kB >>> LowFree: 56084 kB >>> SwapTotal: 0 kB >>> SwapFree: 0 kB >>> Dirty: 0 kB >>> Writeback: 0 kB >>> AnonPages: 628 kB >>> Mapped: 1480 kB >>> Shmem: 84 kB >>> KReclaimable: 4268 kB >>> Slab: 8456 kB >>> SReclaimable: 4268 kB >>> SUnreclaim: 4188 kB >>> KernelStack: 392 kB >>> PageTables: 88 kB >>> NFS_Unstable: 0 kB >>> Bounce: 0 kB >>> WritebackTmp: 0 kB >>> CommitLimit: 54780 kB >>> Committed_AS: 1876 kB >>> VmallocTotal: 901120 kB >>> VmallocUsed: 2776 kB >>> VmallocChunk: 0 kB >>> Percpu: 72 kB >>> CmaTotal: 32768 kB >>> CmaFree: 32484 kB >>> # uname -a >>> Linux buildroot 6.0.0-rc5 #20 SMP Mon Sep 19 11:51:26 CEST 2022 armv7l GNU/Linux >>> # >>> >>> Then here https://pastebin.com/6MUB2VBM dmesg >>> >>> CONFIG_ARM_MODULE_PLTS=y >>> CONFIG_FORCE_MAX_ZONEORDER=14 >>> CONFIG_ALIGNMENT_TRAP=y >>> ... >>> CONFIG_CMA >>> CONFIG_CMA_AREAS=7 >>> ... >>> >>> CONFIG_CMA_SIZE_MBYTES=8 >>> CONFIG_CMA_SIZE_SEL_MBYTES=y >>> >> >> Thanks! >> >> I assume that in your setup, the pageblock size depends on MAX_ORDER >> and, therefore, FORCE_MAX_ZONEORDER. >> >> This should be the case especially if CONFIG_HUGETLB_PAGE is not defined >> (include/linux/pageblock-flags.h). >> >> In contrast to what I remember, the pageblock size does not seem to >> depend on the THP size (weird) as well. >> >> >> So, yes, that limitation is still in effect for some kernel configs. >> >> One could make the pageblock size configurable (similar to >> CONFIG_HUGETLB_PAGE_SIZE_VARIABLE) or simply default to a smaller >> pageblock size as default with CONFIG_CMA and !CONFIG_HUGETLB_PAGE. >> >> I imagine something reasonable might be to set the pageblock size to >> 2MiB without CONFIG_HUGETLB_PAGE but with CONFIG_CMA. >> > > I don't think making more configuration options makes things clear. Yes, in an ideal case it should be automatic. > When we enable some configuration > we can force down the configuration. You need to explain clearly how > you envision it. FORCE_MAX_ZONEORDER > for me is the largest allocation that you can get from a zone (ex CMA > one). Any request allocation that is align to the FORCE_MAX_ZONEORDER is just a way to increase/decrease the maximum allocation size of the buddy in general. > CMA align and can fit inside a region should be allowed > > What am I missing? I think that the issue is that the CMA alignments nowadays depend on the pageblock size. And the pageblock size depends on *some* configurations on the maximum allocation size of the buddy. Documenting the interaction between FORCE_MAX_ZONEORDER and CMA size alignment is not trivial. For example, with CONFIG_HUGETLB_PAGE there might not be such an interaction. With CONFIG_HUGETLB_PAGE, there clearly is one. Let me phrase it this way: is it good enough in you setup to get 32mb vs 8mb or do you want/need to reduce it without adjusting FORCE_MAX_ZONEORDER ? -- Thanks, David / dhildenb