Re: [PATCH v2 1/3] dt-bindings: i3c: Add Qualcomm I3C master controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On 29/03/2025 10:08, Mukesh Kumar Savaliya wrote:
>>>>> +  I3C in master mode supports up to 12.5MHz, SDR mode data transfer in mixed
>>>>> +  bus mode (I2C and I3C target devices on same i3c bus). It also supports
>>>>> +  hotjoin, IBI mechanism.
>>>>> +
>>>>> +  I3C Controller nodes must be child of GENI based Qualcomm Universal
>>>>> +  Peripharal. Please refer GENI based QUP wrapper controller node bindings
>>>>> +  described in Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml.
>>>>> +
>>>>> +allOf:
>>>>> +  - $ref: i3c.yaml#
>>>>> +
>>>>> +properties:
>>>>> +  compatible:
>>>>> +    const: qcom,i3c-master
>>>>
>>>> And this got worse. It makes also no sense either: how can you claim
>>>> that this covers all possible future I3C masters from Qualcomm?
>>>>
>>>> What was the resolution of previous discussion?
>>>>
>>> Below was my understanding and reply.
>>> "
>>> I think i should remove const. kept it for now as no other compatible to
>>> be added as of now.
>>> let me remove const.
>>> SoC name is not required, as this compatible is generic to all the SOCs.
>>
>> I don't see any talks about const, what are you referring to?
>>
> +properties:
> +  compatible:
> +    : qcom,i3c-geni
> will this be fine ?

Yes, I think that was also suggested by Rob. Or rather follow existing
style so qcom,geni-i3c for the compatible and filename.


Best regards,
Krzysztof