From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Eric Dumazet <edumazet@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] kernel: sysctl: change ipfrag_high/low_thresh to CTL_ULONG
Date: Sat, 25 May 2019 17:00:03 +0800 [thread overview]
Message-ID: <049648ab-0e51-c079-b7c8-c9022cae20b4@huawei.com> (raw)
In-Reply-To: <CANn89i+rSEJ3Rqd5JW-w7aLzETMX89Qgg3wne9Ae7WWDBe3yZg@mail.gmail.com>
On 2019/5/24 23:00, Eric Dumazet wrote:
> On Fri, May 24, 2019 at 7:30 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>> 3e67f106f619 ("inet: frags: break the 2GB limit for frags storage"),
>> changes ipfrag_high/low_thread 'type' from int to long, using CTL_ULONG
>> instead of CTL_INT to keep consistent.
>
> What about compatibility with existing applications ?
> Will there sysctl() fail if they provide 32bit variable ?
>
> /proc/sys/net files are text files, but sysctl() system call has been
> discouraged for more than a decade.
The sysctl() system call is deprecated, so the main purpose of this patch is to keep consistent,
but it does set wrong value(eg, set 16000000000 to ipfrag_high_thresh) when use sysctl().
>
>
prev parent reply other threads:[~2019-05-25 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 14:38 Kefeng Wang
2019-05-24 15:00 ` Eric Dumazet
2019-05-25 9:00 ` Kefeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=049648ab-0e51-c079-b7c8-c9022cae20b4@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®