mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>, Jim Mattson <jmattson@google.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kvm <kvm@vger.kernel.org>, "Radim Krčmář" <rkrcmar@redhat.com>,
	"Wanpeng Li" <wanpeng.li@hotmail.com>,
	"Nadav Amit" <nadav.amit@gmail.com>,
	"Dmitry Vyukov" <dvyukov@google.com>
Subject: Re: [PATCH v2] KVM: VMX: Fix rflags cache during vCPU reset
Date: Tue, 5 Dec 2017 14:54:02 +0100	[thread overview]
Message-ID: <049b65c8-63a2-4c67-b66f-3b063038e3f8@redhat.com> (raw)
In-Reply-To: <CANRm+Cz04gsXJLkZn4++XBB8i481bOuEpk5_BCfWgzxCHaHRHg@mail.gmail.com>

On 05/12/2017 01:53, Wanpeng Li wrote:
>> That seems like a convoluted path to produce an illegal RFLAGS value.
>> What's to prevent syzkaller from simply clearing bit 1 of RFLAGS with
>> the KVM_SET_REGS ioctl?
> Yeah, it can happen. Which do you prefer, ioctl fails or |
> X86_EFLAGS_FIXED unconditionally in the ioctl handler in kvm?

I suspect somebody might be passing an all-zero regs struct to
KVM_SET_REGS, so ORing X86_EFLAGS_FIXED is better.

Thanks,

Paolo

  reply	other threads:[~2017-12-05 13:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-20 22:52 Wanpeng Li
2017-11-20 23:09 ` Paolo Bonzini
2017-11-21  0:34   ` Wanpeng Li
2017-12-05  0:28     ` Jim Mattson
2017-12-05  0:53       ` Wanpeng Li
2017-12-05 13:54         ` Paolo Bonzini [this message]
2017-12-05 17:53           ` Jim Mattson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=049b65c8-63a2-4c67-b66f-3b063038e3f8@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=dvyukov@google.com \
    --cc=jmattson@google.com \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nadav.amit@gmail.com \
    --cc=rkrcmar@redhat.com \
    --cc=wanpeng.li@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®