From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96E1D2E9755 for ; Mon, 17 Nov 2025 15:02:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763391754; cv=none; b=sRVeQk1+DU2cI3FgzWL6evRIf4YAaHXPrS1C7Tz3aUd2CU5RzZ/Vuc3gD68aJsxO0+yT9x+2Wa3lHTPrfZP2smNj8NVWuaKkIdem/mLRA8nFarllROVMSJRi8Vi9RENVzRoSz7fXpGKmTQ6VK5z4rrmuAK0sqwpiwyfQulxYkCM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763391754; c=relaxed/simple; bh=ew7GBoPcDCjTaUrzg1fyYo9L4unv0OboG21mt9EvHRU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EWTdtxXIzR5BiaLuPcfMmjjnJVQj9iofwcBnAA9xDDyLFS9KUaVuj4wHI6ut1rLtRYUVdp+7uQUjRNBd7avDPQ1wgAoyMaPWL+KBuUJ3Lp33RY4XHHDGjeQKomY1VKOo5brn9TY3kvcg5cLftOJDnz/Ec9G38pti8a1jwyaefqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Rxr5i0oi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Gu7NGFY1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Rxr5i0oi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Gu7NGFY1" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AHB1Wr72582094 for ; Mon, 17 Nov 2025 15:02:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2ef1fLkfHBFXiSME/ii8xpkgp4NebP/rTeWyzU9gVLk=; b=Rxr5i0oirw1zAggV Exsm9UtDszwgt4OytMP/A138pIOZHoSLVbNvWFjLw0AC2Jh0IjxibjboFo2dICbj m3wg4hByNUpbBfr/Lae7/q/vCYSYVjVYDk3HSzcmQhAm0EdNUbZj5Z3EprZaSUfO V6qAWlKbe2lScqp/1N6hGPirg/XGixrVxtvCvniMeiy/rvWujvJK9soodiL8OnnF daKfH/gOVkf5hu+pK0Txnm2RYW3pCyx3z2maC8qXfKvoTf6cmz+8W8AuXb/3KjXC kljcfqGaQPDShqn4P3OwdW1xjRHT7OWrNy+9CeGUXgDSnLSVIvgGON9g+s/meWq7 PUqNwA== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4afssfa5w6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Nov 2025 15:02:31 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-5dfb8e7d182so666020137.1 for ; Mon, 17 Nov 2025 07:02:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763391751; x=1763996551; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2ef1fLkfHBFXiSME/ii8xpkgp4NebP/rTeWyzU9gVLk=; b=Gu7NGFY17MNrqzTBKpJKbCbeDBXH4hBjGfwdRbmbXmfDn+GkTSBWHmhKG0CQe8lwC2 4aVFDFTbdvAAEPKK4LtQAIkgiRa2Dp4LRsCCoBPMVaco0/BNyvUHsBreNfYjxHWvWsk/ fpZdDVz1HgaP/MKGzXVQG1MSkCAlBKAA86eFUFQXya/v080UTusJUpoYC8JGxSRg8i0i vkVZSLKLMNeXnog9fhzvfBoO/zj5P6r29bJoRQFXCugDzQJ3E/LCHtP1HrPLO52+zGai e7WiT780OJ3Gs/H2Dg7j9Z2FMzD+L3VOa4NUNPX12v8spVsoPCM83yw/HM9B4BrLXnAc rgEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763391751; x=1763996551; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2ef1fLkfHBFXiSME/ii8xpkgp4NebP/rTeWyzU9gVLk=; b=t6ZtN17efSSggvUTT1HoEBgWXwDrVkuo3B9n41fYxqxdsVDweQKJ72drBOTQuQYxY1 2nNgAZPJnUS5jpOsNZcjd1ljdFjMyAqTrqT+wuM04L1gJ7ZabS6Gk7FygFK1npwUX8jC 7z0d7JXDplmwvGIF4WXvJmLlGp1VtcaeNm0xfNI7ZWLsp/vai+6jZ+ixNGpE3IjMsoJg 5rOrZiEQR1S1VYZmQtDLTqF3bl+vIHRj6f1AugvN7Ul9iJlXGHKlEiNEQztlhREZNouC Q4WboQbFh4zjRgYImgJJuZ2JQ9YVDjdrz1WIV1zxP/HYUaCDmmiyVj+Hvxn3P1WFqUh9 2PUg== X-Forwarded-Encrypted: i=1; AJvYcCW2PXXja8FI0ibuoDXymDJkgAvnuSxk7kZyPPzreEBKQTUmoN6Rw8rc8/lutSY0T9rrMSPmI+NipZtHu6o=@vger.kernel.org X-Gm-Message-State: AOJu0YzG+NFMw/km6FeMzWKJ8uD+0mW+XOED280iGCj8c/crXZrn0EVT 8bB2YCGec3XZoOCzIpugd+rsLtjMOVXyqVqYm7LMkx6uDkSnowkxwhM75tAWnYB12KMKl/8J1gi NJeCwxuxOxhC40URI1XtOTDMcpHdHKylLSp5RoM+kFI1JRy1NnoMM+oi+u5BKM7Vj2c8= X-Gm-Gg: ASbGncvanRZ4i5lNHjqlLeHRia89A3ZAUJtl2Ouj9zrliWpicd0F7JOANsXEkVgvYY/ i9tpm9gB/Hl92c088wOKyMR7BzUxe9capwR+0QIeUm1uMLH6+/XRYDmmKGhAZAABUtw0n5dqytZ WcPHn9KajOP4/O5e6TKYCylUpOevPduOfZtiN3l6Sw2L3mKJRVTwqqvkileWCKjI4LHv8VWU1YN aR9y9GGGdi41vjJJD5ZM/jmk2jBGhQ/7qnNPe3WroTPjDI0rDUzhUKBLQLNEzFDmGNYsx58PLZw 6HAojGqQd7C8yOKfaWl2ZFcFWvSthOggVyfm/39mPdHuHmdyRteWDwTvE3NsKv0cTqGn5S3q54M eDLhP7Fx2OWeNVIStCKOq7q/X2AiwbglbpLVJ4DUg8f/xDjG3VugWHn5m X-Received: by 2002:ac5:c818:0:b0:55b:ac1:d05f with SMTP id 71dfb90a1353d-55b1e8e656bmr1366538e0c.0.1763391750452; Mon, 17 Nov 2025 07:02:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IF3gTN2k6xAY3h/CeIVWmGva+PTDh6zNiEHBeDvsWL5An00LUHJvO9nFZJUxYNN6II0l3pA5A== X-Received: by 2002:ac5:c818:0:b0:55b:ac1:d05f with SMTP id 71dfb90a1353d-55b1e8e656bmr1366500e0c.0.1763391749842; Mon, 17 Nov 2025 07:02:29 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-644f132653fsm981327a12.15.2025.11.17.07.02.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 07:02:27 -0800 (PST) Message-ID: <04aec988-59ba-4c98-b922-510d86b10ea5@oss.qualcomm.com> Date: Mon, 17 Nov 2025 16:02:25 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm: adreno: fix deferencing ifpc_reglist when not declared To: Neil Armstrong , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20251117-topic-sm8x50-fix-a6xx-non-ifpc-v1-1-e4473cbf5903@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251117-topic-sm8x50-fix-a6xx-non-ifpc-v1-1-e4473cbf5903@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: PSlRSwLz6J6P4EmOSB6PHthgXm4VbQJ- X-Proofpoint-GUID: PSlRSwLz6J6P4EmOSB6PHthgXm4VbQJ- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE3MDEyNyBTYWx0ZWRfX7cgfYHccOIXJ RHz4Z2Lg41I1krrsR4QiAXiaKzPZDGUhmTVjr2ucKFVhgZK0iFirhXyKkgi2woH3XaKOqMGig+I vQlo1/RcDD7J8EQ6o3z2oyNQ6hPH0EP2w/0K23TqQr99OwKDZmteMCmN397DVz2ztExG2Q4BrfJ HLFyHTI5jxykQVXysA0ioncsAEOi5BboscXPY+CSm2shyOIKUJcJfg2qVtex2+Be2EgoHEPlqdL CAqZ1BCt/4QrV96nz3g6PZmOuv1fn+2sjN+IdQKeeYzloqtvnd4eGFP9Jb7H4ZrFg4ZQsi0v1Fr x+L4YDOYvmJu0+Acle4oHRx2zoTTr3s/15o93HahfETVbkKFogQaywliQ6OSb3BXnVxoLUIL90w th9wsOdlU8tM4Jowcw8csn0y81GOYg== X-Authority-Analysis: v=2.4 cv=IrkTsb/g c=1 sm=1 tr=0 ts=691b3907 cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=5-YDskA_wAJxIDT2F10A:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-17_03,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 spamscore=0 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511170127 On 11/17/25 3:51 PM, Neil Armstrong wrote: > On plaforms with an a7xx GPU not supporting IFPC, the ifpc_reglist > if still deferenced in a7xx_patch_pwrup_reglist() which causes > a kernel crash: > Unable to handle kernel NULL pointer dereference at virtual address 0000000000000008 > ... > pc : a6xx_hw_init+0x155c/0x1e4c [msm] > lr : a6xx_hw_init+0x9a8/0x1e4c [msm] > ... > Call trace: > a6xx_hw_init+0x155c/0x1e4c [msm] (P) > msm_gpu_hw_init+0x58/0x88 [msm] > adreno_load_gpu+0x94/0x1fc [msm] > msm_open+0xe4/0xf4 [msm] > drm_file_alloc+0x1a0/0x2e4 [drm] > drm_client_init+0x7c/0x104 [drm] > drm_fbdev_client_setup+0x94/0xcf0 [drm_client_lib] > drm_client_setup+0xb4/0xd8 [drm_client_lib] > msm_drm_kms_post_init+0x2c/0x3c [msm] > msm_drm_init+0x1a4/0x228 [msm] > msm_drm_bind+0x30/0x3c [msm] > ... > > Check the validity of ifpc_reglist before deferencing the table > to setup the register values. > > Fixes: a6a0157cc68e ("drm/msm/a6xx: Enable IFPC on Adreno X1-85") > Signed-off-by: Neil Armstrong > --- I think it should be fine to skip calling this func altogether if !ifpc || !pwrup_reglist Although ifpc && !pwrup_reglist should probably scream very loud Konrad